Page MenuHomePhabricator

Support two-factor authentication on CentralAuth wikis
Closed, ResolvedPublic

Description

Currently, 2FA via OATHAuth is not compatible with CentralAuth's SSO. A user would have to enable 2FA on every SUL wiki individually (and setup 2FA on any future wikis the WMF deploys as soon as it's deployed), with a different secret, and login using the correct wiki's secret. Otherwise, an attacker can login using just a password on a SUL wiki where 2FA isn't enabled for the account, and CentralAuth will auto-login the user on any other wiki.

Event Timeline

csteipp raised the priority of this task from to High.
csteipp updated the task description. (Show Details)
csteipp subscribed.
Legoktm renamed this task from Support two-factor authentication on WMF SUL wikis to Support two-factor authentication on CentralAuth wikis.Jul 31 2015, 7:24 PM
Legoktm set Security to None.

Should this be blocked on the AuthManager re-write?

Thanks @Samwalton9, I hand't seen that.

Right now, the extensions that handles 2FA on wiki (OATHAuth) only applies the setting on a single wiki, but SUL allows a user account to login on any wiki and then be logged in across projects. So we're not able to do this currently, unless a developer wants to make OAUTHAuth CentralAuth-aware.

@Andrew - We're planning to merge a bunch of OATH patches this week, one which requires a maintenance script to be run on labswiki (updating the scratch token storage format). Is there a good time to schedule that with you?

@csteipp, any deployer should have the rights to run the script, so finding someone to run it should be easy. I don't much care when you do it, although I typically schedule wikitech maintenance well away from any other maintenance or deployment windows since people are generally looking at wikitech docs while deploying.

@Andrew, I probably should have given you more warning, but I've got this deployment schedule in about 30 mins. If anything looks odd, I'll revert. But like I said, there's very little chance of this affecting users.

Change 289486 had a related patch set uploaded (by CSteipp):
Enable Ex:OATHAuth on test wikis, disabled for all users

https://gerrit.wikimedia.org/r/289486

Change 289486 merged by jenkins-bot:
Enable Ex:OATHAuth on test wikis, disabled for all users

https://gerrit.wikimedia.org/r/289486

OATH has been rolled out to testwiki and test2wiki. Everything seems to be working as expected. Assuming no issues come up, I'll make it available on all wikis (to Staff global group only) tomorrow in SWAT.

Change 290271 had a related patch set uploaded (by CSteipp):
Enable Ex:OATH on CentralAuth wikis, limited rights

https://gerrit.wikimedia.org/r/290271

Change 290271 merged by jenkins-bot:
Enable Ex:OATH on CentralAuth wikis, limited rights

https://gerrit.wikimedia.org/r/290271

This was officially resolved as of the date that AuthManager was enabled on public wikis.

This was officially resolved as of the date that AuthManager was enabled on public wikis.

What's the ETA for 2FA available for eg. admins on public wikis?

This was officially resolved as of the date that AuthManager was enabled on public wikis.

What's the ETA for 2FA available for eg. admins on public wikis?

Seconding to this comment. It would be great for checkusers, oversights and other people with non-public-data access.

When I login my wiki account, I fill my user name and password. then I sowing this massage.- " Please enter a verification code from your authentication device

Token

Continue login"
I don't know what's token so I can't login wiki account. Please help me.

@Rameshti: This task is about making the software allow two-factor authentication. This task is resolved as the software can do this now.
This task is not a general support forum for problems with specific wiki accounts. Please see T163036 instead. Thanks for your understanding!