getSiteLinkPageName should not need to load the full entity. We can use SiteLinkLookup here. (yes, that has the issue that we still do not badges in the SiteLink objects here -- which we really should fix!) But if all we want is page name, then SiteLinkLookup would work and would be less evil than loading the entity.
see T108841 where it has become an issue in the database logs. mw.wikibase.sitelink is used a lot on Russian Wikipedia.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use SiteLinkLookup in WikibaseLuaBindings for getSiteLinkPageName | mediawiki/extensions/Wikibase | master | +19 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hoo | T108841 [Bug] Expectation (masterConns <= 0) by MediaWiki::main not met: (via Wikibase Lua code) | |||
| Resolved | aude | T108928 [Task] Don't load full entity in WikibaseLuaBinding::getSiteLinkPageName |
Change 231533 had a related patch set uploaded (by Daniel Kinzler):
Use SiteLinkLookup in WikibaseLuaBindings for getSiteLinkPageName
Change 231533 merged by jenkins-bot:
Use SiteLinkLookup in WikibaseLuaBindings for getSiteLinkPageName