Page MenuHomePhabricator
Create Task
Maniphest T109171

[RFC] wikibase (composer) libraries register resource loader modules during autoloader startup
Closed, InvalidPublic
Actions

Description

Wikibase (composer) libraries register resource loader modules during autoloader startup. This requires Mediawiki knowledge usually only extensions have. What should we do about that?

This even happens when the extension that requires these components is not loaded.

mediawiki/extensions/Wikidata (master=)$ ack MEDIAWIKI --nogroup
Wikidata.localisation.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
Wikidata.php:2:if ( !defined( 'MEDIAWIKI' ) ) {
vendor/diff/diff/Diff.php:10:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/geo/Geo.php:20:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/validators/Validators.php:20:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/number/Number.php:20:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/time/Time.php:20:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/data-types/DataTypes.php:22:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/data-types/DataTypes.mw.php:12:if ( !defined( 'MEDIAWIKI' ) ) {
vendor/data-values/data-values/DataValues.php:22:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/common/Common.php:25:if ( defined( 'MEDIAWIKI' ) ) {
vendor/data-values/interfaces/Interfaces.php:25:if ( defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/data-model/WikibaseDataModel.php:17:if ( defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/internal-serialization/mediawiki.php:3:if ( defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/data-model-javascript/init.php:5:if ( defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/data-model-javascript/init.mw.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/javascript-api/WikibaseJavaScriptApi.php:15:if ( defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/javascript-api/init.mw.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/data-model-serialization/mediawiki.php:3:if ( defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/serialization-javascript/init.php:5:if ( defined( 'MEDIAWIKI' ) ) {
vendor/wikibase/serialization-javascript/init.mw.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/PropertySuggester/tests/evilMediaWikiBootstrap.php:5:define( 'MEDIAWIKI', true );
extensions/Wikidata.org/WikidataOrg.php:32:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/WikimediaBadges/WikimediaBadges.php:16:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/ValueView/ValueView.mw.php:10:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/ValueView/ValueView.php:20:if ( defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/client/WikibaseClient.php:39:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/lib/WikibaseLib.php:33:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/lib/includes/modules/SitesModuleWorker.php:169:             return $site->getType() === Site::TYPE_MEDIAWIKI && in_array( $site->getGroup(), $groups );
extensions/Wikibase/view/init.mw.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/view/WikibaseView.php:15:if ( defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/purtle/init.mw.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/purtle/Purtle.php:15:if ( defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/repo/tests/phpunit/includes/content/EntityHandlerTest.php:161:              $this->assertFalse( $handler->canBeUsedOn( Title::makeTitle( NS_MEDIAWIKI, "Foo" ) ),
extensions/Wikibase/repo/config/Wikibase.searchindex.php:24:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/repo/Wikibase.php:35:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/lib/includes/modules/SitesModuleWorker.php:169:             return $site->getType() === Site::TYPE_MEDIAWIKI && in_array( $site->getGroup(), $groups );
extensions/Wikibase/view/init.mw.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/view/WikibaseView.php:15:if ( defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/purtle/init.mw.php:3:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/purtle/Purtle.php:15:if ( defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/repo/tests/phpunit/includes/content/EntityHandlerTest.php:161:              $this->assertFalse( $handler->canBeUsedOn( Title::makeTitle( NS_MEDIAWIKI, "Foo" ) ),
extensions/Wikibase/repo/config/Wikibase.searchindex.php:24:if ( !defined( 'MEDIAWIKI' ) ) {
extensions/Wikibase/repo/Wikibase.php:35:if ( !defined( 'MEDIAWIKI' ) ) {

Related Objects
Search...

StatusSubtypeAssignedTask
 InvalidNoneT108946 [Epic] Improve the development infrastructure
ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT181709 Cleanup Phabricator tickets once the build is dead
 DeclinedNoneT95663 [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor
 ResolvedaudeT95673 Add inital support in WikidataBuildResources for install via composer-merge-plugin
 ResolvedJeroenDeDauwT97560 enable use of a composer created autoloader in extensions deployed to production
 ResolvedWMDE-leszekT101164 [Task] make ValueView into a lib or do not require it via composer.json
 InvalidNoneT102246 [Task] extensions may not use class_exists to check if an extension is loaded
 InvalidNoneT92980 [Story] Convert all extensions that are part of the Wikidata build to use the new extension registration
 ResolvedNoneT88258 Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration
 ResolvedVictorbarbuT119766 Composer's autoloader should be autoloaded in extension registry (if configured)
 ResolvedLucas_Werkmeister_WMDET223214 Start converting Wikibase extensions to use extension registration
 ResolvedLadsgroupT256228 Convert WikibaseClient to use extension registration
 ResolvedLucas_Werkmeister_WMDET256238 Remove WB_VERSION, WBL_VERSION, WBC_VERSION constants
 DeclinedTarrowT256241 Check whether Client can load Lib without PHP entry point
 ResolvedLucas_Werkmeister_WMDET256243 Migrate Client API modules to extension JSON file
 ResolvedLucas_Werkmeister_WMDET256244 Migrate client $wgExtensionFunctions to extension JSON
 ResolvedLadsgroupT256245 Migrate Client i18n globals to extension JSON
 ResolvedNoneT256246 Migrate Client hooks to extension JSON
 ResolvedLadsgroupT256253 Stop registering some Client hooks only outside of unit tests
 ResolvedLucas_Werkmeister_WMDET256257 Migrate ClientHooks hook handlers to extension JSON
 ResolvedTarrowT256259 Migrate Client ChangesListLinesHandler hooks to extension JSON
 ResolvedLucas_Werkmeister_WMDET256260 Migrate Client SidebarHookHandlers hooks to extension JSON
 ResolvedLucas_Werkmeister_WMDET256261 Migrate Client MovePageNotice hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256262 Migrate Client InfoActionHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256263 Migrate Client ParserLimitReportPrepareHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256264 Migrate Client ParserClearStateHookHandler hook to extension JSON
 ResolvedLadsgroupT256265 Migrate Client EchoSetupHookHandlers hook to extension JSON
 ResolvedLadsgroupT256266 Migrate Client EchoNotificationsHandlers hook to extension JSON
 ResolvedLadsgroupT256267 Migrate Client DataUpdateHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256268 Migrate Client UpdateRepoHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256269 Migrate Client ChangesListSpecialPageHookHandlers hook to extension JSON
 ResolvedLadsgroupT256270 Migrate Client SqlUsageTrackerSchemaUpdater hook to extension JSON
 ResolvedLadsgroupT256271 Migrate Client DescriptionProviderHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256764 Migrate Client ParserOutputUpdateHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256247 Migrate Client job classes to extension JSON
 ResolvedItamarWMDET256248 Migrate Client $wgRecentChangesFlags to extension JSON
 ResolvedLucas_Werkmeister_WMDET256249 Migrate Client ResourceLoader modules (except Data Bridge) to extension JSON
 ResolvedLadsgroupT256250 Migrate Client Data Bridge ResourceLoader modules to extension JSON
 ResolvedItamarWMDET256251 Migrate Client special pages to extension JSON
 ResolvedLucas_Werkmeister_WMDET256252 Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point
 ResolvedLucas_Werkmeister_WMDET256756 Remove $wgWBRepoDataTypes and $wgWBClientDataTypes global variables
 ResolvedLadsgroupT257430 Copy Lib extension.json content to Client
 ResolvedLadsgroupT257431 Copy Lib extension.json content to Repo
 ResolvedLadsgroupT257432 Remove Lib extension.json
 ResolvedLadsgroupT257433 Convert Repo to use Extension Registration
 ResolvedLucas_Werkmeister_WMDET257441 Migrate Repo permissions to extension JSON file
 ResolvedLucas_Werkmeister_WMDET257442 Migrate Repo i18n globals to extension JSON file
 ResolvedLucas_Werkmeister_WMDET257443 Migrate Repo API modules to extension JSON file
 ResolvedLadsgroupT257444 Migrate Repo special pages to extension JSON file
 ResolvedNoneT257445 Migrate Repo hooks to extension JSON file
 ResolvedLadsgroupT257563 Migrate DatabaseSchemaUpdater hook handler to json
 ResolvedLadsgroupT257564 Migrate HtmlPageLinkRendererEndHookHandler to json
 ResolvedLadsgroupT257565 Migrate LabelPrefetchHookHandlers to json
 ResolvedTarrowT257566 Migrate ShowSearchHitHandler to json
 ResolvedItamarWMDET257567 Migrate OutputPageBeforeHTMLHookHandler to json
 ResolvedLadsgroupT257568 Migrate OutputPageJsConfigHookHandler to json
 ResolvedLadsgroupT257569 Migrate ArticleRevisionVisibilitySetHookHandler to json
 ResolvedItamarWMDET257570 Migrate ChangesSubscriptionSchemaUpdater to json
 ResolvedItamarWMDET257615 Migrate FederatedPropertiesSpecialPageHookHandler to json
 ResolvedLadsgroupT257446 Migrate Repo ResourceLoader modules to extension JSON file
 ResolvedLadsgroupT257447 Don’t load Repo settings in PHP entry point
 ResolvedLadsgroupT257448 Don’t define Repo content model constants in PHP entry point
 ResolvedLucas_Werkmeister_WMDET257449 Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack
 ResolvedLadsgroupT258043 Merge WikibaseView extension registeration into Repo
 ResolvedLadsgroupT257436 Deploy Repo using extension registration to Beta
 ResolvedMtDuT106104 [Task] Convert WikibaseQuality, WikibaseQualityConstraints and WikibaseQualityExternalValidation to use extension registration
 ResolvedLydia_PintscherT161716 Turn WikibaseQualityExternalValidation constants into config variables
 DeclinedLydia_PintscherT106635 Convert WikibaseQuery to use extension registration
 InvalidNoneT123026 change Wikidata build to load its included extensions via extension registration
 InvalidNoneT124054 [Task] Convert wikibase and data values libraries to use extension registration
 ResolvedReedyT124055 [Task] Convert PropertySuggester to use extension registration
 ResolvedLegoktmT168187 Convert Wikidata.org to use extension registration
 ResolvedLadsgroupT104309 [Task] Move PropertySuggester extension to gerrit
 ResolvedNoneT92520 Move Wikidata.org and WikimediaBadges extensions to gerrit
 ResolvedJanZerebeckiT102628 Request Gerrit repositories for Wikidata.org and WikimediaBadges
 ResolvedNoneT90303 Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches
 ResolvedJanZerebeckiT106433 replace inline perl in builder wd-mw-composer-merged-install with a proper script
 ResolvedKrinkleT112895 Support installing composer require-dev packages together with mediawiki/vendor
 InvalidNoneT109171 [RFC] wikibase (composer) libraries register resource loader modules during autoloader startup
 ResolvedJanZerebeckiT112572 [Task] make Wikibase work in WM CI without special config
 ResolvedAddshoreT147215 Improve version information for Wikidata software components

Event Timeline

JanZerebecki created this task.Aug 15 2015, 9:46 AM
JanZerebecki raised the priority of this task from to Needs Triage.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added a project: Wikidata.
JanZerebecki subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2015, 9:46 AM
JanZerebecki added a parent task: T95663: [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor.Aug 15 2015, 9:47 AM
JanZerebecki mentioned this in T106772: test WikidataPageBanner its integration with Wikibase.
JanZerebecki updated the task description. (Show Details)Aug 16 2015, 9:37 AM
JanZerebecki set Security to None.
JanZerebecki added a subscriber: JeroenDeDauw.
JanZerebecki mentioned this in T108457: Remove extensions/DataTypes git repo.Aug 16 2015, 9:40 AM
JanZerebecki updated the task description. (Show Details)Aug 16 2015, 9:50 AM
JanZerebecki updated the task description. (Show Details)
Ricordisamoa subscribed.Aug 16 2015, 10:27 AM
Lydia_Pintscher renamed this task from wikibase (composer) libraries register resource loader modules during autoloader startup to [RFC] wikibase (composer) libraries register resource loader modules during autoloader startup.Aug 17 2015, 3:22 PM
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.
JanZerebecki mentioned this in T110533: [Bug] The ValueView CI does not run its own QUnit tests.Aug 28 2015, 1:30 PM
daniel subscribed.Sep 10 2015, 3:26 PM

In my opinion, extensions should no *nothing* during autoload. Installing a component via composer should not activate an extension; this means that extensions should not register anything with mediawiki via the autoloader interface. This should only happen if and when the extension's entry point is loaded.

daniel triaged this task as Medium priority.EditedSep 10 2015, 3:29 PM

Setting prio to normal: this doesn't break anything for our setup. But it's a potential issue for third parties, and it's generally bad practice, compare the discussion at https://github.com/composer/composer/issues/4109

This should be relatively easy to fix.

daniel moved this task from needs discussion or investigation to ready to go on the Wikidata board.Sep 10 2015, 3:29 PM
JanZerebecki added a comment.Sep 28 2015, 2:44 PM
In T112120#1645481, @JanZerebecki wrote:

Regarding that we won't remove the ResouceLoader dependency soon: That might work in practice ok even as a component. The downside of that is that we need some custom CI glue to run the QUnit tests. That might possibly look like: add a composer depencency on data-values/value-view into an installation of Mediawiki, run composer, run qunit tests as is normally done with Mediawiki.

JanZerebecki mentioned this in T100654: [Task] use generic composer based Jenkins jobs for WikibaseJavaScriptApi CI.Sep 28 2015, 2:46 PM
JeroenDeDauw added a comment.Sep 28 2015, 10:08 PM

What exactly is the problem we are trying to solve here?

Danny_B added a project: Proposal.May 2 2016, 10:39 PM
Addshore mentioned this in T173818: [Epic] Kill the Wikidata build step.Aug 23 2017, 1:38 PM
Liuxinyu970226 subscribed.Sep 19 2017, 4:12 AM
Addshore closed this task as Invalid.Nov 15 2017, 9:09 PM
Addshore subscribed.

None of the wikibase composer libs do this anymore

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptNov 15 2017, 9:09 PM
Addshore added a parent task: T181709: Cleanup Phabricator tickets once the build is dead.Nov 30 2017, 12:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL