Page MenuHomePhabricator

Links in Flow Topic titles, are shown as links in the Echo flyout and email, for Thanks
Closed, ResolvedPublic

Description

Reproduce:

  • Contribute to a Flow topic, that has a [[link]] in the title.
  • Someone else "Thanks" you for the edit
  • The entry in the Echo Flyout, and the Echo email, will have the [[link]] as a hyperlink

ZUJWEZY.png (371×1 px, 95 KB)

XaMnmik.png (298×1 px, 24 KB)

(possibly relevant) i18n found at:

Event Timeline

Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity subscribed.
Quiddity renamed this task from Links in Flow Topic titles, are shown as links in the Echo flyout, for Thanks to Links in Flow Topic titles, are shown as links in the Echo flyout and email, for Thanks.Aug 23 2015, 5:39 PM
Quiddity updated the task description. (Show Details)
Quiddity set Security to None.

See also T59153 where it is proposed we use the edit summary parser for topic titles.

In any case, we shouldn't parameterize topic titles into a mesage that's then parsed as wikitext. We probably want to either parameterize them into a plain message, or (ugh) parse them to HTML and then inject them into an HTML message.

Catrope triaged this task as Medium priority.Aug 26 2015, 11:42 PM
Catrope added a subscriber: Legoktm.
matmarex subscribed.

This has been resolved at some point. The links don't appear in notifications now.

image.png (2×3 px, 722 KB)