Might be T43723

Some parts of the discussion in -operations earlier:

<Krenair> aude, hey, so we recently renamed a wikipedia domain and now sitelinks aren't working
<Krenair> I was wondering if that's something https://wikitech.wikimedia.org/wiki/Add_a_wiki#sites_table would take care of
<aude> Krenair: it might
<aude> site links to just that wikipedia?
<aude> or all site links?
<Krenair> only at that one
<Krenair> https://phabricator.wikimedia.org/T111822
<aude> we might try on testwikidatawiki
<aude> i think a second entry might get added for "be_tarask'
<aude> think we need to keep the old entry (and think that would happen) for existing sit elinks
<aude> we have a lot of existing entries in the wb_items_per_site table with the old 'site id'

@aude may look at this later.

running populateSitesTable.php will work, but there may be some issues with invalidating the cache. (see T111852)

I think we can make this work again, but changing the site id to be_tarask is a little more involved since we have the old site code still in the database. I think we would want two entries for be_tarask (one with the old id and one with the new id, both with current site info such as site url).

populateSitesTable doesn't handle special exceptions like this well, though.

adding site links works now, though it still has the old site id of 'be_x_oldwiki'. I need to look into how we can best add a new site id / rename it.

I've moved the priority down to 'Normal' because it sounds like this is no longer breaking production.

@aude: We still set the $lang global to be-x-old (I think this is so that it generates the correct database name). Is that related?

Any chance of this getting done? Now each and every bot or Module or script working with something related to the wiki in context of WD has to have some ridiculous workarounds because of this. Like in my CEE Spring statistics bot I have to have lines like

	if ("be-x-old.wikipedia.org".equals(wname)) {
		wname = "be-tarask.wikipedia.org";
	}

, Module:WikimediaCEETable has line

	if iw == "be_x_old" then iw = "be-tarask" end

for the same thing. This is just stupid besides all the other things it is.

Tarashkevitsa Belarusian isn't that huge of a WP. Can't you just replace all instances of the old name in the db with the new name, then force regenerate those cache pages you are afraid might be broken because of it and have it dealt with thus? If it will involve something like 20 minutes of some WD pages rendered non-perfectly this it pretty bearable temporary side-effect of the work. Well or whatever other way you might see possible. I am very afraid as to this task not to take that much time as the original task leading to this one took.

In T111822#2611819, @Base wrote:

Any chance of this getting done? Now each and every bot or Module or script working with something related to the wiki in context of WD has to have some ridiculous workarounds because of this. Like in my CEE Spring statistics bot I have to have lines like

	if ("be-x-old.wikipedia.org".equals(wname)) {
		wname = "be-tarask.wikipedia.org";
	}

, Module:WikimediaCEETable has line

	if iw == "be_x_old" then iw = "be-tarask" end

for the same thing. This is just stupid besides all the other things it is.

Tarashkevitsa Belarusian isn't that huge of a WP. Can't you just replace all instances of the old name in the db with the new name, then force regenerate those cache pages you are afraid might be broken because of it and have it dealt with thus? If it will involve something like 20 minutes of some WD pages rendered non-perfectly this it pretty bearable temporary side-effect of the work. Well or whatever other way you might see possible. I am very afraid as to this task not to take that much time as the original task leading to this one took.

T111853, isn't that?

Is it caused by https://www.wikidata.org/wiki/MediaWiki:Gadget-SiteIdToInterwiki.js ?