Maniphest T113172

With extension editors, show rendering errors inside the inspector, not the ce node
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Sep 20 2015, 11:30 AM

Tags

Referenced Files

	F2621507: pasted_file
	Sep 20 2015, 11:30 AM

Subscribers

Jdforrester-WMF

Description

If you type invalid syntax into a <math|score|hiero...> editor the error is rendered in the view node, destroying your last good rendering, and potentially drastically changing the size of the node, and therefore the position of your inspector. It would probably be nicer to detect when the response is an error, not a rendering, and dispay it in the inspector instead.

pasted_file (208×539 px, 16 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Append error container to inspector	mediawiki/extensions/Math	master	+13 -1
	Append error container to inspector	mediawiki/extensions/Score	master	+21 -0
	Add error element to MWLiveExtensionInspector	mediawiki/extensions/VisualEditor	master	+124 -1
	Pass generated content error to inspector	VisualEditor/VisualEditor	master	+10 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Tchanders	T118616 [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability
		Resolved		Tchanders	T114453 [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing
		Resolved		Tchanders	T113172 With extension editors, show rendering errors inside the inspector, not the ce node
		Resolved		Esanders	T114480 Render an error in generated content on closing the inspector

Event Timeline

Esanders created this task.Sep 20 2015, 11:30 AM

Esanders raised the priority of this task from to Needs Triage.

Esanders updated the task description. (Show Details)

Esanders added projects: VisualEditor-MediaWiki, VisualEditor.

Esanders added subscribers: Esanders, Tchanders.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2015, 11:30 AM

Krenair merged a task: T113293: Typing invalid input inside the inspector of Musical notation is giving some errors as output on the page.Sep 21 2015, 9:39 PM

Krenair added a subscriber: Ryasmeen.

Jdforrester-WMF assigned this task to Tchanders.Sep 24 2015, 5:38 PM

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Jdforrester-WMF merged a task: T113837: Gallery popup should be stable.Sep 29 2015, 7:06 PM

Jdforrester-WMF added projects: Math, MediaWiki-Gallery, WikiHiero, MediaWiki-extensions-Score.

Jdforrester-WMF added a subscriber: Juandev.

Tchanders mentioned this in T112610: The LaTeX formula inspector jumps around a lot when making mistakes and stopping typing whilst editing large formula.Sep 30 2015, 11:53 AM

Tchanders mentioned this in T114453: [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing.Oct 2 2015, 1:08 PM

Change 243599 had a related patch set uploaded (by Tchanders):
Pass generated content error to inspector

https://gerrit.wikimedia.org/r/243599

gerritbot added a project: Patch-For-Review.Oct 4 2015, 10:55 PM

Change 243600 had a related patch set uploaded (by Tchanders):
Add error element to MWLiveExtensionInspector

https://gerrit.wikimedia.org/r/243600

Change 243601 had a related patch set uploaded (by Tchanders):
Append error container to inspector

https://gerrit.wikimedia.org/r/243601

Change 243684 had a related patch set uploaded (by Tchanders):
Append error container to inspector

https://gerrit.wikimedia.org/r/243684

Change 243599 merged by jenkins-bot:
Pass generated content error to inspector

https://gerrit.wikimedia.org/r/243599

Tchanders mentioned this in rGVED6e38f99dabdb: Pass generated content error to inspector.Oct 5 2015, 6:01 PM

Change 243600 merged by jenkins-bot:
Add error element to MWLiveExtensionInspector

https://gerrit.wikimedia.org/r/243600

Tchanders mentioned this in rEVED9307fa7095f5: Add error element to MWLiveExtensionInspector.Oct 5 2015, 10:53 PM

Change 243601 merged by jenkins-bot:
Append error container to inspector

https://gerrit.wikimedia.org/r/243601

Change 243684 merged by jenkins-bot:
Append error container to inspector

https://gerrit.wikimedia.org/r/243684

Esanders mentioned this in rESCR083e5edac0ad: Append error container to inspector.Oct 5 2015, 10:59 PM

Tchanders mentioned this in rMEXT8aab92048686: Updated mediawiki/extensions Project: mediawiki/extensions/Score….Oct 5 2015, 10:59 PM

Tchanders mentioned this in rMEXTb86dff3460d9: Updated mediawiki/extensions Project: mediawiki/extensions/Math….

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 5 2015, 11:00 PM

Nice.

Tchanders mentioned this in rEMATd24748769f27: Append error container to inspector.Oct 5 2015, 11:14 PM

Jdforrester-WMF added a parent task: T114453: [Regression pre-wmf.2] Wrong LaTeX formula still renders as correct one after editing.Oct 6 2015, 12:03 AM

Jdforrester-WMF added a parent task: T118616: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability.Nov 14 2015, 12:25 AM