Page MenuHomePhabricator
Create Task
Maniphest T114664

[Bug] Show more meaningful messages on the client wiki when a relevant sitelink is changed on the repo
Closed, ResolvedPublic
Actions

Description

Observed:

  1. when the sitelink for enwiki is changed from Foo to Bar, the client wiki shows RC entries for Foo and Bar, with the original message from the repo ("Sitelinks for enwiki was changed from Foo to Bar")
  2. when the sitelink for Foo on enwiki is removed, the client wiki shows a specialized message for Foo, saying that the link was removed.
  3. when a sitelink for Bar on enwiki is added (and none existed for enwiki before), the client wiki shows a specialized message for Bar, saying that a data item was connected to the page.

Expected:

  • when the sitelink for enwiki is changed from Foo to Bar, the client wiki shows specialized messages for Foo and Bar, saying that a data item was unlinked/linked, as is done for case (2) and (3).

Details

SubjectRepoBranchLines +/-
Fix rc comments for pages directly affected by a sitelink changemediawiki/extensions/Wikibasemaster+216 -34
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Oct 5 2015, 4:22 PM
daniel assigned this task to • Jonas.
daniel raised the priority of this task from to High.
daniel updated the task description. (Show Details)
daniel added projects: MediaWiki-extensions-WikibaseClient, Wikidata.
daniel added subscribers: gerritbot, daniel, Tobi_WMDE_SW and 5 others.
daniel removed • Jonas as the assignee of this task.Oct 5 2015, 4:27 PM
daniel added a subscriber: • Jonas.
hoo subscribed.Oct 5 2015, 9:30 PM

SiteLinkCommentCreator doesn't know about which page it is currently formatting a comment for, so that it can't do this right now. In order to fix that, SiteLinkCommentCreator needs to be made aware of the page that it's formatting a comment for.

daniel added a comment.Oct 5 2015, 9:56 PM

@hoo or we could just not call SiteLinkCommentCreator if the affected page isn't the connected page. ChangeHandler::getEditComment() should have the necessary knowledge.

hoo added a comment.Oct 6 2015, 7:55 AM
In T114664#1703768, @daniel wrote:

@hoo or we could just not call SiteLinkCommentCreator if the affected page isn't the connected page. ChangeHandler::getEditComment() should have the necessary knowledge.

But we have to call SiteLinkCommentCreator once for the now unlinked page and once for the newly linked page as far as I see.

thiemowmde mentioned this in T112649: [Task] Test: Using repo edit summaries on the client.Oct 6 2015, 1:58 PM
daniel added a project: Wikidata-Sprint-2015-09-29.Oct 6 2015, 3:01 PM
This comment was removed by daniel.
daniel removed a project: Wikidata-Sprint-2015-09-29.Oct 6 2015, 3:04 PM
daniel set Security to None.
daniel added a comment.Oct 7 2015, 10:16 AM

@hoo you are right, I was confused about what the issue is here.

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-10-13.Oct 12 2015, 1:18 PM
Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2015-10-13 board.Oct 13 2015, 1:24 PM
daniel added a parent task: T108688: [Story] meaningful edit summaries on the client.Oct 14 2015, 10:15 AM
gerritbot added a comment.Oct 14 2015, 10:20 AM

Change 246190 had a related patch set uploaded (by Hoo man):
Fix rc comments for pages directly affected by a sitelink change

https://gerrit.wikimedia.org/r/246190

gerritbot added a project: Patch-For-Review.Oct 14 2015, 10:20 AM
hoo claimed this task.Oct 14 2015, 10:20 AM
hoo moved this task from Backlog to Review on the Wikidata-Sprint-2015-10-13 board.
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Oct 14 2015, 12:27 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-11-03.Nov 3 2015, 12:41 PM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2015-11-03 board.
gerritbot added a comment.Nov 5 2015, 9:05 PM

Change 246190 merged by jenkins-bot:
Fix rc comments for pages directly affected by a sitelink change

https://gerrit.wikimedia.org/r/246190

hoo closed this task as Resolved.Nov 5 2015, 9:07 PM
hoo removed a project: Patch-For-Review.
hoo moved this task from Review to Done on the Wikidata-Sprint-2015-11-03 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL