Page MenuHomePhabricator
Create Task
Maniphest T124786

[Task] Widgets should delegate isInitialValue calls as far as possible
Closed, InvalidPublic
Actions

Description

In the terms view, the API requests to save changed values are done in the labelview, descriptionview and aliasesview widgets. These, but only these three widgets should have a full implementation of isInitialValue that possibly creates Wikibase-DataModel-JavaScript objects and compares them. All other, higher level widgets should delegate an isInitialValue call to their sub-widgets.

This not only avoids duplicate code. It also avoids creating Wikibase-DataModel-JavaScript objects.

Same for the statements and sitelinks views.

Details

SubjectRepoBranchLines +/-
Forward snaklistview.isInitialValue to snakviewmediawiki/extensions/Wikibasemaster+11 -27
Clean up usage of self and private properties in snaklistviewmediawiki/extensions/Wikibasemaster+15 -16
Simplify sitelinklistview.isInitialValuemediawiki/extensions/Wikibasemaster+19 -41
Simplify entitytermsforlanguagelistview.isInitialValuemediawiki/extensions/Wikibasemaster+13 -28
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedthiemowmdeT92759 [Story] allow editing of more languages in the in other languages box than the ones defined via babel boxes
ResolvedNoneT124787 [Task] Remove all unused value() methods from view widgets
ResolvedNoneT127067 [Story] Reduce initialisation time of SiteLinks
InvalidthiemowmdeT124786 [Task] Widgets should delegate isInitialValue calls as far as possible
· · ·

Event Timeline

thiemowmde created this task.Jan 26 2016, 3:42 PM
thiemowmde claimed this task.
thiemowmde raised the priority of this task from to Medium.
thiemowmde updated the task description. (Show Details)
thiemowmde added projects: Wikidata, MediaWiki-extensions-WikibaseView, Wikibase-DataModel-JavaScript, Performance Issue.
thiemowmde added subscribers: thiemowmde, • Jonas, • adrianheine, Lydia_Pintscher.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2016, 3:42 PM
thiemowmde mentioned this in T124787: [Task] Remove all unused value() methods from view widgets.Jan 26 2016, 3:43 PM
thiemowmde added a parent task: T124787: [Task] Remove all unused value() methods from view widgets.
thiemowmde added a parent task: T92759: [Story] allow editing of more languages in the in other languages box than the ones defined via babel boxes.
thiemowmde added a comment.EditedJan 27 2016, 9:28 AM

Candidates in the terms section:

  • label-, description- and aliasesview are all fine. All three handle edits itself and propagate them to a changer. Both isInitialValue and value (the later is tracked in T124787) are required for that. The only issue is that the code of the three widgets looks different, but shouldn't.
  • entitytermsforlanguageview wraps a label-, description- and aliasesview. It's isInitialValue forwards nicely.
  • entitytermsforlanguagelistview contains a list of entitytermsforlanguageview widgets. It does not forward isInitialValue but instead does a complicated comparison. This is the main issue why I created this ticket.
  • entitytermsview wraps a single entitytermsforlanguagelistview and forwards nicely.

Statements section:

  • statementview forwards to RankSelector.isInitialValue as well as snakview.isInitialValue, but compares qualifiers and references manually.
  • snaklistview contains a list of snakview widgets, but does not forward.
  • snakview is complicated. Does this count as a "leaf object"? Why is the code so complicated?
  • RankSelector is trivial and fine.
  • referenceview is also complicated and needs more investigation.

Sitelinks section:

  • sitelinkgroupview wraps a single sitelinklistview and forwards nicely.
  • sitelinklistview contains a list of sitelinkview widgets and should forward.
  • sitelinkview is a "leaf object" and fine.
gerritbot subscribed.Jan 27 2016, 1:12 PM

Change 266710 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Simplify entitytermsforlanguagelistview.isInitialValue

https://gerrit.wikimedia.org/r/266710

gerritbot added a project: Patch-For-Review.Jan 27 2016, 1:12 PM
gerritbot added a comment.Jan 27 2016, 2:11 PM

Change 266727 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Simplify sitelinklistview.isInitialValue

https://gerrit.wikimedia.org/r/266727

gerritbot added a comment.Jan 27 2016, 3:38 PM

Change 266710 merged by jenkins-bot:
Simplify entitytermsforlanguagelistview.isInitialValue

https://gerrit.wikimedia.org/r/266710

thiemowmde added a parent task: T127067: [Story] Reduce initialisation time of SiteLinks.Feb 25 2016, 4:50 PM
• adrianheine mentioned this in T127067: [Story] Reduce initialisation time of SiteLinks.Feb 26 2016, 1:29 PM
gerritbot added a comment.Mar 1 2016, 12:17 PM

Change 266727 merged by jenkins-bot:
Simplify sitelinklistview.isInitialValue

https://gerrit.wikimedia.org/r/266727

gerritbot added a comment.May 3 2016, 3:46 PM

Change 286668 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Clean up usage of self and private properties in snaklistview

https://gerrit.wikimedia.org/r/286668

gerritbot added a comment.May 3 2016, 3:52 PM

Change 286669 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Forward snaklistview.isInitialValue to snakview

https://gerrit.wikimedia.org/r/286669

gerritbot added a comment.May 4 2016, 10:20 AM

Change 286668 merged by jenkins-bot:
Clean up usage of self and private properties in snaklistview

https://gerrit.wikimedia.org/r/286668

gerritbot added a comment.Sep 17 2016, 2:11 PM

Change 286669 abandoned by Thiemo Mättig (WMDE):
Forward snaklistview.isInitialValue to snakview

Reason:
Obsolete now, thanks to Adrian. :-)

https://gerrit.wikimedia.org/r/286669

Lydia_Pintscher added a comment.Sep 29 2016, 7:50 AM

Is there still something to do here? If yes it'd be good to clarify what.

thiemowmde closed this task as Invalid.Oct 5 2016, 12:42 PM

isInitialValue does not exist any more.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL