Page MenuHomePhabricator
Create Task
Maniphest T127067

[Story] Reduce initialisation time of SiteLinks
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
• Jonas
Feb 16 2016, 2:14 PM
Tags
Referenced Files
F3426661: pasted_file
Feb 25 2016, 11:15 AM
F3426644: pasted_file
Feb 25 2016, 11:10 AM
F3405816: Screenshot from 2016-02-23 12-27-51.png
Feb 23 2016, 11:30 AM
F3405818: Screenshot from 2016-02-23 12-28-32.png
Feb 23 2016, 11:30 AM
F3405817: Screenshot from 2016-02-23 12-28-11.png
Feb 23 2016, 11:30 AM
F3404156: Screenshot from 2016-02-23 10-51-53.png
Feb 23 2016, 9:54 AM
F3404155: Screenshot from 2016-02-23 10-51-18.png
Feb 23 2016, 9:54 AM
Subscribers
• adrianheine
Aklapper
gerritbot
Incabell
• Jonas
Lydia_Pintscher
thiemowmde

Description

We would like to reduce initialization time of SiteLinks and it's sub widgets as it is a main cause of the total render time according to T125502: [Task] Investigate time spent for initialization of individual widgets

Details

SubjectRepoBranchLines +/-
Use binary search in sitelinkview._shortenPageNamemediawiki/extensions/Wikibasemaster+36 -10
Never shorten page titles in sitelinks below 15 charactersmediawiki/extensions/Wikibasemaster+10 -8
Make long site links wrap nicelymediawiki/extensions/Wikibasemaster+42 -51
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jonas created this task.Feb 16 2016, 2:14 PM
• Jonas raised the priority of this task from to High.
• Jonas updated the task description. (Show Details)
• Jonas added projects: Wikidata, Performance Issue, Story, Wikidata-Sprint-2016-02-16.
• Jonas added subscribers: • adrianheine, thiemowmde, • Jonas.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2016, 2:14 PM
• Jonas moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-02-16 board.Feb 16 2016, 2:14 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Feb 18 2016, 12:04 PM
• Jonas created subtask T127305: [Task] Change ellipsis from JS to CSS.Feb 18 2016, 12:50 PM
thiemowmde added a comment.Feb 19 2016, 10:27 AM

We found that the _shortenPageName function in sitelinkview.js is one of the most time consuming details on the page now. For testing, here is one of the longest page titles on the live site: https://www.wikidata.org/wiki/Q229568

gerritbot subscribed.Feb 19 2016, 10:57 AM

Change 271753 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Never shorten page titles in sitelinks below 15 characters

https://gerrit.wikimedia.org/r/271753

gerritbot added a project: Patch-For-Review.Feb 19 2016, 10:57 AM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2016-02-16 board.Feb 22 2016, 9:18 AM
gerritbot added a comment.Feb 22 2016, 3:40 PM

Change 272475 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Use binary search in sitelinkview._shortenPageName

https://gerrit.wikimedia.org/r/272475

• adrianheine added a subscriber: Lydia_Pintscher.Feb 23 2016, 8:29 AM

@Lydia_Pintscher We should talk about this today, unless you already know what you want.

gerritbot added a comment.Feb 23 2016, 8:30 AM

Change 272625 had a related patch set uploaded (by Adrian Heine):
Make long site links wrap nicely

https://gerrit.wikimedia.org/r/272625

• adrianheine added a comment.Feb 23 2016, 9:54 AM

Two versions of site id positioning:

Screenshot from 2016-02-23 10-51-18.png (1×1 px, 236 KB)

Screenshot from 2016-02-23 10-51-53.png (1×1 px, 236 KB)

• adrianheine added a subscriber: Incabell.Feb 23 2016, 11:00 AM

@Incabell says vertical-align: middle.

• Jonas moved this task from Review to Backlog on the Wikidata-Sprint-2016-02-16 board.Feb 23 2016, 11:11 AM
• Jonas created subtask T127816: [Task] Render SiteLink count server side.Feb 23 2016, 11:13 AM
• adrianheine added a comment.Feb 23 2016, 11:30 AM

Long words are an issue. I see three straight-forward workarounds. @Lydia_Pintscher @Incabell

Limit leakage to length of site id:

Screenshot from 2016-02-23 12-27-51.png (1×1 px, 239 KB)

Break words wherever you want to:

Screenshot from 2016-02-23 12-28-11.png (1×1 px, 238 KB)

Add scrollbar:

Screenshot from 2016-02-23 12-28-32.png (1×1 px, 235 KB)

Lydia_Pintscher added a comment.Feb 23 2016, 11:40 AM

Option one and three are clearnly no-gos. Let's go with 2.

• adrianheine added a comment.Feb 23 2016, 12:06 PM

Current patch revision does good things: In chromium, it breaks on whitespace where possible, long words just randomly. In Firefox, it adds hyphens. Reviewers, please check in your browsers.

gerritbot added a comment.Feb 23 2016, 12:06 PM

Change 272625 had a related patch set uploaded (by Adrian Heine):
Make long site links wrap nicely

https://gerrit.wikimedia.org/r/272625

hoo closed subtask T127816: [Task] Render SiteLink count server side as Resolved.Feb 23 2016, 4:12 PM
Incabell added a comment.Feb 23 2016, 4:23 PM

I agree with @Lydia_Pintscher

• Jonas added a comment.EditedFeb 25 2016, 11:10 AM

@thiemowmde
(Chrome)

pasted_file (363×346 px, 36 KB)

• Jonas added a comment.EditedFeb 25 2016, 11:15 AM

(Firefox)

pasted_file (120×468 px, 14 KB)

thiemowmde added a subtask: T124786: [Task] Widgets should delegate isInitialValue calls as far as possible.Feb 25 2016, 4:50 PM
• Jonas closed subtask T127305: [Task] Change ellipsis from JS to CSS as Resolved.Feb 26 2016, 11:52 AM
• adrianheine changed the status of subtask T127305: [Task] Change ellipsis from JS to CSS from Resolved to Declined.Feb 26 2016, 12:13 PM
• adrianheine added a comment.Feb 26 2016, 1:29 PM

@thiemowmde Do you consider this done or should we wait for T124786?

thiemowmde added a comment.Feb 26 2016, 1:46 PM

I linked T124786 so it doesn't get lost so easily, but I agree we can and should close this here for now.

gerritbot added a comment.Feb 26 2016, 5:35 PM

Change 272625 merged by jenkins-bot:
Make long site links wrap nicely

https://gerrit.wikimedia.org/r/272625

gerritbot added a comment.Feb 29 2016, 1:53 PM

Change 271753 abandoned by Thiemo Mättig (WMDE):
Never shorten page titles in sitelinks below 15 characters

Reason:
I4a26042 is merged, code does not exist any more.

https://gerrit.wikimedia.org/r/271753

gerritbot added a comment.Feb 29 2016, 1:53 PM

Change 272475 abandoned by Thiemo Mättig (WMDE):
Use binary search in sitelinkview._shortenPageName

Reason:
I4a26042 is merged, code does not exist any more.

https://gerrit.wikimedia.org/r/272475

• adrianheine closed this task as Resolved.Mar 1 2016, 8:58 AM
• adrianheine moved this task from Backlog to Done on the Wikidata-Sprint-2016-02-16 board.
thiemowmde closed subtask T124786: [Task] Widgets should delegate isInitialValue calls as far as possible as Invalid.Oct 5 2016, 12:42 PM
Krinkle changed the status of subtask T127305: [Task] Change ellipsis from JS to CSS from Declined to Resolved.Mar 17 2017, 10:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL