Page MenuHomePhabricator
Create Task
Maniphest T125896

Feature flagged lazy loaded references
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  • When the flag is enabled and I view a page fresh from cache the list of references is not there and instead I see a temporary measure "List of references currently unavailable". We'll polish the non-JS use case later after we have conclusive results of the impacts of thsi change (see T125897)
  • Fetch references from the API (T123290)
  • The ReferenceDrawer should load reference data from the blob when the HTML is not present
  • When a user has no JavaScript, the references will be hidden and not function. This will be addressed later in T125897

Developer notes:

  • Feel free to use the MobileFormatter for this one.

Details

SubjectRepoBranchLines +/-
Allow lazy loading of references (feature flagged)mediawiki/extensions/MobileFrontendmaster+265 -50
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 Resolveddr0ptp4ktT114542 Next Generation Content Loading and Routing, in Practice
 ResolvedNoneT101091 References in the section preview
 OpenNoneT124840 Section edit preview doesn't let you preview references defined outside the section being previewed
 Duplicate• JhernandezT104432 [EPIC]: Improve mobile site performance
 Duplicatedr0ptp4ktT120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
 DeclinedNoneT125920 [EPIC] Future exciting reading web performance endeavours
 ResolvedJdlrobsonT113066 [GOAL] Make Wikipedia more accessible to 2G connections
 DeclinedNoneT123328 [GOAL] Lazy load references in mobile skin
 ResolvedJdlrobsonT125896 Feature flagged lazy loaded references
 ResolvedphuedxT123290 Should be possible to access references and notes for a given page via API
 ResolvedphuedxT125134 Spike: Can we store a JSON blob of references data in ParserOutput
 DeclinedNoneT126802 What is impact of storing references
 DeclinedCenariumT125329 Save references in page_props and cache
 DeclinedNoneT127263 References stored in page props are not parsed

Event Timeline

Jdlrobson created this task.Feb 4 2016, 9:41 PM
Jdlrobson raised the priority of this task from to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Reading-Web-Sprint-66-Harry is Tired.
Jdlrobson added subscribers: aaron, gerritbot, Aklapper and 21 others.
Jdlrobson updated the task description. (Show Details)Feb 4 2016, 9:46 PM
Jdlrobson set Security to None.
phuedx added a subscriber: • Nirzar.Feb 8 2016, 9:19 AM

When the flag is enabled and I view a page fresh from cache the list of references is not there and instead I see a link to "See references for this page" that points to a Special:References page.

@Nirzar: If the user's UA is RL-capable, then should this link be hidden once the references module has been loaded and initialised?

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-66-Harry is Tired board.Feb 8 2016, 5:41 PM
Jdlrobson updated the task description. (Show Details)
phuedx updated the task description. (Show Details)Feb 8 2016, 5:42 PM
phuedx updated the task description. (Show Details)Feb 8 2016, 5:44 PM
phuedx updated the task description. (Show Details)Feb 8 2016, 5:47 PM
Jdlrobson added a comment.Feb 8 2016, 5:48 PM
  • Design input needed - we're gonna hit the API now so let's work out what should be shown in interim.
bd808 edited a custom field.Feb 8 2016, 5:48 PM
Jdlrobson updated the task description. (Show Details)Feb 8 2016, 7:23 PM
• bmansurov added a comment.Feb 15 2016, 5:50 PM

So the tasks linked in the description are blockers? If so, some of those blockers have blockers that are in the sprint 67. We should sort those out first.

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-66-Harry is Tired board.Feb 17 2016, 12:33 AM
Jdlrobson claimed this task.Feb 17 2016, 12:44 AM
gerritbot added a comment.Feb 17 2016, 10:51 PM

Change 271434 had a related patch set uploaded (by Jdlrobson):
WIP: Allow lazy loading of references

https://gerrit.wikimedia.org/r/271434

gerritbot added a project: Patch-For-Review.Feb 17 2016, 10:51 PM
Jdlrobson moved this task from Doing to -1 (Needs More Work) on the Reading-Web-Sprint-66-Harry is Tired board.Feb 18 2016, 12:52 AM
Jdlrobson added a subtask: T127263: References stored in page props are not parsed.
Jdlrobson added a subtask: T123290: Should be possible to access references and notes for a given page via API.

Uncovered a big issue in this work that is now blocking me - T127263.

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-66-Harry is Tired board.Feb 18 2016, 10:27 PM
• jhobs moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-66-Harry is Tired board.Feb 23 2016, 2:47 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-66-Harry is Tired board.Feb 23 2016, 11:20 PM
• jhobs moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-66-Harry is Tired board.Feb 25 2016, 2:25 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-66-Harry is Tired board.Feb 26 2016, 5:20 PM
Jdlrobson closed subtask T123290: Should be possible to access references and notes for a given page via API as Resolved.Feb 27 2016, 1:18 AM
Jdlrobson edited projects, added Reading-Web-Sprint-67-If, Then, Else...?; removed Reading-Web-Sprint-66-Harry is Tired.Feb 29 2016, 5:07 PM
bd808 moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-67-If, Then, Else...? board.Feb 29 2016, 5:38 PM
• jhobs moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-67-If, Then, Else...? board.Feb 29 2016, 6:59 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 1 2016, 11:31 PM
• Jhernandez moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 4 2016, 12:32 PM
aaron unsubscribed.Mar 4 2016, 7:45 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 4 2016, 10:10 PM
• Jhernandez moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 7 2016, 11:12 AM
gerritbot added a comment.Mar 7 2016, 11:26 AM

Change 271434 merged by jenkins-bot:
Allow lazy loading of references (feature flagged)

https://gerrit.wikimedia.org/r/271434

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Mar 7 2016, 12:00 PM
Jdlrobson removed a project: Patch-For-Review.Mar 9 2016, 12:04 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson closed this task as Resolved.Mar 9 2016, 12:07 AM

There are questions being raised by the approach and we may need to alter the API we use in T125329
Using the existing API however this is done.
The last 2 bullet points cannot be done until we've resolved this discussion.
I've opened T129182 and put it in Sprint J for consideration.

I'm thus calling this card done. We can continue discussions on other bugs.

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 14 2016, 4:02 PM
Jdlrobson closed subtask T127263: References stored in page props are not parsed as Declined.Jul 17 2019, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL