Page MenuHomePhabricator
Create Task
Maniphest T129368

Usages of unittest.expectedFailure or unittest.skip should be solved (goal)
Open, LowPublic
Actions

Description

There are a lot of unittest.expectedFailure decorators. There should be a good reason to keep it. Otherwise the problem should be solved.

I found some inside

  • aspects.py
  • api-tests.py
  • cosmetic_changes_tests.py
  • imagecopy_tests.py (archived)
  • isbn_tests.py (archived)
  • page_tests.py
  • pagegenerators_tests.py (T14810)
  • pwb_tests.py
  • reflinks_tests.py
  • script_tests.py
  • site_detect_tests.py
  • site_generators_tests
  • site_tests.py
  • template_bot_tests.py
  • tests_tests.py
  • textlib_tests.py <-- some tests look wrong to me
  • time_tests.py
  • tools_ip_tests.py
  • tools_tests.py
  • upload_tests.py
  • utils.py

bold means bug tasks are created and marked as blocker

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT152961 Improve tests suite
 OpenNoneT129368 Usages of unittest.expectedFailure or unittest.skip should be solved (goal)
 Resolvedmatej_suchanekT130917 TestLiveCosmeticChanges.test_cleanUpLinks_pipes_fail erroneously doesn't fail unittest
 OpenNoneT130918 TestLiveCosmeticChanges.test_cleanUpLinks erroneously doesn't fail unittest
 DeclinedNoneT130919 page_tests.TestPageRepr.test_ASCII_compatible erroneously doesn't fail unittest
 ResolvedXqtT130921 Enable page_tests.TestPageProtect.test_protect
 ResolvedDalbaT78522 pywikibot: Site.page_restrictions() is cached but not updated/cleared after calling Site.protect()
 Resolvedmatej_suchanekT130925 remove unittest.expectedFailure from HtmlEntity.test_recursive_entities
 ResolvedXqtT130928 Throw an error for incorrect logtypes for pagegenerators.handleArgs()
 ResolvedMpaaT130985 Solve usage of expectedFailure for tools_tests.py
 ResolvedXqtT178528 Solve usage of expected_failure_if for tools_tests.py
 ResolvedXqtT132663 Improve tests for an expected failure in reflinks_tests
 OpenNoneT133276 textlib.does_text_contain_section fails for encoded section title
 OpenNoneT133288 Fix test for TestUpload and remove expectedFailure decorator
 OpenNoneT112543 Allow continuing the partially-complete upload in stashed mode after warning
 ResolvedXqtT134676 template_bot_tests fails for unknown reason
 DeclinedNoneT110640 weblib.getWebCitationURL broken, causes testWebCiteOlder to fail
 ResolvedAbdealiJKT135594 pytest doesnt respect __test__ = False on script_tests metaclass created methods
 ResolvedXqtT145319 Re-enable test_allpages_langlinks_enabled without allowed_failure decorator
 OpenNoneT145325 PropertyGenerator fails for two or many continuation limited
 ResolvedXqtT174870 isbn.py may fail in treat_page_and_item() with missing attribute claims for an ItemPage
 ResolvedMpaaT181697 test_page_gen_redlink is failing with APIMWException
 ResolvedDalbaT196876 tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed
 ResolvedXqtT223030 Remove allowed_failure and allowed_failure_if from tests/utils.py
 ResolvedXqtT209798 Enable unexpected successes?
 ResolvedXqtT233484 Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run
ResolvedXqtT233487 creating a site from url raises SiteDefinitionError for closed wikis
 OpenNoneT194138 generate_family_file test fails on Travis and AppVeyor
 ResolvedXqtT212998 generate_family_files_tests.py is failing in TestGenerateFamilyFiles.test_attributes_after_run
 ResolvedXqtT251057 site_detect_tests.APIHiddenTestCase.test_ecoreality unexpectedly passes test
 ResolvedJJMC89T272234 TestAlldeletedrevisionsAsUser tests for mysite.alldeletedrevisions are failing
 ResolvedNoneT276038 cirrussearch-backend-error at beta cluster
 ResolvedEBernhardsonT275975 Search broken on beta cluster wikis
 ResolvedXqtT282962 ui_tests are failing on Travis
 ResolvedBUG REPORTXqtT254435 using pwb.py wrapper with global args before the script adds the script name to the scripts args list
 ResolvedBUG REPORTXqtT309442 test_other_wiki_prefix of link_tests.TestForeignInterwikiLinks fails
 ResolvedBUG REPORTXqtT335635 Solve expectedFailure for site_generators_tests
 ResolvedXqtT352482 APIError: Petscan: No result for source categories
 ResolvedBUG REPORTZacheT355927 file_tests.TestMediaInfoReadonlyEditing: fails on NoUsernameError
 OpenXqtT356009 page_tests.TestPageObject.testLinks sometimes fails due to missing namespace
 OpenBUG REPORTNoneT356013 wrong url redirection for wikimediafoundation.org api
 ResolvedXqtT358986 AutoFamily cannot be created for infogalactic.com wiki due to outdated certificate
 ResolvedXqtT359069 test_deprecated_function_docstring test of tools_deprecate_tests.DeprecatorTestCase fails with Python 3.13
 OpenNoneT362384 pagegenerators_tests fails on wowwiki:uk
 ResolvedBUG REPORTXqtT363101 TestWikibaseMakeClaim.test_musical_notation_edit fails
 StalledBUG REPORTNoneT325860 Unable to submit any pywikibot.WbTime with hour/minute/second even if precision is day or lower
 OpenNoneT57755 Allow time values more precise than day on Wikidata

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Xqt added a subtask: T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods.May 18 2016, 1:39 PM
jayvdb mentioned this in T135795: CI expected failures and skips.May 20 2016, 3:11 AM
Xqt closed subtask T134676: template_bot_tests fails for unknown reason as Resolved.May 27 2016, 9:19 AM
Xqt closed subtask T132663: Improve tests for an expected failure in reflinks_tests as Resolved.Aug 9 2016, 6:52 PM
AbdealiJK closed subtask T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods as Resolved.Sep 4 2016, 6:23 AM
Xqt renamed this task from Usages of unittest.expectedFailure should be solved to Usages of unittest.expectedFailure and allowed_failure should be solved.Sep 11 2016, 6:58 AM
Xqt updated the task description. (Show Details)
Xqt added a subtask: T145319: Re-enable test_allpages_langlinks_enabled without allowed_failure decorator.Sep 11 2016, 7:03 AM
Xqt added a subtask: T145325: PropertyGenerator fails for two or many continuation limited.Sep 11 2016, 8:14 AM
Xqt updated the task description. (Show Details)
Xqt closed subtask T145319: Re-enable test_allpages_langlinks_enabled without allowed_failure decorator as Resolved.Sep 11 2016, 4:40 PM
Xqt added a parent task: T151145: Make Travis (and Appveyor) pass again.Nov 24 2016, 12:44 PM
Magul closed subtask T130928: Throw an error for incorrect logtypes for pagegenerators.handleArgs() as Resolved.Nov 29 2016, 6:07 PM
Magul edited parent tasks, added: T152961: Improve tests suite; removed: T151145: Make Travis (and Appveyor) pass again.Dec 12 2016, 2:38 PM
matej_suchanek closed subtask T130917: TestLiveCosmeticChanges.test_cleanUpLinks_pipes_fail erroneously doesn't fail unittest as Resolved.Feb 12 2017, 5:49 PM
Xqt closed subtask T130925: remove unittest.expectedFailure from HtmlEntity.test_recursive_entities as Resolved.Feb 13 2017, 3:10 PM
Xqt added a subtask: T174870: isbn.py may fail in treat_page_and_item() with missing attribute claims for an ItemPage.Sep 3 2017, 7:31 PM
Xqt added a subtask: T178528: Solve usage of expected_failure_if for tools_tests.py.Oct 18 2017, 7:31 PM
Xqt closed subtask T178528: Solve usage of expected_failure_if for tools_tests.py as Resolved.Oct 19 2017, 5:14 PM
Xqt added a subtask: T181697: test_page_gen_redlink is failing with APIMWException.Dec 1 2017, 5:04 AM
Dalba closed subtask T181697: test_page_gen_redlink is failing with APIMWException as Resolved.Dec 1 2017, 9:27 PM
Xqt added a subtask: T194138: generate_family_file test fails on Travis and AppVeyor.May 10 2018, 1:33 PM
Dvorapa subscribed.May 10 2018, 7:52 PM
Dvorapa added a parent task: T195826: Cleanup test warnings (goal).May 29 2018, 11:16 AM
Dvorapa renamed this task from Usages of unittest.expectedFailure and allowed_failure should be solved to Usages of unittest.expectedFailure and allowed_failure should be solved (goal).May 29 2018, 11:19 AM
Dvorapa removed a parent task: T152961: Improve tests suite.May 29 2018, 12:10 PM
Dalba added a subtask: T196876: tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed.Jun 11 2018, 9:47 AM
Xqt closed subtask T196876: tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed as Resolved.Jun 12 2018, 9:39 AM
• Vvjjkkii reopened subtask T196876: tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed as Open.Jul 1 2018, 1:05 AM
CommunityTechBot closed subtask T196876: tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed as Resolved.Jul 2 2018, 8:27 AM
Xqt removed a subtask: T178528: Solve usage of expected_failure_if for tools_tests.py.Oct 3 2018, 9:06 AM
Xqt added a subtask: T223030: Remove allowed_failure and allowed_failure_if from tests/utils.py.May 12 2019, 8:16 AM
Xqt mentioned this in T223030: Remove allowed_failure and allowed_failure_if from tests/utils.py.May 13 2019, 4:55 AM
Xqt added a subtask: T209798: Enable unexpected successes?.Sep 21 2019, 4:42 PM
Xqt added a subtask: T233484: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run .Sep 21 2019, 4:54 PM
Xqt closed subtask T110640: weblib.getWebCitationURL broken, causes testWebCiteOlder to fail as Declined.Jan 11 2020, 12:18 PM
Xqt closed subtask T209798: Enable unexpected successes? as Resolved.Jan 19 2020, 2:20 PM
Xqt closed subtask T174870: isbn.py may fail in treat_page_and_item() with missing attribute claims for an ItemPage as Resolved.Jan 20 2020, 3:33 PM
Xqt updated the task description. (Show Details)Jan 22 2020, 8:58 AM
Xqt closed subtask T223030: Remove allowed_failure and allowed_failure_if from tests/utils.py as Resolved.Jan 22 2020, 12:48 PM
Xqt renamed this task from Usages of unittest.expectedFailure and allowed_failure should be solved (goal) to Usages of unittest.expectedFailure should be solved (goal).Jan 22 2020, 12:53 PM
Xqt closed subtask T233484: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run as Resolved.Mar 4 2020, 4:12 PM
Xqt added a subtask: T251057: site_detect_tests.APIHiddenTestCase.test_ecoreality unexpectedly passes test.Apr 26 2020, 10:08 AM
Dvorapa removed a subtask: T251057: site_detect_tests.APIHiddenTestCase.test_ecoreality unexpectedly passes test.Apr 26 2020, 11:23 AM
Xqt closed subtask T130919: page_tests.TestPageRepr.test_ASCII_compatible erroneously doesn't fail unittest as Declined.Jun 30 2020, 4:55 PM
Xqt updated the task description. (Show Details)Jul 1 2020, 8:16 AM
Xqt added a subtask: T251057: site_detect_tests.APIHiddenTestCase.test_ecoreality unexpectedly passes test.Jul 10 2020, 4:21 PM
Xqt updated the task description. (Show Details)
Xqt closed subtask T251057: site_detect_tests.APIHiddenTestCase.test_ecoreality unexpectedly passes test as Resolved.Sep 28 2020, 10:22 AM
Xqt added a subtask: T272234: TestAlldeletedrevisionsAsUser tests for mysite.alldeletedrevisions are failing.Jan 17 2021, 8:10 AM
Xqt closed subtask T272234: TestAlldeletedrevisionsAsUser tests for mysite.alldeletedrevisions are failing as Resolved.Jan 17 2021, 9:42 AM
Xqt added a subtask: T276038: cirrussearch-backend-error at beta cluster.Mar 2 2021, 3:52 PM
Xqt updated the task description. (Show Details)Mar 2 2021, 3:56 PM
Xqt updated the task description. (Show Details)
Xqt updated the task description. (Show Details)Mar 2 2021, 4:11 PM
Xqt closed subtask T276038: cirrussearch-backend-error at beta cluster as Resolved.Mar 3 2021, 8:35 AM
Xqt updated the task description. (Show Details)Mar 3 2021, 8:51 AM
Xqt updated the task description. (Show Details)
Xqt added a subtask: T282962: ui_tests are failing on Travis.May 17 2021, 4:29 PM
Xqt updated the task description. (Show Details)Oct 18 2021, 2:01 PM
Xqt added a subtask: T254435: using pwb.py wrapper with global args before the script adds the script name to the scripts args list.Nov 27 2021, 5:04 PM
Xqt updated the task description. (Show Details)
Xqt updated the task description. (Show Details)
Xqt closed subtask T254435: using pwb.py wrapper with global args before the script adds the script name to the scripts args list as Resolved.Nov 28 2021, 11:27 AM
Xqt updated the task description. (Show Details)
Xqt closed subtask T282962: ui_tests are failing on Travis as Resolved.Dec 8 2021, 11:05 AM
Xqt added a subtask: T309442: test_other_wiki_prefix of link_tests.TestForeignInterwikiLinks fails.May 28 2022, 4:37 PM
Xqt closed subtask T309442: test_other_wiki_prefix of link_tests.TestForeignInterwikiLinks fails as Resolved.May 29 2022, 8:38 AM
Xqt closed subtask T194138: generate_family_file test fails on Travis and AppVeyor as Resolved.Apr 18 2023, 11:51 PM
Xqt updated the task description. (Show Details)Apr 21 2023, 12:16 PM
Xqt updated the task description. (Show Details)Apr 30 2023, 7:56 AM
Xqt added a subtask: T335635: Solve expectedFailure for site_generators_tests.Apr 30 2023, 9:18 AM
Xqt updated the task description. (Show Details)
Xqt closed subtask T335635: Solve expectedFailure for site_generators_tests as Resolved.Apr 30 2023, 9:53 AM
Xqt removed a parent task: T195826: Cleanup test warnings (goal).Jul 6 2023, 8:21 AM
Xqt added a parent task: T152961: Improve tests suite.
Xqt updated the task description. (Show Details)Jul 15 2023, 4:19 PM
Xqt reopened subtask T194138: generate_family_file test fails on Travis and AppVeyor as Open.Aug 18 2023, 11:14 AM
Xqt added a subtask: T352482: APIError: Petscan: No result for source categories.Dec 2 2023, 1:01 PM
Xqt closed subtask T352482: APIError: Petscan: No result for source categories as Resolved.Jan 5 2024, 11:42 AM
Xqt reopened subtask T352482: APIError: Petscan: No result for source categories as Open.Jan 5 2024, 12:13 PM
Xqt added a subtask: T355927: file_tests.TestMediaInfoReadonlyEditing: fails on NoUsernameError.Jan 27 2024, 5:05 PM
Xqt added a subtask: T356009: page_tests.TestPageObject.testLinks sometimes fails due to missing namespace.Jan 28 2024, 12:40 PM
Xqt closed subtask T352482: APIError: Petscan: No result for source categories as Resolved.Jan 28 2024, 1:17 PM
Xqt closed subtask T355927: file_tests.TestMediaInfoReadonlyEditing: fails on NoUsernameError as Resolved.Mar 3 2024, 7:23 AM
Xqt added a subtask: T358986: AutoFamily cannot be created for infogalactic.com wiki due to outdated certificate.Mar 3 2024, 4:21 PM
Xqt added a subtask: T359069: test_deprecated_function_docstring test of tools_deprecate_tests.DeprecatorTestCase fails with Python 3.13.Mar 4 2024, 5:48 PM
Xqt changed the status of subtask T359069: test_deprecated_function_docstring test of tools_deprecate_tests.DeprecatorTestCase fails with Python 3.13 from Stalled to Open.Mar 4 2024, 11:43 PM
Xqt closed subtask T359069: test_deprecated_function_docstring test of tools_deprecate_tests.DeprecatorTestCase fails with Python 3.13 as Resolved.Mar 5 2024, 8:56 AM
Xqt closed subtask T358986: AutoFamily cannot be created for infogalactic.com wiki due to outdated certificate as Resolved.Mar 5 2024, 5:27 PM
Xqt added a subtask: T359427: site_generators_tests -v TestSiteGenerators.test_all_links fails on several wikis.Mar 6 2024, 5:25 PM
Xqt renamed this task from Usages of unittest.expectedFailure should be solved (goal) to Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Mar 8 2024, 12:30 PM
Xqt updated the task description. (Show Details)
Xqt changed the status of subtask T359427: site_generators_tests -v TestSiteGenerators.test_all_links fails on several wikis from Open to Stalled.Sun, Apr 21, 10:40 AM
Xqt removed a subtask: T359427: site_generators_tests -v TestSiteGenerators.test_all_links fails on several wikis.Sun, Apr 21, 2:52 PM
Xqt added a subtask: T362384: pagegenerators_tests fails on wowwiki:uk.Mon, Apr 22, 7:49 AM
Xqt added a subtask: T363101: TestWikibaseMakeClaim.test_musical_notation_edit fails.Mon, Apr 22, 2:57 PM
Xqt closed subtask T363101: TestWikibaseMakeClaim.test_musical_notation_edit fails as Resolved.Mon, Apr 22, 4:09 PM
Xqt added a subtask: T325860: Unable to submit any pywikibot.WbTime with hour/minute/second even if precision is day or lower.Tue, Apr 23, 11:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL