Throw an error for incorrect logtypes for pagegenerators.handleArgs()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Mar 25 2016, 2:13 PM

Description

There where an old pagegenerators.handleArgs() option set which like '-movelog' which is deprecated now. On the other hand it also accepts -anything_which_ends_with_log as a valid option but an exception should be raised instead.
Any fix for this bug should also remove unittest.expectedFailure decorator at pagegenerators_tests.TestLogeventsFactoryGenerator.test_logevents_parse()

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Throw an error for incorrect logtypes for pagegenerators.handleArgs()	pywikibot/core	master	+15 -8

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T152961 Improve tests suite
Open	None	T129368 Usages of unittest.expectedFailure or unittest.skip should be solved (goal)
Resolved	Xqt	T130928 Throw an error for incorrect logtypes for pagegenerators.handleArgs()

Event Timeline

Xqt created this task.Mar 25 2016, 2:13 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMar 25 2016, 2:13 PM

Xqt added a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Mar 25 2016, 2:13 PM

The same should be implemented for logevents:

\# TODO: Check if logtype is one of the allowed log types

Tests should be provided for logevents too.

Xqt claimed this task.Mar 25 2016, 6:16 PM

Change 279645 had a related patch set uploaded (by Xqt):
[FEAT] Throw an error for incorrect logtypes for pagegenerators.handleArgs()

https://gerrit.wikimedia.org/r/279645

gerritbot added a project: Patch-For-Review.Mar 27 2016, 10:35 AM

Xqt triaged this task as Low priority.Mar 28 2016, 7:02 PM

Magul closed this task as Resolved.Nov 29 2016, 6:07 PM

Change 279645 merged by jenkins-bot:
[bugfix] Throw an error for incorrect logtypes for pagegenerators.handleArgs()