Page MenuHomePhabricator
Create Task
Maniphest T135865

References sections should always be collapsed
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When references are scrubbed (lazy loaded references is enabled) the content of any section containing a <reference> tag should be collapsed regardless of whether they are mobile or tablet.
Note that multiple references tag can appear on a page so more than one section may appear collapsed.

Details

SubjectRepoBranchLines +/-
Collapse references sections by defaultmediawiki/extensions/MobileFrontendmaster+71 -39
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 Resolveddr0ptp4ktT114542 Next Generation Content Loading and Routing, in Practice
 Duplicate• JhernandezT104432 [EPIC]: Improve mobile site performance
 Duplicatedr0ptp4ktT120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
 DeclinedNoneT125920 [EPIC] Future exciting reading web performance endeavours
 ResolvedJdlrobsonT113066 [GOAL] Make Wikipedia more accessible to 2G connections
 DeclinedNoneT123328 [GOAL] Lazy load references in mobile skin
 DuplicateNoneT137154 Deploy lazy loaded images to tl.m.wikipedia.org
 DuplicateNoneT137081 Special:MobileCite not optimized to prevent indexing
 ResolvedJdlrobsonT136731 Deploy lazy loaded images, lazy loaded images + references to a couple larger wikis
 ResolvedphuedxT137822 Deploy lazy loaded images and references to tl.m.wikipedia.org
 Resolved• JhernandezT135539 Lazy loaded references in articles with JS for users who want to view the entire references section
 ResolvedJdlrobsonT135865 References sections should always be collapsed
 ResolvedJdlrobsonT138792 [Subtask] Lazy loading references does not work on reference sections with subsections

Event Timeline

Jdlrobson created this task.May 20 2016, 6:21 PM
Jdlrobson added a parent task: T123328: [GOAL] Lazy load references in mobile skin.
dr0ptp4kt moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.May 21 2016, 12:32 PM
Jdlrobson updated the task description. (Show Details)May 23 2016, 4:48 PM
Jdlrobson updated the task description. (Show Details)May 23 2016, 4:55 PM
Jdlrobson set the point value for this task to 3.
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.
dr0ptp4kt moved this task from 2016-17 Q2 to 2015-16 Q4 on the Web-Team-Backlog board.May 23 2016, 7:36 PM
Jdlrobson claimed this task.May 23 2016, 9:18 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.
gerritbot subscribed.May 23 2016, 9:28 PM

Change 289344 had a related patch set uploaded (by Jdlrobson):
Collapse references sections by default

https://gerrit.wikimedia.org/r/289344

gerritbot added a project: Patch-For-Review.May 23 2016, 9:28 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 23 2016, 10:08 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 24 2016, 1:49 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 24 2016, 5:35 PM
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 24 2016, 8:35 PM
• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 24 2016, 9:12 PM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 25 2016, 9:07 AM
phuedx subscribed.

289344: Collapse references sections by default needs a rebase.

phuedx added a comment.May 25 2016, 9:17 AM

Done.

phuedx moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 25 2016, 9:17 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 25 2016, 9:55 AM
Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 25 2016, 5:33 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 25 2016, 7:52 PM
phuedx added a comment.May 26 2016, 10:39 AM

I've commented on the change with my thoughts. I've reviewed and tested it and it looks OK to me. Frankly, I'm not sure why we're only doing this when on-demand loaded references is enabled!

Jdlrobson added a comment.May 26 2016, 3:19 PM

It's an incremental step (see blocking task). On demand references is in next sprint - we didnt have bandwidth to do it this sprint.

gerritbot added a comment.May 27 2016, 8:48 AM

Change 289344 merged by jenkins-bot:
Collapse references sections by default

https://gerrit.wikimedia.org/r/289344

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 27 2016, 8:52 AM
Jdlrobson closed this task as Resolved.May 27 2016, 6:06 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 12:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL