Page MenuHomePhabricator

CopyPatrol does not correctly handle pages in Draft namespace
Closed, ResolvedPublic3 Estimated Story Points

Description

Currently one of the revisions highlighted as a potential copyvio in the CopyPatrol tool is 725331053. This revision occurred in the Draft namespace rather than in the Main namespace. In the CopyPatrol interface, the link to the article points to https://en.wikipedia.org/wiki/The_Gambia_Chamber_of_Commerce_and_Industry, which doesn't exist (and is a redlink in the interface). The draft, however, does exist and should be linked to appropriately: https://en.wikipedia.org/wiki/Draft:The_Gambia_Chamber_of_Commerce_and_Industry. The "Diff" link also needs to be fixed to include the namespace.

Event Timeline

kaldari triaged this task as High priority.Jun 15 2016, 1:55 AM
kaldari moved this task from New & TBD Tickets to Up Next (June 3-21) on the Community-Tech board.
kaldari moved this task from Up Next (June 3-21) to Needs Discussion on the Community-Tech board.

Interesting. I didn't know Eranbot also checked Draft namespaces for copyvios.
So, at the moment, I have hardcoded namespace for the url. To change this, we should do a query JOIN with page table ON rev_page == page_title and grab the page_namespace and convert that to the appropriate namespace title.
I'm a bit concerned that this will increase the load time further. @kaldari - thoughts?

rev_page is an ID (luckily), not a title, so we can join against page_id which is a primary key and should be fast.

DannyH set the point value for this task to 3.

Done. The page titles appear as "Draft:Kenneth L Shepard" on the page.