Page MenuHomePhabricator
Create Task
Maniphest T149649

Upon deleting a newsletter, do not show the subtitle navigation on top
Closed, DuplicatePublic
Actions

Description

This can lead to warnings and fatals as the links redirect to pages that do not exist.

Steps to reproduce:

  1. Create a new newslettter
  2. Delete the newsletter
  3. on that page, click on any link on the subtitle navigation bar.

Expeted: That subtitle thing should not be there.

Related Objects
Search...

StatusSubtypeAssignedTask
 DuplicateQgilT125545 Phabricator Q&A session for Community Liaisons
 ResolvedQgilT116025 Goal: Align Community Liaison and Developer Relations project management practices
 ResolvedQgilT119387 Community Liaison and Developer Relation quarterly goals for January - March 2016
 DeclinedNoneT104131 Exporting existing newsletter to the Newsletter extension
 ResolvedAddshoreT110170 Goal: Deploy Newsletter extension in Wikimedia
 DuplicateNoneT115098 Deploy Newsletter extension in beta cluster
 ResolvedoriT127297 Add the Newsletter extension to the Beta Cluster
 ResolvedBawolffT115095 Security review of Newsletter extension
 ResolvedGlaisherT116382 Raw html should be escaped before output in Newsletter pages
 ResolvedTinaj1234T110491 Newsletter extension should have validation
 DeclinedNoneT131616 Cap the number of active newsletters per user
 ResolvedGlaisherT132016 Add CheckUser integration to Extension:Newsletter
 Resolved01tonythomasT132018 Add newsletter description to log messages
 ResolvedGlaisherT132017 Throttle for newsletter announcements
 Resolved01tonythomasT132019 Add table prefix to sub-queries in NewsletterTablePager
 ResolvedPpperyT132022 Add AbuseFilter integration to Extension:Newsletter
 ResolvedDaimonaT135668 Need documentation on How to integrate AbuseFilter with xyz extension
 ResolvedDaimonaT239348 Custom actions should always be included in the list of available actions
 Resolved01tonythomasT119058 Special:Newsletter fatals if the newsletter main page is deleted
 ResolvedQgilT154229 Agree first user group that will be able to create newsletters in Wikimedia
 ResolvedFilipT154534 Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default
 ResolvedxSavitarT159075 Fix character escaping throughout the extension files
ResolvedNoneT159084 [Security] Fix inconsistent Newsletter user rights
Resolved01tonythomasT159085 [Security] Improve data attribute naming to avoid forge
 Resolved01tonythomasT160854 Newsletter strange behaviour on an API create/edit
Resolved01tonythomasT140402 Namespace is repeated in notification link
 Resolved01tonythomasT138462 Convert Newsletter to use ContentHandler
 DuplicateNoneT149649 Upon deleting a newsletter, do not show the subtitle navigation on top

Event Timeline

01tonythomas created this task.Oct 31 2016, 11:48 PM
01tonythomas added a project: Google-Code-In-2016.Nov 2 2016, 11:47 AM

GCI requirements: Need a mentor here!

01tonythomas moved this task from Proposed tasks to Missing mentors on the Google-Code-In-2016 board.Nov 2 2016, 12:01 PM
01tonythomas moved this task from Backlog to Google Code In 2016 on the MediaWiki-extensions-Newsletter board.Nov 5 2016, 4:51 PM
01tonythomas moved this task from Missing mentors to Proposed tasks on the Google-Code-In-2016 board.Nov 12 2016, 3:28 PM
Florian moved this task from Proposed tasks to Missing mentors on the Google-Code-In-2016 board.Nov 16 2016, 6:03 PM
Florian subscribed.

@01tonythomas: Would you maybe mentor this task? :)

Devirk subscribed.Nov 27 2016, 12:55 PM

I would like to mentor this task for Google-Code-In-2016 !

Aklapper added a comment.Nov 27 2016, 6:39 PM

@Devirk: Please see https://www.mediawiki.org/wiki/Google_Code-in_2016 for info about mentoring

01tonythomas added a comment.Dec 4 2016, 11:38 PM

@Aklapper : was this improted ? If not, it would be a great task there and @Devirk has agreed to mentor. I too can take a look at times!

Aklapper moved this task from Missing mentors to Imported in GCI Site on the Google-Code-In-2016 board.Dec 5 2016, 9:32 AM

Imported as https://codein.withgoogle.com/tasks/6220680376877056/

MtDu subscribed.Dec 5 2016, 6:42 PM

@01tonythomas Is this still a valid task after my patch https://gerrit.wikimedia.org/r/#/c/325249/ for https://phabricator.wikimedia.org/T152359 and the subtasks?

01tonythomas added a comment.Dec 5 2016, 10:08 PM

Well - in that case - no. But I think the other tasks are not imported yet!

01tonythomas added a comment.Dec 6 2016, 1:49 PM
In T149649#2846332, @Aklapper wrote:

Imported as https://codein.withgoogle.com/tasks/6220680376877056/

This should go as the GCI task for https://phabricator.wikimedia.org/T152359. Closing this one as duplicate of the other one!

01tonythomas closed this task as a duplicate of T152359: Remove Special:Newsletter/id/delete forms completely form Newsletter interface.Dec 6 2016, 1:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL