Page MenuHomePhabricator

Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5
Closed, ResolvedPublic2 Estimated Story Points

Description

https://en.m.wikipedia.org/wiki/Main_Page

Timebox: 8hr (if you spend longer than this time bring it back to discussion at standup)

Screen Shot 2016-12-08 at 4.56.53 PM.png (1×1 px, 420 KB)

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 2.

Change 326526 had a related patch set uploaded (by Bmansurov):
Remove redundant "prefix" from ResourceLoaderImageModule modules

https://gerrit.wikimedia.org/r/326526

A few observations:

So, the issue is with the production environment whether logged in or out.

I've submitted a patch above which cleans up the icon code, but I don't know if it will fix the issue as the issue is happening in production only.

Pinging, Release-Engineering-Team in case they can help.

I couldn't replicate this on https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page as you state.
Whenever I see this, my thoughts immediately turn to MediaWiki:Mobile.css
I ported MediaWiki:Mobile.css to the beta cluster - and of course after doing this the beta cluster was showing the same problem
Bingo: https://en.m.wikipedia.org/wiki/Special:MobileDiff/754478793

Worth an upstream bug @Krinkle ? Seems we could/should lint this css?