| matmarex | |
| Dec 16 2016, 10:57 PM |
| F5104073: Screen Shot 2016-12-19 at 2.29.26 PM.png | |
| Dec 19 2016, 10:35 PM |
| F5078230: pasted_file | |
| Dec 16 2016, 10:57 PM |
Echo's "You have new messages" fails WCAG AAA contrast guidelines. #54595d on #ffcc33 is contrast ratio 4.7. (It passes WCAG AA, just barely.)
Subjectively, the background color is unpleasantly bright. It used to be more subdued before 550dc4ee8839a574d170ba2c9abdebff9e562244.
Change 327867 had a related patch set uploaded (by Ladsgroup):
Make mw.echo.alert text darker to pass WCAG test
Change 327867 merged by jenkins-bot:
Make mw.echo.alert text darker to pass WCAG test
The screenshot is from betalbs (after the patch was merged).
mw-echo-alert with color: #222;
Huh, that's actually interesting, your screenshot shows the link as blue, because it's :visited. I'm not sure if that's intentional.
@Catrope @matmarex No, definitely not, this message shouldn't change text color.
Coming a lil late to this party, I'd like to add that we're aiming for level AA conformance and not AAA for design limitation reasons as general guideline. In this special case for an important message it makes sense to go that route. Note to myself: Will try to emphasize this in the upcoming guidelines.
In a side-note, I see this as a candidate to align with the solution of T127405 as well (we should revisit this).