Page MenuHomePhabricator
Create Task
Maniphest T166740

Warning box inconsistent on collections view
Closed, ResolvedPublic
Actions

Description

Visit https://m.mediawiki.org/wiki/User:Jdlrobson/Books/The_reading_web_guide_to_the_PDF_galaxy and compare with https://www.mediawiki.org/wiki/User:Jdlrobson/Books/The_reading_web_guide_to_the_PDF_galaxy

Screen Shot 2017-05-31 at 4.08.16 PM.png (626×926 px, 148 KB)

Screen Shot 2017-05-31 at 4.09.13 PM.png (596×1 px, 239 KB)

The styles for the warning box on desktop do not show up in mobile as the mobile skin is only compatible with the warningbox class.

acceptance criteria

  • It show use the warningbox class and inherit styles from core.

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 31 2017, 11:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2017, 11:10 PM
Jdlrobson added a project: Web-Team-Backlog.May 31 2017, 11:11 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson added a parent task: T127405: Review current style and integrate Messages and message boxes (errors, warnings) as WikimediaUI component.Jun 1 2017, 4:55 PM
Jdlrobson moved this task from Needs Prioritization to Design on the Web-Team-Backlog board.Jun 6 2017, 10:03 PM
Jdlrobson edited projects, added Web-Team-Backlog (Design); removed Web-Team-Backlog.
Jdlrobson moved this task from Needs triage to Triaged on the Mobile board.Jul 19 2017, 1:10 AM
Volker_E moved this task from Unsorted to Wikimedia Design Style Guide on the UI-Standardization board.Aug 15 2017, 9:45 PM
Jdlrobson triaged this task as Low priority.Nov 29 2018, 11:47 PM
Volker_E subscribed.Mar 7 2019, 4:16 AM

@Jdlrobson This is still the case, correct? It would be positively affected by relying on shared.css and its warningbox styles as well!

Jdlrobson closed this task as Resolved.Mar 7 2019, 11:26 PM
Jdlrobson claimed this task.

this looks fixed to me...
it's using TemplateStyles now
https://m.mediawiki.org/wiki/User:Jdlrobson/Books/The_reading_web_guide_to_the_PDF_galaxy
(this is good direction I think as it moves the styles inline only to pages that need them). I think warning boxes should possibly be limited to specific non-reader facing interfaces so I'm marking this as resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL