Promote expand all sections feature from beta (in feature branch)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 29 2017, 6:10 PM

Description

https://en.m.wikipedia.org/wiki/Special:MobileOptions?mobileaction=beta
A feature "expand all sections" allows users to always keep sections open. It works for anonymous users.

Screen Shot 2017-06-29 at 11.09.50 AM.png (565×929 px, 51 KB)

Acceptance criteria

Promote "expand all sections" to stable:

remove from list of beta features and display expand all sections within list of settings

Developer notes

The MFExpandAllSectionsUserOption controls this. Current value is:

"MFExpandAllSectionsUserOption": {
        "base": false,
        "beta": true
},

base must be flipped to true either via change inside repo or SWAT

Details

	Subject	Repo	Branch	Lines +/-
	Promote expand all sections and fontchanger to stable	mediawiki/extensions/MobileFrontend	specialpages	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Declined	None	T67078 Allow feedback for mobile beta features like Desktop
Resolved	• Jhernandez	T104319 [GOAL]: Feature flag features on MobileFrontend
Resolved	None	T141087 [EPIC] Add feature management
Resolved	ovasileva	T67079 [Epic] Show what features are included in Beta
Resolved	• Nirzar	T169257 Promote expand all sections feature from beta (in feature branch)
Resolved	• Nirzar	T169807 Replace settings checkboxes to ToggleSwitches
Open	None	T182466 Implement ToggleSwitchInputWidget
Resolved	• Nirzar	T183493 Remove 'Expand all section' toggle on tablet and desktop mode

Event Timeline

Jdlrobson created this task.Jun 29 2017, 6:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2017, 6:10 PM

Jdlrobson mentioned this in T67079: [Epic] Show what features are included in Beta.Jun 29 2017, 6:17 PM

@Nirzar - same mockup as T67079: [Epic] Show what features are included in Beta, right?

• Nirzar moved this task from Needs analysis to Next up on the Web-Team-Backlog (Design) board.Jun 30 2017, 9:18 PM

• Nirzar created subtask T169807: Replace settings checkboxes to ToggleSwitches.Jul 5 2017, 8:28 PM

• Nirzar moved this task from Next up to Designing/discussing right now on the Web-Team-Backlog (Design) board.Jul 7 2017, 10:55 PM

• Nirzar moved this task from Designing/discussing right now to Next up on the Web-Team-Backlog (Design) board.Aug 24 2017, 9:38 PM

• Nirzar moved this task from Design to Triaged but Future on the Web-Team-Backlog board.Sep 11 2017, 10:53 PM

• Nirzar edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).

Did we make a decision? Are we moving this to stable? The description hasn't been updated...

• Nirzar closed subtask T169807: Replace settings checkboxes to ToggleSwitches as Declined.Nov 23 2017, 8:50 PM

• Nirzar reopened subtask T169807: Replace settings checkboxes to ToggleSwitches as Open.Dec 1 2017, 1:40 AM

ovasileva updated the task description. (Show Details)Dec 4 2017, 3:26 PM

ovasileva moved this task from Design to Upcoming on the Web-Team-Backlog board.Dec 6 2017, 3:10 PM

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).

Does this deploy to all wikis? Do we need any extra logging? Will this trigger existing expand / collapse logging for all sections on a page?

Being bold and assigning 1 since this is essentially a swat deploy.

Jdlrobson added a project: Mobile-Web-Settings.Dec 7 2017, 10:17 PM

Change 396284 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@specialpages] Promote expand all sections and fontchanger to stable

https://gerrit.wikimedia.org/r/396284

gerritbot added a project: Patch-For-Review.Dec 7 2017, 10:47 PM

ovasileva added a parent task: T67079: [Epic] Show what features are included in Beta.Dec 8 2017, 1:41 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Dec 11 2017, 12:17 PM

ovasileva renamed this task from Promote expand all sections feature from beta to Promote expand all sections feature from beta (in feature branch).Dec 11 2017, 3:36 PM

Jdlrobson moved this task from Upcoming to 2017-18 Q2 on the Web-Team-Backlog board.Dec 11 2017, 5:21 PM

ovasileva moved this task from To Do to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.Dec 13 2017, 6:34 PM

blocked on T169807: Replace settings checkboxes to ToggleSwitches

Change 396284 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@specialpages] Promote expand all sections and fontchanger to stable

https://gerrit.wikimedia.org/r/396284

Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Dec 20 2017, 3:20 AM

Code is deployed on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOptions

pmiazga assigned this task to • Nirzar.Dec 20 2017, 6:09 PM

Overall settings work seems to be working as expected! yay!

but one minor issue on this card.... kind of a bug to "expand al sections" feature so let me know if we want to create a follow up card or fix it as part of this card

Issue

Tablets/desktop layout is set to expanding all sections by default on MinervaNeue. this creates a little bit of problem when a setting to enable/disable this feature is introduced on tablets. as a result, if you turn off "expand all sections" on tablets, it won't actually collapse all section which is the expected behaviour.

what should happen

on tablets, this particular toggle should be switched 'ON' by default
on tablets, turning off this toggle in settings should collapse all sections on tablets

as per @pmiazga created a subtask to this for the above issue -

T183493: Remove 'Expand all section' toggle on tablet and desktop mode

cc @ovasileva if T183493 should be a blocker to promote this feature to stable

I'll be bold, we have an UI glitch, we cannot promote to stable something that is broken. Moving to blocked, as it's blocked on T183493.

@Jdlrobson it would be amazing if you can verify the T183493 and propose a fix.

Jdlrobson mentioned this in T183493: Remove 'Expand all section' toggle on tablet and desktop mode.Jan 2 2018, 6:59 PM

• Nirzar closed subtask T169807: Replace settings checkboxes to ToggleSwitches as Resolved.Jan 2 2018, 9:54 PM

Since https://gerrit.wikimedia.org/r/396284 has been merged and we have T183493 and the deploy task this particular task can be considered done. Maybe Nirzar should sign off?