@Nirzar Related to this is open T140812#3300282. It'd be good to get feedback in order to get to a conclusion there…

FYI async saving is quite trivial to add (in fact I added it as part of the POC patch).

I agree though non-js fallback for this control is a little more confusing... unless you switch a checkbox to a toggle switch which might be jarring to a user.

FYI async saving is quite trivial to add (in fact I added it as part of the POC patch).

that's good to know!

I guess async + non-js fallback to checkboxes and save button would be a little too much work right now. it won't be confusing given that non-js usually has different experience.

how would categorize following work, small, m, l, xl?

for JS

• show toggle switches for controls
• remove save button
• save settings async

for non-js

• show checkboxes for controls
• keep save button

OOJSUI integration is covered in T169369 which includes extra performance AC. This task probably shouldn't be worked on until that's done.

Change 394634 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@specialpages] Upgrade checkboxes to ToggleSwitches on options form

https://gerrit.wikimedia.org/r/394634

@Nirzar the ToggleSwitches could be done like this: http://reading-web-staging.wmflabs.org/wiki/Special:MobileOptions
Checkboxes get upgraded to toggle switches via JS. Note there is an unavoidable flash of unstyled content when doing this (as a result of needing to support non-JS users)

Thoughts on flash of unstyled content when we switch checkboxes to toggle switches?

Oh sorry, I missed this comment. I would want to see the FOUC we are talking about. I should have checked it before when toggleswitches were deployed.

another option is not to show checkboxes and only show toggleswitches after loading. till then keeping the visibility:invisible

Yeh we can do that, but trade off is that if there's a bug in OOjs UI the form becomes unusable, but I guess with async saving we have that problem anywhere. Looks like we have all we need to do this. Just needs to be discussed, estimated and brought into the sprint.

It looks like the beta mode needs to be saved by submitting the form.
@Nirzar this creates problems as the ToggleSwitch is not a checkbox so it doesn't update any form value that can be submitted (thus beta optin currently not working on staging :()

I think we need to sync about how saving should work and the work involved to make beta behave asynchronously and whether the effort to fix this is worth it.

See also https://phabricator.wikimedia.org/T169369#3823601

Both https://gerrit.wikimedia.org/r/394634 and https://gerrit.wikimedia.org/r/396082 are needing review.

https://gerrit.wikimedia.org/r/#/c/396082/6 is merged. I have some strange issues while testing https://gerrit.wikimedia.org/r/394634 - save behavior is wonky, sometimes it saves the value, sometimes it doesn't. @Jdlrobson cannot reproduce it locally. I want to make sure that this behavior is specific only to my machine

I'm still investigating the issue

^ Per T169807#3837104.

Change 394634 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@specialpages] Upgrade checkboxes to ToggleSwitches on options form

https://gerrit.wikimedia.org/r/394634

@pmiazga to updating the staging server and ping a signerer offerer.

@Nirzar ready to test

just spoke with @pmiazga about 3 points

summary -

• Beta settings toggle should not get stuck on refresh page, figuring out other way to enable beta mode
• Look into delay before the toast message, it's localstorage and there shouldn't be any delay for toast to show when a setting is saved
• tapping on <label> doesn't trigger the input element on some androids

@Nirzar

• Beta settings toggle should not get stuck on refresh page, figuring out other way to enable beta mode

We might do it properly with async save, not the page reload. I'm not touching it right now.

• Look into delay before the toast message, it's localstorage and there shouldn't be any delay for toast to show when a setting is saved

There is 1s delay between action and showing the toast message. I'll remove that delay

• tapping on <label> doesn't trigger the input element on some androids

I'll look at it, so far I see that "Expand all sections" label is missing for attribute.

Change 398530 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@specialpages] Show toast messages without 1s delay

https://gerrit.wikimedia.org/r/398530

Change 398530 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@specialpages] Show toast messages without 1s delay

https://gerrit.wikimedia.org/r/398530

In T169807#3841337, @Nirzar wrote:

• Look into delay before the toast message, it's localstorage and there shouldn't be any delay for toast to show when a setting is saved

This is done.

Change 398889 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@specialpages] Toggle the Beta toggle when user clicks on label

https://gerrit.wikimedia.org/r/398889

Change 398889 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@specialpages] Toggle the Beta toggle when user clicks on label

https://gerrit.wikimedia.org/r/398889

Code is deployed on http://reading-web-staging.wmflabs.org/wiki/Special:MobileOptions

Change 399463 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@specialpages] Delay form submit by 0.25s

https://gerrit.wikimedia.org/r/399463

I decided to quickly patch

Beta settings toggle should not get stuck on refresh page, figuring out other way to enable beta mode

by adding 250ms delay between toggle change and form submit.

We don't know when (and if) we're going to change the Special:MobileOptions save mode to async and we shouldn't leave it as it is right now.

The delay is making the experience much better. I can toggle the switch now. looks good.

Change 399463 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@specialpages] Delay form submit by 0.25s

https://gerrit.wikimedia.org/r/399463