Page MenuHomePhabricator
Create Task
Maniphest T169835

Enhanced RC expand/collapse arrows are not shown when starting from a conflict state
Closed, ResolvedPublic
Actions

Description

  1. Go to https://www.mediawiki.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&urlversion=2&hideliu=1&userExpLevel=newcomer&enhanced=1 . Note that this is a conflict state (unregistered + newcomers) and that enhanced RC is enabled.
  2. Remove the "newcomer" filter. You should now see results. Note that the lines with multiple results don't have arrows to expand them, and the text styling is wrong generally.
  3. Refresh the page. Note that the arrows now appear, and the text styling is now correct.

Unstyled version:

enhancedrc-unstyled.png (253×1 px, 95 KB)

Styled version:

enhancedrc-styled.png (206×1 px, 93 KB)

Details

SubjectRepoBranchLines +/-
ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format zero rowsmediawiki/coremaster+2 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Jul 5 2017, 11:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2017, 11:36 PM
Catrope claimed this task.Jul 5 2017, 11:37 PM
Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Catrope updated the task description. (Show Details)
gerritbot subscribed.Jul 5 2017, 11:43 PM

Change 363509 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format zero rows

https://gerrit.wikimedia.org/r/363509

gerritbot added a project: Patch-For-Review.Jul 5 2017, 11:43 PM
Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 5 2017, 11:45 PM

This was an interesting bug and I found it pretty much by accident. The state you start with can't just be any zero-results state, it has to be a short-circuited state like a conflict. (Or, in the case of RecentchangesLinked, a nonexistent target page, that's how I found it.)

Etonkovidova subscribed.Jul 7 2017, 10:38 PM

Checked the fix in betalabs.

Catrope added a comment.Jul 8 2017, 12:05 AM
In T169835#3417123, @Etonkovidova wrote:

Checked the fix in betalabs.

Really? The patch isn't merged yet...

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 14 2017, 1:54 PM
gerritbot added a comment.Jul 14 2017, 2:04 PM

Change 363509 merged by jenkins-bot:
[mediawiki/core@master] ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format zero rows

https://gerrit.wikimedia.org/r/363509

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 14 2017, 3:00 PM
• jmatazzoni mentioned this in T170501: Graduate 'New filters for edit review' out of beta, making it standard on all wikis.Jul 14 2017, 9:50 PM
Etonkovidova added a comment.EditedJul 17 2017, 7:53 PM

Hmm... there might have been some other factors affecting the manifestation of the issue, cause I definitely saw the bug happening and then not happening when I

In T169835#3417391, @Catrope wrote:
In T169835#3417123, @Etonkovidova wrote:

Checked the fix in betalabs.

Really? The patch isn't merged yet...

Thx @Catrope for pointing out the missing factor!
Now, I checked the fix in betalabs after the last patch has been merged - all seems to be in place.

Etonkovidova closed this task as Resolved.Jul 17 2017, 7:53 PM
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 17 2017, 8:29 PM
• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).Jul 17 2017, 8:53 PM
• jmatazzoni mentioned this in T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis.Jul 21 2017, 7:26 PM
• jmatazzoni added a parent task: T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis.Jul 21 2017, 7:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL