Page MenuHomePhabricator
Create Task
Maniphest T174698

Parenthetical stripping is too aggressive
Closed, ResolvedPublic
Actions

Description

http://0.0.0.0:6927/en.wikipedia.org/v1/page/preview-html/Spain returns the very last sentence as the summary. It doesn't make sense. The parenthetical stripping is far too aggressive and needs updating. Currently Spain is given the summary:
"Spain and its African territory accounts for nearly 5% of its population, mostly in the Canary Islands but also in Ceuta and Melilla."

This problem is present on various summaries including:

  • Spain
  • France

Details

SubjectRepoBranchLines +/-
Parenthetical stripping should not be greedymediawiki/services/mobileappsmaster+28 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT169242 Develop Page Content Service for Reading Clients
 ResolvedNoneT177425 Develop General Layer of PCS
 Resolved• JhernandezT177426 Develop structured JSON APIs for general consumption
 Resolved• MhollowayT177431 Develop a Summary JSON API
 DuplicateNoneT109698 [EPIC]: Roll out Hovercards to stable on desktop
 DeclinedNoneT109796 [EPIC] Get Hovercards to feature parity with Navigation Pop-ups (tracking) [AOI]
 ResolvedDerecksonT68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
 ResolvedJdlrobsonT70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
 ResolvedovasilevaT154635 [EPIC] Deploy page previews to English and German Wikipedia
 DuplicateNoneT130671 Hovercards should show for disambiguation pages
 DeclinedNoneT168391 Page previews should display generic preview for disambiguation pages
 Resolved• NirzarT168392 Page previews should display custom preview for disambiguation pages
 ResolvedovasilevaT192622 [EPIC] Page previews post-deploy cleanup
 ResolvedJdlrobsonT173952 Remove A/B testing instrumentation code
 DuplicateNoneT167433 Switch all projects to the new (and yet to be built) summary-html endpoint for page previews
 DuplicateNoneT167429 Make enwiki and dewiki fetch previews from the summary-html RESTBase endpoint
 ResolvedovasilevaT165018 Page previews can consume new summary-HTML endpoint
 DeclinedJdlrobsonT111329 [GOAL] Page previews on mobileweb
 ResolvedJdlrobsonT164010 [EPIC] Strengthen the APIs we provide in reading web maintained extensions
 ResolvedovasilevaT113094 [EPIC] The Page Summary API needs to provide useful content for the majority of articles
 ResolvedJdlrobsonT171052 Add disambiguation page handling in Page Summary API
 DeclinedNoneT170612 Only fetch content from new Page Summary MCS route when Accept header is v2.0+
 ResolvedphuedxT170667 Security review the Page Summary API in MCS
 DeclinedNoneT171331 Should we add sentence Boundary Detection to the Page Summary API?
 ResolvedJdlrobsonT168848 Bootstrap an initial version of the Page Summary API in MCS
 ResolvedJdlrobsonT174698 Parenthetical stripping is too aggressive

Event Timeline

Jdlrobson created this task.Aug 31 2017, 4:30 PM
Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptAug 31 2017, 4:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson updated the task description. (Show Details)Aug 31 2017, 4:30 PM
Jdlrobson updated the task description. (Show Details)Aug 31 2017, 4:44 PM
gerritbot subscribed.Aug 31 2017, 6:59 PM

Change 375056 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/services/mobileapps@master] Parenthetical stripping should not be greedy

https://gerrit.wikimedia.org/r/375056

gerritbot added a project: Patch-For-Review.Aug 31 2017, 6:59 PM
Jdlrobson added a parent task: T168848: Bootstrap an initial version of the Page Summary API in MCS.Aug 31 2017, 7:01 PM
gerritbot added a comment.Sep 1 2017, 3:06 PM

Change 375056 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Parenthetical stripping should not be greedy

https://gerrit.wikimedia.org/r/375056

Jdlrobson moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Sep 1 2017, 3:09 PM
Jdlrobson edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
Jdlrobson moved this task from To Do to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Stashbot mentioned this in T168848: Bootstrap an initial version of the Page Summary API in MCS.Sep 6 2017, 9:32 PM
Stashbot mentioned this in T169277: Investigate missing page in specific "On this day" event.
Stashbot mentioned this in T169274: Expand "On this day" endpoint language support.
Stashbot mentioned this in T162179: Extract HTML Compatibility Layer from MCS Mobile Sections API.
Stashbot mentioned this in T164033: Test size of "Reading stripped" HTML vs non-stripped HTML.
Stashbot mentioned this in T167921: Support Lazy loading of page content not needed for first paint .
Stashbot subscribed.

Mentioned in SAL (#wikimedia-releng) [2017-09-06T21:32:14Z] <bearND> Update mobileapps to 2cb6281 (T168848 T169277 T169274 T162179 T164033 T167921 T174698 T168848 T174808)

Stashbot mentioned this in T174808: Add swagger spec for summary endpoint.Sep 6 2017, 9:32 PM
Stashbot added a comment.Sep 6 2017, 10:06 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-06T22:06:32Z] <bsitzmann@tin> Started deploy [mobileapps/deploy@507a479]: Update mobileapps to 2cb6281 (T168848 T169277 T169274 T162179 T164033 T167921 T174698 T168848 T174808)

Stashbot added a comment.Sep 6 2017, 10:11 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-06T22:11:25Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@507a479]: Update mobileapps to 2cb6281 (T168848 T169277 T169274 T162179 T164033 T167921 T174698 T168848 T174808) (duration: 04m 53s)

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 12 2017, 10:04 PM
Jdlrobson closed this task as Resolved.Sep 25 2017, 7:43 PM
Jdlrobson claimed this task.

Looking good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL