Switch all projects to the new (and yet to be built) summary-html endpoint for page previews
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	ovasileva
	Jun 8 2017, 4:19 PM

Description

Before switch

ensure all open bugs related to summary endpoint are closed, declined, or stalled

Acceptance Criteria

Switch all projects to summary-html endpoint for page previews

Sign off steps

Open T173952 and update.

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T192622 [EPIC] Page previews post-deploy cleanup
Resolved	Jdlrobson	T173952 Remove A/B testing instrumentation code
Duplicate	None	T167433 Switch all projects to the new (and yet to be built) summary-html endpoint for page previews
Duplicate	None	T167429 Make enwiki and dewiki fetch previews from the summary-html RESTBase endpoint
Resolved	ovasileva	T165018 Page previews can consume new summary-HTML endpoint
Resolved	ovasileva	T168332 HTML previews' layout breaks text multi-line text truncation
Resolved	ovasileva	T113094 [EPIC] The Page Summary API needs to provide useful content for the majority of articles
Resolved	phuedx	T113633 Spike: Alternative to TextExtracts for Popups, Gather, Read more
Resolved	phuedx	T109867 Infobox template parameters showing in Hovercard
Duplicate	None	T109869 Hovercards should not show <noinclude> content in the extract
Resolved	Jdlrobson	T74629 Reference lists appearing in extracts for some articles
Resolved	Jdlrobson	T73023 Invalid HTML markup standalone LI element when using references on main page
Duplicate	None	T112137 Hovercards loses manual superscript formatting by requesting plain text
Duplicate	ovasileva	T152414 Previews must display useful text for the majority of articles
Resolved	ovasileva	T159388 Text Extracts used in Page Previews shows strange characters from template
Duplicate	None	T162219 Parentheticals: Words incorrectly concatenated due to too simple removing of spaces
Declined	None	T159065 Fix formulas in HTML extracts
Duplicate	Jdlrobson	T163442 Math formulas are not rendering in preview page dialogs
Resolved	Mhurd	T155573 [Regression] exclude pronunciation guides from article extracts
Declined	• JMinor	T164100 Consider excluding pronunciation guides from TextExtracts
Resolved	phuedx	T112226 Text extracts unable to summarise content contains {{dts}} templates
Resolved	• Pchelolo	T165017 Setup RESTBase HTML extract endpoint
Resolved	Jdlrobson	T165619 Spike: Specify changes to page-summary endpoint
Declined	• Pchelolo	T166163 Create a summary content migration filter
Resolved	phuedx	T167852 "<translate>" and <tvar\|*> tag visible in Page Previews: HtmlFormatter only flattens spans
Declined	Jdlrobson	T168329 exsentences does not work correctly when HTML output used
Duplicate	None	T168625 Make the Page Summary API return an "intro" for a page
Resolved	• Fjalapeno	T167022 Inventory requirements for summary 2.0 endpoint across Reading teams
Resolved	phuedx	T168400 [EPIC] Add notion of emptiness to page summary API
Declined	pmiazga	T168328 Extracts for Wikimedia List articles display partial previews
Declined	None	T168391 Page previews should display generic preview for disambiguation pages
Resolved	phuedx	T114418 Disable TextExtracts on file pages
Declined	None	T168418 Page Previews should accept the service's notion of emptiness
Resolved	• Pchelolo	T164291 Make title-related properties consistent
Resolved	• bearND	T169761 Review Summary 2.0 Spec
Resolved	• Mholloway	T170692 Return common URLs in summary API so clients do not have to perform bug prone string manipulation
Resolved	MSantos	T177619 Return variant URLs and titles in the metadata response
Resolved	• Mholloway	T178446 Expose display titles for a page in all available language variants through the action API
Invalid	None	T69232 Hovercards: Redirect titles should be bolded in the extract
Resolved	Jdlrobson	T170617 Adjust expectations for API consumers when using the TextExtracts API
Invalid	None	T185472 API problems with double spaces in wiki sections
Duplicate	None	T171053 Complete entire page previews test plan for page summary api
Resolved	Jdlrobson	T171052 Add disambiguation page handling in Page Summary API
Resolved	Jdlrobson	T168848 Bootstrap an initial version of the Page Summary API in MCS
Resolved	Jdlrobson	T172021 It shouldn't be possible for coordinates to be the lead paragraph
Resolved	Jdlrobson	T174698 Parenthetical stripping is too aggressive
Resolved	phuedx	T171065 Expose disambiguation property (ppprop=disambiguation) in mobileview api
Resolved	• bearND	T175286 Do side by side comparison of old summary endpoint against new summary endpoint
Resolved	• Mholloway	T176974 Mime vulnerability blocking merges to MCS
Duplicate	None	T176063 Page preview shows only the first two words for a specific article
Resolved	Jdlrobson	T176517 Pages that are redirects give empty summary objects
Resolved	Jdlrobson	T176519 Old templates can lead to sup elements inside summary
Resolved	phuedx	T176521 data-mw attributes should be stripped from summary before scrubbing parentheticals
Resolved	Jdlrobson	T176522 Intro property incorrectly identified in formatted endpoint
Resolved	Jdlrobson	T176525 Parenthetical: New edge case with nested brackets
Resolved	• bearND	T177007 Should we flatten spans in summary output
Resolved	Jdlrobson	T178125 Metadata (coordinates) is sometimes surfaced as lead intro/summary
Resolved	• Mholloway	T178333 Move RESTBase page summary logic to MCS
Resolved	• Mholloway	T178420 What is a "content namespace" for purposes of the summary 2.0 endpoint?
Resolved	Jdlrobson	T183833 [Bug report] Removing parentheses breaks chemical formulas
Resolved	Jdlrobson	T185050 Run comparison of html extracts again
Resolved	• bearND	T185161 Stripping parentheticals can result in trailing punctuation

Event Timeline

ovasileva created this task.Jun 8 2017, 4:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 4:19 PM

ovasileva added a subtask: T167429: Make enwiki and dewiki fetch previews from the summary-html RESTBase endpoint.Jun 8 2017, 4:20 PM

ovasileva added a project: Wikimedia-Site-requests.

Restricted Application added a subscriber: Dereckson. · View Herald TranscriptJun 8 2017, 4:20 PM

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jun 8 2017, 5:24 PM

On T167429

ovasileva moved this task from Backlog to Next Up on the Page-Previews board.Jul 5 2017, 12:37 PM

Jdlrobson changed the status of subtask T167429: Make enwiki and dewiki fetch previews from the summary-html RESTBase endpoint from Open to Stalled.Jul 11 2017, 5:09 PM

Jdlrobson renamed this task from Switch all projects to summary-html endpoint for page previews to Switch all projects to the new (and yet to be built) summary-html endpoint for page previews.Jul 13 2017, 6:56 PM

Jdlrobson removed a project: TextExtracts.

Unstalling.

Unstalling.

Why? We can't work on this until we have the new endpoint... and we can't do that until T167429 is done (https://phabricator.wikimedia.org/T167433#3352367)

I think I perceive stalled more as stalled due to a blocker/decision, rather than stalled due to work in progress. As in, if it's a subtask of the correct task, the task itself won't be closed until the subtasks are resolved.

Jdlrobson added a parent task: T171871: Text inside the <math> tag is displayed as plain text or correctly with odd spacing on the 'descriptions' of Wikipedia pages on mobile..Aug 4 2017, 1:58 PM

Jdlrobson removed a parent task: T113094: [EPIC] The Page Summary API needs to provide useful content for the majority of articles.Aug 22 2017, 7:03 PM

Jdlrobson added a subtask: T113094: [EPIC] The Page Summary API needs to provide useful content for the majority of articles.

Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Sep 6 2017, 6:36 PM

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.

Jdlrobson added a parent task: T173952: Remove A/B testing instrumentation code.Sep 7 2017, 2:14 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T173952: Remove A/B testing instrumentation code.

• Fjalapeno removed a parent task: T171871: Text inside the <math> tag is displayed as plain text or correctly with odd spacing on the 'descriptions' of Wikipedia pages on mobile..Oct 4 2017, 5:57 PM

@Fjalapeno following up from lead sync. Per https://phabricator.wikimedia.org/T173639#3674008 @Dvorapa and @Vachovec1 have been keen to enable the new endpoint on cs wiki and provide feedback given the current endpoint is badly broken on cswiki. I think through rolling out there we would uncover the majority of bugs (if any) in the service.

Related: I also had reports from @Volker_E that he's been encountering lots of problems on dewiki beta feature and he was wondering what the current timeline was.
(cc @bearND @Mholloway )

Jdlrobson added a subscriber: • Mholloway.Nov 6 2017, 10:00 PM

There are no outstanding patches in MCS for the summary feature at the moment and I did an MCS deploy today. We might want to run the compare script again with the latest changes merged to master.
As far as I understand it, the timeline and how we roll this out is up to @ovasileva. If we can deploy for all wikis at the same time that would be easier for the Services team but I think @Pchelolo said that that is doable.

If we can deploy for all wikis at the same time that would be easier for the Services team but I think @Pchelolo said that that is doable.

Yes and yes. Deploying everywhere is easier, but switching just a couple of domains is doable. Please settle on the decision which path we're going and I'll code it up.

In T167433#3746282, @bearND wrote:

There are no outstanding patches in MCS for the summary feature at the moment and I did an MCS deploy today. We might want to run the compare script again with the latest changes merged to master.
As far as I understand it, the timeline and how we roll this out is up to @ovasileva. If we can deploy for all wikis at the same time that would be easier for the Services team but I think @Pchelolo said that that is doable.

As the change will not affect any current users, I think we can go ahead and deploy everywhere.

As the change will not affect any current users, I think we can go ahead and deploy everywhere.

Not really sure what you mean. MCS deploy will not affect anyone, but RESTBase deploy will instantly switch all the users to the new version. MCS deploy was already done, we're thinking about how to expose that in RESTBase

phuedx mentioned this in T182319: Show HTML summaries on all wikis.Dec 11 2017, 5:32 PM

Jdlrobson mentioned this in T183833: [Bug report] Removing parentheses breaks chemical formulas.Jan 2 2018, 11:08 PM

ovasileva closed this task as a duplicate of T182319: Show HTML summaries on all wikis.Jan 11 2018, 11:22 PM

ovasileva closed this task as a duplicate of T182319: Show HTML summaries on all wikis.

Dvorapa unsubscribed.Mar 2 2018, 3:50 PM

ovasileva closed subtask T113094: [EPIC] The Page Summary API needs to provide useful content for the majority of articles as Resolved.Mar 16 2018, 1:51 PM