In https://gerrit.wikimedia.org/r/#/c/372875/ @bearND pondered whether we should remove superfluous spans from the summary output.
Benefits:
- Simplified HTML
Cons:
- Will this cause rendering issues for math elements or any other HTML?
Description
Description
Details
Details
Event Timeline
Comment Actions
@Jdlrobson @bearND does this mean we need to do investigation on the effects?
(note: currently this would not affect apps as they use the plain text)
Comment Actions
@Jdlrobson @bearND ping
What needs to be done here and who needs to do it?
it isn't clear from the task name/description who is responsible or if this is blocking any other work.
Comment Actions
We need to have a conversation about whether to do this. Next services sync or tech lead sync.
Comment Actions
Since it's more a payload optimization we can lower the priority of this. I don't understand why it was high to begin with.
Comment Actions
If we don't have a strong motivation to do this I'd be inclined to decline or at least mark to "Lowest" to signal we'll accept patches but we won't be actively pursuing this. Payload optimisation is a micro-optimisation and doesn't seem worth the effort right now.
Any issues with that @bearND ?
Comment Actions
Change 403977 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Flatten DOM anchors if no attributes kept
Comment Actions
When creating this patch I was also thinking if we should also keep inline style attributes. Thoughts?
Comment Actions
This is a tricky one. My gut feeling is that yes, we should keep inline style attributes. Consider the sfrac template, used on a bunch of scientific pages:
{{sfrac|1|2}}
yields
<span class="sfrac nowrap" style="display:inline-block; vertical-align:-0.5em; font-size:85%; text-align:center;"> <span style="display:block; line-height:1em; margin:0 0.1em;">1</span> <span class="visualhide">/</span> <span style="display:block; line-height:1em; margin:0 0.1em; border-top:1px solid;">2</span> </span>
None of the above elements, classes, or inline styles is superfluous.
Comment Actions
Change 404496 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Also keep style attributes when flattening elements
Comment Actions
Change 403977 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Flatten DOM anchors if no attributes kept
Comment Actions
Change 404496 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Also keep style attributes when flattening elements