Stripping parentheticals can result in trailing punctuation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 17 2018, 11:29 PM

Description

Observed on the Gal Gadot article

Input:

'<p>Justice League (both 2017). Justice (is forever)!</p>',

Resolves to:
Expected:

'<p>Justice League. Justice!</p>'

Actual:

'<p>Justice League . Justice !</p>'

Details

	Subject	Repo	Branch	Lines +/-
	Summary: cleanup trailing spaces	mediawiki/services/mobileapps	master	+21 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T169242 Develop Page Content Service for Reading Clients
Resolved	None	T177425 Develop General Layer of PCS
Resolved	• Jhernandez	T177426 Develop structured JSON APIs for general consumption
Resolved	• Mholloway	T177431 Develop a Summary JSON API
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	ovasileva	T154635 [EPIC] Deploy page previews to English and German Wikipedia
Resolved	ovasileva	T192622 [EPIC] Page previews post-deploy cleanup
Resolved	Jdlrobson	T173952 Remove A/B testing instrumentation code
Duplicate	None	T167433 Switch all projects to the new (and yet to be built) summary-html endpoint for page previews
Duplicate	None	T167429 Make enwiki and dewiki fetch previews from the summary-html RESTBase endpoint
Resolved	ovasileva	T165018 Page previews can consume new summary-HTML endpoint
Declined	Jdlrobson	T111329 [GOAL] Page previews on mobileweb
Resolved	Jdlrobson	T164010 [EPIC] Strengthen the APIs we provide in reading web maintained extensions
Resolved	ovasileva	T113094 [EPIC] The Page Summary API needs to provide useful content for the majority of articles
Resolved	• bearND	T185161 Stripping parentheticals can result in trailing punctuation

Event Timeline

Jdlrobson created this task.Jan 17 2018, 11:29 PM

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptJan 17 2018, 11:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 404882 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/services/mobileapps@master] WIP: Cleanup trailing punctuation

https://gerrit.wikimedia.org/r/404882

gerritbot added a project: Patch-For-Review.Jan 17 2018, 11:30 PM

Jdlrobson mentioned this in T185050: Run comparison of html extracts again.Jan 17 2018, 11:30 PM

Jdlrobson added a parent task: T113094: [EPIC] The Page Summary API needs to provide useful content for the majority of articles.

• bearND updated the task description. (Show Details)Jan 18 2018, 1:16 AM

• bearND moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Jan 30 2018, 11:59 PM

• bearND edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

• bearND claimed this task.Jan 31 2018, 12:04 AM

• bearND moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Change 404882 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Summary: cleanup trailing spaces

https://gerrit.wikimedia.org/r/404882

• bearND moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jan 31 2018, 9:06 PM