Description

On Special:Undelete, there are two buttons for preview and diff. These buttons do not have any space between them and the whole page does not use OOUI, like all other UI parts on this special page.

Acceptance criteria:

The funtionality of the page has not changed
The "View difference" page of Special:Undelete is converted to use OOUI.

The code for this special page is at https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/SpecialUndelete.php and the buttons are defined in showRevision on lines 473 to 486.

Details

	Subject	Repo	Branch	Lines +/-
	Replace some Special:Undelete button with OOUI ones	mediawiki/core	master	+20 -15

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open	None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
Open	None	T107037 Convert all MW core special pages to OOUI
Resolved	Albert221	T180207 Convert "Show diff" part of Special:Undelete to OOUI

Event Timeline

Nirmos created this task.Nov 10 2017, 10:39 AM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptNov 10 2017, 10:39 AM

Nirmos triaged this task as Lowest priority.Nov 10 2017, 10:39 AM

I will mentor this for GCI/17

Imported as: https://codein.withgoogle.com/dashboard/tasks/5668801058177024/

However, the whole UI on that page is not really aligned with the other UI elements of the Special:Undelete page, which uses OOUI. So, what do you think of using this task (which can still be a GCI task I think), to convert the interface to use OOUI. That should be pretty simple I think, too :)

I think that's a good Idea

I also updated the GCI task :)

Screenshot (using MediaWiki's "Vector" skin):

Screenshot from 2017-11-28 20-53-33.png (501×1 px, 38 KB)

• Prtksxna subscribed.Dec 4 2017, 5:28 AM

I replaced these two buttons and the textarea to OOUI, I'm pushing it to Gerrit. If something's wrong, tell me!

Change 395037 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/core@master] Replace some Special:Undelete button with OOUI ones

https://gerrit.wikimedia.org/r/395037

gerritbot added a project: Patch-For-Review.Dec 4 2017, 4:44 PM

Update:

Framawiki subscribed.Dec 4 2017, 6:14 PM

Change 395037 merged by jenkins-bot:
[mediawiki/core@master] Replace some Special:Undelete button with OOUI ones

https://gerrit.wikimedia.org/r/395037

Albert221 closed this task as Resolved.Dec 4 2017, 6:27 PM

Albert221 claimed this task.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Dec 4 2017, 7:00 PM

Volker_E removed a project: Patch-For-Review.Dec 5 2017, 2:54 AM

Bawolff mentioned this in T182426: OOUI MultilineTextInputWidget textboxes are grey in Monobook (Apex) but not in Vector (WikimediaUI theme).Dec 9 2017, 1:35 AM

Was partly reverted in T182398: Special:Undelete contains egregious white space after OOUI update

	F11053989: Screenshot from 2017-11-28 20-53-33.png
	Nov 28 2017, 7:55 PM

	F11178405: image.png
	Dec 4 2017, 5:22 PM

	F11177835: image.png
	Dec 4 2017, 4:42 PM

Convert "Show diff" part of Special:Undelete to OOUIClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Convert "Show diff" part of Special:Undelete to OOUI
Closed, ResolvedPublic
Actions

Related Objects
Search...