| Bawolff | |
| Dec 8 2017, 2:22 PM |
| F11705862: image.png | |
| Dec 8 2017, 10:56 PM |
| F11706171: image.png | |
| Dec 8 2017, 10:56 PM |
| F11702150: image.png | |
| Dec 8 2017, 9:23 PM |
| F11702156: image.png | |
| Dec 8 2017, 9:23 PM |
Mentioned by Vito on irc while complaining about changes to Special:Undelete (T182398)
On MonoBook (Apex theme), a read-only TextInputWidget has the text marked grey to mark the field read-only. However this is not true on other skins (Tested Vector and Timeless).
This is really odd to me. It may make sense to make such widgets grey to mark them read-only (Doesn't really on Special:Undelete, but I could imagine it would in other cases). However it should be consistent across skins.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Apex theme: Align readonly TextInputWidget across themes | oojs/ui | master | +10 -9 |
Change 396430 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/core@master] Revert replacing textarea in Special:Undelete with OOUI
To clarify, this is about read-only text fields, not disabled text fields; and it affects single-line fields too. In Apex theme (MonoBook skin), the text is greyed out slightly. In WikimediaUI theme (Vector skin), the background is grey instead. Screenshots from the demo (after running widget.setReadOnly(1) in the console for each field):
@Bawolff Just to clarify what is acceptance criteria here from your perspective?
Having such treatment?
| WikimediaUI | Apex |
|---|---|
 |  |
Also, the revert commit message mentions a completely different reason and I don't unterstand why it was accepted without clearer communication about what is meant to break (max-width)?
Note, that vito made the original complaint, so he might be a better person to ask for acceptance criteria.
My issue was that the behaviour was rather inconsistent between themes which was surprising. It doesnt matter to me how its resolved so long as its not surprisingly different between skins. What is in the picture looks fine to me (note: the grey background is light enough grey that i didnt notice it in vector until it was pointed out to me)
The revert was primarily for a different bug - T182398. There was a recent change to make Special:Undelete use OOUI (T180207). Some Wikipedians strongly disliked the max-width that gets set on the multiline text fields in the context of that page (See the bug, and also the thread on WP:VPT). As a result of user feedback we're partially reverting the change.
The original change was intended to be non-controversial. If we intentionally wanted to change the page in a controversial way, that would be fine if it was planned as such from the get-go and accompined by the appropriate outreach, but definitely not as part of GCI.
Change 396556 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Apex theme: Align readonly TextInputWidget across themes
Change 396556 merged by jenkins-bot:
[oojs/ui@master] Apex theme: Align readonly TextInputWidget across themes