Page MenuHomePhabricator
Create Task
Maniphest T182217

Deploy `specialpages` feature branch (promote new Special:MobileOptions, fontchanger etc)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Dec 6 2017, 5:44 PM
Tags
Referenced Files
F13780580: image.png
Feb 15 2018, 10:35 PM
F13780573: image.png
Feb 15 2018, 10:35 PM
F13780576: image.png
Feb 15 2018, 10:35 PM
F13780578: image.png
Feb 15 2018, 10:35 PM
F13780569: image.png
Feb 15 2018, 10:35 PM
F13780583: image.png
Feb 15 2018, 10:35 PM
Subscribers
ABorbaWMF
Aklapper
Etonkovidova
gerritbot
Jdlrobson
MBinder_WMF
• Nirzar
View All 10 Subscribers

Description

Deploy the settings feature branch everywhere

Pre-checklist

@phuedx: T184742: QA of 'specialpages' feature branch (settings page) is a direct subtask (blocker).

Acceptance criteria

  • Merge specialpages branch in Minerva to master.
  • Merge specialpages branch in MobileFrontend to master.
  • Un-deploying is simple (revert a single commit instead of multiple).
  • Merge as early in the week as possible so translators can make updates before it goes to prod (This should ideally be merged on the 5th)
  • Link feedback page to https://www.mediawiki.org/wiki/Reading/Web/Settings

Testing criteria

Post deploy/sign off

Details

SubjectRepoBranchLines +/-
Merge remote-tracking branch 'gerrit/specialpages' into T182217mediawiki/skins/MinervaNeuemaster+0 -11
Deploy the new specialpages branch to mastermediawiki/extensions/MobileFrontendmaster+875 -557
Configure settings feedback linkoperations/mediawiki-configmaster+4 -0
Prepare for breaking change to MobileContextmediawiki/skins/MinervaNeuemaster+7 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson renamed this task from Deploy `specialpages` feature branch to Deploy `specialpages` feature branch (promote new Special:MobileOptions, fontchanger etc).Dec 6 2017, 5:49 PM
Jdlrobson updated the task description. (Show Details)
• bmansurov moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Dec 6 2017, 7:46 PM
• bmansurov subscribed.

The task looks clear.

ovasileva triaged this task as Medium priority.Dec 7 2017, 3:35 PM
ovasileva added a project: Mobile-Web-Settings.Dec 8 2017, 1:24 PM
Jdlrobson updated the task description. (Show Details)Dec 11 2017, 6:17 PM
Jdlrobson changed the task status from Open to Stalled.Dec 21 2017, 4:13 AM
Jdlrobson added a subtask: T182362: Show unconfigurable settings in mobile beta.
Jdlrobson subscribed.

Stalled on T182362

• Nirzar closed subtask T109364: Promote fontchanger to stable (in feature branch) as Resolved.Dec 21 2017, 7:46 PM
phuedx added a subtask: T183493: Remove 'Expand all section' toggle on tablet and desktop mode.Jan 3 2018, 5:36 PM
• Niedzielski updated the task description. (Show Details)Jan 3 2018, 5:44 PM
• Niedzielski updated the task description. (Show Details)
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jan 3 2018, 6:16 PM
Jdlrobson changed the task status from Stalled to Open.Jan 3 2018, 6:18 PM
Jdlrobson set the point value for this task to 2.

We talked about this today and concluded it was relatively simple. Given we're working with branches it's not a straightforward 1 point config change.

• bmansurov unsubscribed.Jan 3 2018, 6:36 PM
• Nirzar subscribed.Jan 3 2018, 9:52 PM

https://phabricator.wikimedia.org/T182362 < this is still a blocker for deploying this branch

• Nirzar closed subtask T183493: Remove 'Expand all section' toggle on tablet and desktop mode as Resolved.Jan 7 2018, 9:44 PM
Jdlrobson added a project: Wikimedia-Site-requests.Jan 9 2018, 7:34 PM
Jdlrobson updated the task description. (Show Details)
ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Jan 10 2018, 6:35 PM
ovasileva updated the task description. (Show Details)
Jdlrobson moved this task from To Do to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.Jan 10 2018, 6:37 PM

This is blocked on a feedback link from Olga, T182362 and QA of the feature.

MBinder_WMF subscribed.Jan 10 2018, 6:39 PM

@ovasileva Do we want to notify CLs about this? Just asking because we've talked about that as a part of the new template for deploys. Maybe User-notice ?

Jdlrobson moved this task from Upcoming to 2017-18 Q2 on the Web-Team-Backlog board.Jan 10 2018, 6:43 PM
ovasileva mentioned this in T184742: QA of 'specialpages' feature branch (settings page).Jan 11 2018, 4:49 PM
ovasileva closed subtask T182362: Show unconfigurable settings in mobile beta as Resolved.Jan 12 2018, 12:25 AM
Jdlrobson updated the task description. (Show Details)Jan 12 2018, 12:47 AM
phuedx updated the task description. (Show Details)Jan 12 2018, 7:56 AM
phuedx subscribed.
Jdlrobson updated the task description. (Show Details)Jan 12 2018, 7:56 PM
ovasileva moved this task from 2017-18 Q2 to 2017-18 Q3 on the Web-Team-Backlog board.Jan 17 2018, 6:44 PM
ovasileva updated the task description. (Show Details)Jan 22 2018, 9:03 PM
Jdlrobson merged a task: T186148: [betalabs] Console error 'MobileWebMainMenuClickTracking' when go to Special pages.Jan 31 2018, 9:24 PM
Jdlrobson added a subscriber: Etonkovidova.
MuhammadShuaib moved this task from Backlog to Working on on the Wikimedia-Site-requests board.Feb 4 2018, 12:13 PM
ovasileva closed subtask T184742: QA of 'specialpages' feature branch (settings page) as Resolved.Feb 5 2018, 2:52 PM
Jdlrobson updated the task description. (Show Details)Feb 5 2018, 6:18 PM
Jdlrobson moved this task from Blocked on Others to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

Note: this should go out on next week's train.

gerritbot subscribed.Feb 5 2018, 8:09 PM

Change 408354 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Configure settings feedback link

https://gerrit.wikimedia.org/r/408354

gerritbot added a project: Patch-For-Review.Feb 5 2018, 8:09 PM
gerritbot added a comment.Feb 5 2018, 8:12 PM

Change 408357 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Deploy the new specialpages branch to master

https://gerrit.wikimedia.org/r/408357

Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Feb 5 2018, 8:16 PM
gerritbot added a comment.Feb 5 2018, 9:19 PM

Change 408384 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Prepare for breaking change to MobileContext

https://gerrit.wikimedia.org/r/408384

gerritbot added a comment.Feb 5 2018, 9:19 PM

Change 408385 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Merge remote-tracking branch 'gerrit/specialpages' into T182217

https://gerrit.wikimedia.org/r/408385

gerritbot added a comment.Feb 5 2018, 9:49 PM

Change 408384 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Prepare for breaking change to MobileContext

https://gerrit.wikimedia.org/r/408384

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 5 2018, 10:00 PM
gerritbot added a comment.Feb 6 2018, 12:09 AM

Change 408354 merged by jenkins-bot:
[operations/mediawiki-config@master] Configure settings feedback link

https://gerrit.wikimedia.org/r/408354

Stashbot subscribed.Feb 6 2018, 12:14 AM

Mentioned in SAL (#wikimedia-operations) [2018-02-06T00:14:24Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:408354|Configure settings feedback link]] T182217 (duration: 00m 56s)

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Feb 6 2018, 12:27 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson claimed this task.Feb 6 2018, 12:29 AM

Okay, we can merge the branches now as soon as the 1.31.0-wmf.20 branch is cut (e.g. https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/tree/wmf/1.31.0-wmf.20 exists!)

phuedx added a comment.Feb 6 2018, 9:56 AM

Aside: The $wgMFBetaFeedbackLink configuration variable isn't documented on https://www.mediawiki.org/wiki/Extension:MobileFrontend.

Jdlrobson added a comment.Feb 6 2018, 6:12 PM

Stephen and I will do this today.

Jdlrobson added a comment.Feb 6 2018, 6:45 PM
In T182217#3948485, @phuedx wrote:

Aside: The $wgMFBetaFeedbackLink configuration variable isn't documented on https://www.mediawiki.org/wiki/Extension:MobileFrontend.

But it is documented in README.md which is linked to here: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuration (we dont document config on wiki any more)

phuedx added a comment.Feb 6 2018, 7:26 PM

👍

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Feb 6 2018, 9:19 PM
gerritbot added a comment.Feb 6 2018, 9:21 PM

Change 408357 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Deploy the new specialpages branch to master

https://gerrit.wikimedia.org/r/408357

gerritbot added a comment.Feb 6 2018, 10:19 PM

Change 408385 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Merge remote-tracking branch 'gerrit/specialpages' into T182217

https://gerrit.wikimedia.org/r/408385

Jdlrobson updated the task description. (Show Details)Feb 6 2018, 10:33 PM
Jdlrobson updated the task description. (Show Details)
• Nirzar added a comment.Feb 6 2018, 10:44 PM

@ovasileva
the AC says link feedback button to https://www.mediawiki.org/wiki/Reading/Web/Settings

I thought we are gonna link it to the flow page?

it's not obvious how to give feedback if I land on wiki page :(

Jdlrobson reassigned this task from Jdlrobson to ABorbaWMF.Feb 6 2018, 10:49 PM
Jdlrobson added a subscriber: ABorbaWMF.

The branch has been merged into master https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileOptions and will roll out on next weeks train (13th-15th Feb)
@ABorbaWMF this will need a general QA to check this worked correctly.

@Nirzar I assumed talk page was needed so when I swatted I linked to talk. That said for some reason it's not showing up on BC. Will investigate.

• Nirzar added a comment.Feb 6 2018, 10:51 PM

oh cool! thanks!

Jdlrobson added a comment.Feb 6 2018, 10:56 PM

Okay it's working. It just only shows in beta. It points to flow board.

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)); removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 6 2018, 11:00 PM
ABorbaWMF added a comment.Feb 8 2018, 7:07 PM

I neglected to add comments, apologies...

I did a bunch of testing on this related to this ticket and a few others. This is working in Beta right now. I can also take a look at production once it is deployed there next week.

ovasileva updated the task description. (Show Details)Feb 13 2018, 4:12 PM
ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Feb 15 2018, 10:35 PM

Looks good to me on production.

image.png (1×720 px, 361 KB)

image.png (984×540 px, 199 KB)

image.png (667×376 px, 99 KB)

image.png (960×540 px, 324 KB)

image.png (984×540 px, 183 KB)

image.png (1×720 px, 380 KB)

phuedx reassigned this task from ABorbaWMF to ovasileva.Feb 16 2018, 10:10 AM
ovasileva closed this task as Resolved.Feb 16 2018, 10:55 AM
ovasileva updated the task description. (Show Details)

Tested and it's working! @ABorbaWMF - a question. It seems the mockups you pasted don't match this task - do they belong in another task?

ABorbaWMF added a comment.Feb 16 2018, 4:10 PM

Nope just different font sizes and expanded sections on different browsers

thiemowmde mentioned this in T188182: Regression: Wikidata descriptions are not showing on various wikis.Mar 5 2018, 7:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL