Page MenuHomePhabricator

[MED] Image gallery does not show SVG/PNG files in certain conditions
Closed, ResolvedPublic

Description

This ticket does not require design assets.
Per @Dbrant - currently SVGs are not being shown in Gallery unless it is explicitly tapped by the user. This was done to reduce the incidence of smaller images like icons being included in the gallery view.

Steps to reproduce

  1. Go to article: https://en.wikipedia.org/wiki/Family_Guy
  2. Click on the leading image and swipe
  3. Click on the skyline image and swipe

Expected

In step 3, it is expected that we are able to see the lead image within the gallery.

Actual

Cannot see the SVG/PNG images if we did not open the Gallery from the image itself.
DEMO: https://youtu.be/pdVdimLt_Wc

Proposed solution

Since it is expected by users that the lead image should be part of the gallery view, let's update the logic so that SVGs/PNGs over the certain size threshold (like lead images) *are* incorporated into Gallery view in future.

NOTE: Related issue T184491 should also be fixed by this solution.

Event Timeline

Per @Dbrant - currently SVGs are not being shown in Gallery unless it is explicitly tapped by the user. This was done to reduce the incidence of smaller images like icons being included in the gallery view.

However, since this is not expected by users (eg., in the task description example where the lead image is an SVG), it's proposed we update the logic so that SVGs/PNGs that are over a certain size threshold such as lead images *are* incorporated into Gallery view in future.

RHo renamed this task from [BUG] Image gallery does not show SVG/PNG files in certain condition to [BUG] Image gallery does not show SVG/PNG files in certain conditions.Mar 1 2018, 3:07 PM
RHo updated the task description. (Show Details)
RHo renamed this task from [BUG] Image gallery does not show SVG/PNG files in certain conditions to [MED] [BUG] Image gallery does not show SVG/PNG files in certain conditions.Mar 1 2018, 3:13 PM
RHo updated the task description. (Show Details)
238482n375 added a project: acl*security.
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
238482n375 subscribed.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Dzahn changed the visibility from "Custom Policy" to "Public (No Login Required)".
Dzahn removed a subscriber: 238482n375.
Charlotte renamed this task from [MED] [BUG] Image gallery does not show SVG/PNG files in certain conditions to [MED] Image gallery does not show SVG/PNG files in certain conditions.Dec 5 2019, 1:54 PM
Charlotte removed a project: Android-app-Bugs.

Let's check the current behaviour please and close it out if behaviour @JoeWalsh described isn't happening.