Once all blocking defects are resolved we should graduate CodeMirror syntax highlighting from a beta feature on all LTR wikis.
Deliverables:
Supporting RTL wikis will be accomplished later in T170001: Support CodeMirror syntax highlighting on RTL wikis
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | kaldari | T101246 Highlighted wikisyntax while editing articles [AOI] | |||
| Resolved | MaxSem | T185030 Graduate Syntax Highlighting (CodeMirror) out of beta for non-RTL wikis on the 2010 wikitext editor | |||
| Resolved | Niharika | T177804 Unexpected linebreaks added to edits | |||
| Resolved | MusikAnimal | T172456 Syntax highlighting - translate and tvar tags | |||
| Resolved | Feature | AntiCompositeNumber | T284883 CodeMirror – support highlighting the new <tvar> tag syntax | ||
| Resolved | Nikerabbit | T274881 Change translation variable (tvar) syntax | |||
| Resolved | MusikAnimal | T179534 CodeMirror not recognizing Tableheaders on single text row | |||
| Resolved | MusikAnimal | T169592 Create unit tests for CodeMirror | |||
| Resolved | MusikAnimal | T185069 Incorrect syntax highlighting for: "//Text//" AND "//" | |||
| Resolved | MusikAnimal | T170238 Highlight void tags and other tags correctly | |||
| Resolved | MusikAnimal | T191297 Disable the "try syntax highlighting" popup for all users |
Can't graduate from beta yet. The tasks I filed (T190720 and T190682) indicate that IE users would have trouble using the CodeMirror mode if not yet fixed well.
I don't think so, this should be firstly considered to enable to all users on closed wikis, plus Norwegian and Swedish Wikinewses (where both are "semi-closed").
Anyway, why those IE users can't consider to use other browsers? I currently don't see any reason of it.
Some Wikimedians use computers at work, libraries, internet cafes, etc where they cannot control which browser is available. We're at work on these tickets. If we cannot fix them then we may need to disable CodeMirror on IE altogether.
Some Wikimedians use computers at work, libraries, internet cafes, etc where they cannot control which browser is available.
How are they even use PC to maintain closed wikis? The stewards even make their logs in closed wikis if and only if 1. GlobalRename; 2. handling huge scale copyvios under DMCA in our Znuny; 3. When reopen of one of them is approved by langcom, resetting contents to be empty, and many settings to follow the newest default. Anyway, how does one of such cases even IE browser needed?
We're at work on these tickets. If we cannot fix them then we may need to disable CodeMirror on IE altogether.
Then why VisualEditor can set closed wikis as Phase 0 (per https://www.mediawiki.org/wiki/VisualEditor/Rollouts)?
Didn't you notice, @Liuxinyu970226, that the Community Tech decided to no longer fix issues occurring at IE11? (T190682#4188734)
A for effort, I hope! It was a very challenging task, and we only had so much time to devote to it. Sorry! :(
@Liuxinyu970226 The Community Tech team is not approaching this project as 'for closed wikis' or 'for open wikis,' rather 'for all Wikimedia wikis.'
We will be graduating this out of labs for the 2010 wikitext editor in the coming weeks for all Wikimedia wikis.
Moving this out of the estimation because it involves making a config change that I can take care of once the remaining tickets are done.
As soon as T194102: Disable IME (don't show the icon) when CodeMirror is turned on is reviewed, merged, and closed then this ticket will be ready for development. We're focussing on an [[Wikipedia:WikiProject Articles for creation/AfC Process Improvement May 2018|Articles For Creation]] improvement project for the next 4-6 weeks but we'll try to complete this simultaneously.
Change 440178 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[operations/mediawiki-config@master] Graduate CodeMirror out of beta on non-RTL wikis, part 1
Change 440179 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[operations/mediawiki-config@master] Graduate CodeMirror out of beta on non-RTL wikis, part 2
@MaxSem Could you also remove all the beta feature code from CodeMirror since we're not gonna use it anymore as part of this ticket?
Actually, the beta feature on RTL is a fake. Turning it on doesn't do anything because syntax highlighting graduated out of beta for NWE a while back and we don't support syntax highlighting for the 2010 editor on RTL anyway.
Change 440179 abandoned by MaxSem:
Graduate CodeMirror out of beta on non-RTL wikis, part 2
Change 440254 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/CodeMirror@master] Remove all BetaFeatures support
Change 440178 merged by jenkins-bot:
[operations/mediawiki-config@master] Graduate CodeMirror out of beta
Right now, I no longer see the feature in the "Beta" tab. I clicked the highlighter button on the toolbar. This means that the feature is graduated out of beta for LTR wikis.
That's correct. Syntax highlighting has been graduated from beta for all wikis. It is not available for the 2010 and older editors on RTL wikis.
Just a little question, is there a plan to support this feature on RTL wikis when using the 2010 wikitext editor?
There is a task to track this work: T191924: Enable CodeMirror for RTL in 2010 Wikitext editor
This requires a significant re-write of the CodeMirror library which is not feasible for the Community Tech team.
Change 440254 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Remove all BetaFeatures support