Page MenuHomePhabricator

Allow inline editing of gallery captions and gallery image captions
Closed, ResolvedPublic

Description

Allow inline editing of gallery captions and gallery image captions, in the same manner as we allow editing image captions.

image.png (519×1 px, 270 KB)

image.png (225×1 px, 73 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The problem here is probably going to be not the inline editing, but rather preventing the user from entering funny stuff into the gallery captions, like tables or other galleries. @Esanders says we don't really have a way to do that, but he might be working on one?

The problem here is probably going to be not the inline editing, but rather preventing the user from entering funny stuff into the gallery captions, like tables or other galleries. @Esanders says we don't really have a way to do that, but he might be working on one?

We enabled caption editing for block image captions without disabling adding lists (which aren't supported by Parsoid) and it hasn't seemed to be a problem. In an ideal world VE would prevent this, or Parsoid/wikitext would be able to handle it, but it seems to be rare enough that I don't think it needs to be a blocker.

Change 888313 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Gallery: Make ve.ce.Gallery(Image)CaptionNode active (editable)

https://gerrit.wikimedia.org/r/888313

This is currently blocked on T329662, which should be resolved soon.

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/bd25812a96/w/

Change 888313 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Gallery: Make ve.ce.Gallery(Image)CaptionNode active (editable)

https://gerrit.wikimedia.org/r/888313

Thanks for adding to Tech News!
IIUC from this comment above: "ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03)."
the feature will be riding the deployment train next week.
Hence I've moved it in Tech News into the "Changes this week" section.
Please let me know if I'm wrong, or bump it into next week's edition if that's needed.

Ah, I missed an email. I will bump it to next week's edition. :)

EAkinloose claimed this task.
EAkinloose removed a project: Editing QA.
EAkinloose subscribed.

✅ Allow inline editing of gallery captions and gallery image captions.

See https://photos.app.goo.gl/Ln6atP7vogvQnW6eA

Screenshot 2023-04-04 at 18.00.00.png (726×1 px, 58 KB)