| Etonkovidova | |
| Apr 3 2018, 10:30 PM |
| F16646654: Screen Shot 2018-04-03 at 3.31.52 PM.png | |
| Apr 3 2018, 10:33 PM |
| F16646382: Screen Shot 2018-04-03 at 3.25.30 PM.png | |
| Apr 3 2018, 10:30 PM |
On testwiki (and betlabs) Recent Changes page (and other pages with the filters) is missing the bookmark icon - oo-ui-iconElement-icon oo-ui-icon-unClip:
UBN because filters cannot be saved, although the functionality is in place: the place for the icon can be clicked.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Revert "RCFilters: Rename deprecated 'unClip' icon to 'bookmark'" | mediawiki/core | wmf/1.31.0-wmf.28 | +4 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | SBisson | T162675 'Integrated filters'—add all RC Page filters into the new UI along with selected new functions | |||
| Open | None | T168826 Styling adjustments for the New filters for edit review | |||
| Resolved | Etonkovidova | T191366 [regression - wmf.28] The bookmark icon for Saved filters is missing |
Caused by c103e8e62aaedf240bb83ca6858568a720140752 I think, but I don't understand why it's not loading.
https://doc.wikimedia.org/oojs-ui/master/demos/?page=icons&theme=wikimediaui&direction=ltr&platform=desktop lists the bookmark icon in the "moderation" group, but https://test.wikipedia.org/w/load.php?modules=oojs-ui.styles.icons-moderation&only=styles&debug=false does not contain the word bookmark
Change 424021 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@wmf/1.31.0-wmf.28] Revert "RCFilters: Rename deprecated 'unClip' icon to 'bookmark'"
Change 424021 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.28] Revert "RCFilters: Rename deprecated 'unClip' icon to 'bookmark'"
Mentioned in SAL (#wikimedia-operations) [2018-04-04T23:36:45Z] <catrope@tin> Synchronized php-1.31.0-wmf.28/resources/src/mediawiki.rcfilters/: Fix missing bookmark icon (T191366) (duration: 01m 16s)