Page MenuHomePhabricator
Create Task
Maniphest T197814

Update the article view's top and bottom toolbar elements (prototype 1)
Closed, ResolvedPublic4 Estimated Story Points
Actions

Assigned To
cooltey
Authored By
RHo
Jun 20 2018, 5:00 PM
Tags
Referenced Files
F23692446: Screenshot_1531433105.png
Jul 12 2018, 10:06 PM
F23664333: icon-W back.svg
Jul 12 2018, 7:46 AM
F23664307: ic_icon_w_back.xml
Jul 12 2018, 7:46 AM
F22411252: image.png
Jun 20 2018, 5:02 PM
F22411327: image.png
Jun 20 2018, 5:02 PM
F22411348: image.png
Jun 20 2018, 5:02 PM
F22411284: image.png
Jun 20 2018, 5:02 PM
Subscribers
Aklapper
cmadeo
gerritbot
RHo

Description

Subtask from the Article Queue prototype covering:
Top app bar:

  • Replace the "x" close icon with a bespoke "<W" icon on the top left which upon tapping minimizes the tab stack into the floating article queue element, and returns the user to the Explore Feed.
  • Update the overflow actions to match mocks
image.png (640×360 px, 79 KB)
image.png (640×360 px, 93 KB)

Bottom toolbar:

  • Bottom article toolbar updated so that all actions except ToC are aligned left with 24dp between each icon
  • Move Font and theme changer from overflow actions to bottom article toolbar
  • On scrolling down, app bar and and bottom article action bar animate off the screen
image.png (640×360 px, 203 KB)
Scrolling animates elements off
image.png (640×360 px, 132 KB)

Zeplin: https://app.zeplin.io/project/57a120b91998d8977642a238?seid=5b2152c94e9d9b4e0af911ff
Invision: https://wikimedia.invisionapp.com/public/prototype/sji0b12et0051rw018db4em1w/b2ee8aad

Details

SubjectRepoBranchLines +/-
Update the article view's top and bottom toolbar elementsapps/android/wikipediaprototype_floating_queue+464 -153
Customize query in gerrit

Related Objects
Search...

Event Timeline

RHo created this task.Jun 20 2018, 5:00 PM
• Charlotte set the point value for this task to 2.Jun 20 2018, 5:01 PM
• Charlotte edited projects, added Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.
RHo removed the point value for this task.Jun 20 2018, 5:02 PM
RHo updated the task description. (Show Details)
RHo mentioned this in T195335: Create a prototype to test an "Article Queue" app navigation concept.
• Vvjjkkii renamed this task from Update the article view's top and bottom toolbar elements to hkaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii removed a subscriber: Aklapper.
Sharvaniharan renamed this task from hkaaaaaaaa to Update the article view's top and bottom toolbar elements.Jul 1 2018, 5:40 AM
Sharvaniharan lowered the priority of this task from High to Medium.
Sharvaniharan updated the task description. (Show Details)
Sharvaniharan removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Sharvaniharan added a subscriber: Aklapper.
• Charlotte moved this task from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Jul 10 2018, 4:20 PM
• Charlotte renamed this task from Update the article view's top and bottom toolbar elements to Update the article view's top and bottom toolbar elements (prototype 1).Jul 10 2018, 4:22 PM
• Charlotte set the point value for this task to 4.Jul 10 2018, 4:26 PM
cooltey claimed this task.Jul 10 2018, 11:42 PM
cooltey moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
cooltey updated the task description. (Show Details)Jul 11 2018, 10:28 PM
gerritbot subscribed.Jul 12 2018, 12:32 AM

Change 445330 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@prototype_floating_queue] [WIP] Update the article view's top and bottom toolbar elements

https://gerrit.wikimedia.org/r/445330

gerritbot added a project: Patch-For-Review.Jul 12 2018, 12:32 AM
cooltey added a comment.Jul 12 2018, 12:37 AM

Hi @RHo

Could you please provide the "<W" icon? It would be much easier for me to replace the "x" close icon with one single icon. Thank you!

RHo added a comment.Jul 12 2018, 7:46 AM

yes of course @cooltey, should have provided earlier!

Here's the SVG and Drawable:

icon-W back.svg1 KBDownload

ic_icon_w_back.xml1 KBDownload

cooltey added a comment.Jul 12 2018, 3:49 PM

@RHo Thanks!

cooltey added a comment.Jul 12 2018, 10:06 PM

Hi @RHo

How does the new design handle the Content issues and Similar pages options that were in the overflow menu?

Screenshot_1531433105.png (1×1 px, 440 KB)

cooltey moved this task from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Jul 13 2018, 11:36 PM
cooltey mentioned this in T197808: Update the article view in the Explicit reading mode" prototype.Jul 17 2018, 12:35 AM
gerritbot added a comment.Sep 13 2018, 10:50 PM

Change 445330 abandoned by Cooltey:
Update the article view's top and bottom toolbar elements

Reason:
Move to master branch

https://gerrit.wikimedia.org/r/445330

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 13 2018, 10:50 PM
Dbrant moved this task from Blocked/Waiting to Design signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Sep 27 2018, 3:13 PM
cmadeo moved this task from Design signoff to Ready for signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Oct 30 2018, 2:53 PM
cmadeo subscribed.

Looks good! Thanks @cooltey!

Dbrant closed this task as Resolved.Nov 1 2018, 5:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL