Page MenuHomePhabricator
Create Task
Maniphest T201995

Travis CI for wikibase-docker is blocked by hadolint Linting failure
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

As an Developer I want to be able to merge patches in the wikibase-docker repository in order to continue development

Problem (as reported)

wikibase-docker builds are currently not passing because the linting is failing see: https://travis-ci.org/wmde/wikibase-docker/jobs/414313694

To fix this we can either:

Impact and Priority

This stops the CI running for the wikibase-docker repo and thus stops the CI for all images.
As a result changes to the images can not really be made (and have CI run) without this being fixed, thus this should be a considered a blocker for all tasks in Wikibase Release Strategy

Task

Pin hadolint versions in the same way that we pin php code sniffer and other linters.

We should either pin this to the version that we were last using, details of which can probably be extracted from T201995#4504532
OR we should fix the current linting issues and use a the alternate / name tag that is currently also used as "latest".

Acceptance criteria:

  • The version of hadolint should be pinned for wikibase-docker repo in travis
  • The CI on travis for linting should pass

Tech details / pointers

Linting makes up one of the 2 prebuild travis jobs https://github.com/wmde/wikibase-docker/blob/master/.travis.yml#L25
Linters are run over each image using https://github.com/wmde/wikibase-docker/blob/master/.travis/run-linters.sh
Each image is linted by hadolint indivudally https://github.com/wmde/wikibase-docker/blob/master/.travis/run-docker-linter.sh#L5
The latest version of hadolint is pulled at https://github.com/wmde/wikibase-docker/blob/master/.travis/run-linters.sh#L3 and used at https://github.com/wmde/wikibase-docker/blob/master/.travis/run-docker-linter.sh#L5
In order to use a pinned version, a tag should be added to both locations.

Related Objects

Event Timeline

Tarrow created this task.Aug 15 2018, 10:18 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 15 2018, 10:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore subscribed.Aug 15 2018, 10:20 AM
Addshore added a comment.Aug 15 2018, 10:24 AM

Whether or not we should pin the hadolint version is up for debate.

That sounds like the best idea right now!

Addshore added a comment.Aug 15 2018, 10:29 AM

We will have to figure out which version last passed.
The last travis job on master to pass was https://travis-ci.org/wmde/wikibase-docker/jobs/390772356

$ bash ./.travis/run-linters.sh
Using default tag: latest
latest: Pulling from hadolint/hadolint
c259428136eb: Pulling fs layer
c259428136eb: Verifying Checksum
c259428136eb: Download complete
c259428136eb: Pull complete
Digest: sha256:28249f1e059f230b668f765054fc184e8ff4dba1371f67c2d868f6a707bcdd51
Status: Downloaded newer image for hadolint/hadolint:latest
Addshore triaged this task as High priority.Aug 18 2018, 12:56 PM
Addshore updated the task description. (Show Details)
Addshore updated the task description. (Show Details)
Addshore moved this task from incoming to ready to go on the Wikidata board.
Addshore renamed this task from Travis CI is blocked by Linting Failure to Travis CI for wikibase-docker is blocked by hadolint Linting failure.Aug 18 2018, 12:59 PM
Addshore updated the task description. (Show Details)
Addshore updated the task description. (Show Details)
Addshore updated the task description. (Show Details)Aug 18 2018, 1:13 PM
Addshore added a project: Story.
Addshore added a project: [DEPRECATED] wdwb-tech.Aug 18 2018, 1:28 PM
Addshore moved this task from Inbox to Goals on the [DEPRECATED] wdwb-tech board.
Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Aug 28 2018, 10:30 AM
Addshore set the point value for this task to 3.Aug 28 2018, 10:35 AM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Addshore moved this task from Ready to estimate to In Progress on the Wikidata-Campsite board.
Addshore claimed this task.Aug 30 2018, 10:25 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptAug 30 2018, 10:25 AM
Addshore added a comment.Aug 30 2018, 2:16 PM

Discovered a couple of things blocking us from merging the hadolint patch only, so now also fixing the rest of CI, including T203162: wikibase/javascript-api composer package is not installable (mainly due to a repo move)

Addshore closed this task as Resolved.Sep 7 2018, 8:29 AM
Addshore moved this task from Bugs to Done on the Wikibase-Docker-2017+ board.
Addshore moved this task from In Progress to Done on the Wikidata-Campsite board.
Addshore moved this task from Doing to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Sep 20 2018, 1:11 PM
Addshore removed a project: Wikidata-Campsite.Nov 1 2018, 11:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL