API query for userprops not working on group0 wikis (maybe because comment migration read-new)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Quiddity
	Dec 2 2018, 4:51 AM

Description

Since this week's train, on testwiki and officewiki (only?), tools no longer seem able to get userprops for "editcount" or "groups" etc with the API. This means that the feature is broken to see a user's editcount or local user-groups within NavPopups and with the UserInfo.js script.

Did something change? Or is there a schema change (or something) that needs to be nudged for those wikis?

E.g. (not working)

vs (both working)

(it works fine on other wikis I tested, including enwiki, collabwiki, test2wiki)

Details

Subject	Repo	Branch	Lines +/-
API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo	mediawiki/core	REL1_32	+16 -16
API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo	mediawiki/core	master	+15 -16
API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo	mediawiki/core	wmf/1.33.0-wmf.8	+15 -16

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined	Feature	None	T6718 Linker::formatComment() should be changed to support lists
Resolved		TheDJ	T6714 Epic: Increasing the length of the edit summary
Resolved		None	T36586 Increase allowable feedback text length
Invalid		None	T51188 [DO NOT USE] Schema changes for Wikimedia wikis (tracking) [superseded by #Blocked-on-schema-change]
Open		None	T6716 Edit summary box should be a multiline input
Resolved		daniel	T161671 Compacting the revision table
Resolved		Anomie	T6715 Allow comments longer than 255 bytes
Resolved		None	T227047 Complete actor table and comment table migration
Resolved		Anomie	T166733 Deploy refactored comment storage
Resolved		Anomie	T210937 API query for userprops not working on group0 wikis (maybe because comment migration read-new)

Event Timeline

Quiddity created this task.Dec 2 2018, 4:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2018, 4:51 AM

Quiddity updated the task description. (Show Details)Dec 2 2018, 4:52 AM

It's responding like your account is "missing" on testwiki

"users": [
    {
        "name": "Quiddity",
        "missing": ""
    }
],

Userinfo script is not working on mw.org. See https://www.mediawiki.org/wiki/User:Quiddity if you have the script installed.

Quiddity renamed this task from API query for userprops not working on testwiki or officewiki to API query for userprops not working on testwiki or officewiki or mediawikiwiki.Dec 3 2018, 6:18 AM

Note: it affects all users, not just my account. E.g. https://www.mediawiki.org/w/api.php?format=jsonfm&action=query&list=users|usercontribs&usprop=blockinfo|editcount|gender|registration|groups&uclimit=1&ucprop=timestamp&ususers=Jimbo%20Wales&ucuser=Jimbo%20Wales&meta=allmessages&amprefix=grouppage-&amincludelocal=1

It seems like minimal reproducible test case is: https://test.wikipedia.org/w/api.php?format=jsonfm&formatversion=2&action=query&list=users&usprop=blockinfo&ususers=Quiddity

~~So I'm going to guess its related to partial blocks.~~ further investigation suggests that it isn't related

Bawolff added a subscriber: dbarratt.Dec 3 2018, 6:36 AM

Ok, so its doing the query

SELECT  user_id,user_name,user_real_name,user_email,user_touched,user_token,user_email_authenticated,user_email_token,user_email_token_expires,user_registration,user_editcount,user_actor.actor_id,ipb_deleted,ipb_id,ipb_expiry,ipb_timestamp,ipb_by,ipb_by_text,NULL AS `ipb_by_actor`,comment_ipb_reason.comment_text AS `ipb_reason_text`,comment_ipb_reason.comment_data AS `ipb_reason_data`,comment_ipb_reason.comment_id AS `ipb_reason_cid` 
FROM `user`
LEFT JOIN `actor` `user_actor` ON ((user_actor.actor_user = user_id))
LEFT JOIN `ipblocks` ON ((ipb_user=user_id) AND (ipb_expiry > '20181203070920'))
JOIN `comment` `comment_ipb_reason` ON ((comment_ipb_reason.comment_id = ipb_reason_id)) 
WHERE user_name = 'Quiddity'  ;

So the issue seems to be its using an inner join instead of a left join, so if no block is there, then the join eliminates the row, causing the user to be reported as missing.

So the code (ApiQueryBase::showHiddenUsersAddBlockInfo) was introduced in 27c61fb1, but its probably just showing up now since comment migration was set to read new on group 0 on nov 29 (T166733)

Bawolff renamed this task from API query for userprops not working on testwiki or officewiki or mediawikiwiki to API query for userprops not working on testwiki or officewiki or mediawikiwiki (maybe because comment migration read-new).Dec 3 2018, 7:26 AM

Bawolff added a subscriber: MediaWiki-Comment-store.

Aklapper added a parent task: T206662: 1.33.0-wmf.8 deployment blockers.Dec 3 2018, 9:42 AM

Aklapper added a project: Regression.

Aklapper removed a subscriber: MediaWiki-Comment-store.

There's no need for this to block T206662, it was not caused by the wmf.8 rollout (which hasn't even happened yet). It does need to block T166733.

Change 477280 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

https://gerrit.wikimedia.org/r/477280

gerritbot added a project: Patch-For-Review.Dec 3 2018, 2:36 PM

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Dec 3 2018, 2:36 PM

Quiddity renamed this task from API query for userprops not working on testwiki or officewiki or mediawikiwiki (maybe because comment migration read-new) to API query for userprops not working on group0 wikis (maybe because comment migration read-new).Dec 3 2018, 5:28 PM

Quiddity updated the task description. (Show Details)

Anomie claimed this task.Dec 6 2018, 5:47 PM

Anomie added a project: Platform Team Workboards (Waiting for Review).

Change 477280 merged by jenkins-bot:
[mediawiki/core@master] API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

https://gerrit.wikimedia.org/r/477280

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 12 2018, 3:00 AM

Change 479458 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@wmf/1.33.0-wmf.8] API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

https://gerrit.wikimedia.org/r/479458

Change 479458 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.8] API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

https://gerrit.wikimedia.org/r/479458

Mentioned in SAL (#wikimedia-operations) [2018-12-13T16:18:33Z] <anomie> Deployed fix for T210937: API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

Anomie closed this task as Resolved.Dec 13 2018, 4:37 PM

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 13 2018, 5:00 PM

CCicalese_WMF moved this task from Waiting for Review to Done with CPT on the Platform Team Workboards board.Dec 13 2018, 8:09 PM

CCicalese_WMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Waiting for Review).

Quiddity awarded a token.Dec 13 2018, 8:57 PM

Change 488236 had a related patch set uploaded (by Reedy; owner: Anomie):
[mediawiki/core@REL1_32] API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

https://gerrit.wikimedia.org/r/488236

Reedy mentioned this in T215324: Patch for T210937 needs backporting to 1.32 (API list=users mistakenly reports user as missing).Feb 6 2019, 5:05 AM

Change 488236 merged by jenkins-bot:
[mediawiki/core@REL1_32] API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo

https://gerrit.wikimedia.org/r/488236

Reedy removed a project: Patch-For-Review.Feb 6 2019, 8:46 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM