Page MenuHomePhabricator

Make unsubscribe work in EmailPreferences, delete Unsub extension
Open, Needs TriagePublic2 Estimated Story Points

Description

DonationInterface's Special:EmailPreferences form should handle unsubscribe links from thank you letters

We will be removing the email address from the links and making donors manually write their email address.

  • Move over i18n messages
  • handle old-style links?

Event Timeline

DStrine moved this task from Q3 2021-2022 to Next on the Fundraising-Backlog board.
DStrine set the point value for this task to 2.

@Ejegg checking to see if this relates to the current pref center work, or if it can be closed.

Hi @AKanji-WMF , this isn't directly related to the current Recurring Upgrade work, but it would be great to do while the email preference center is fresh in everyone's minds. There is an old MediaWiki extension that we haven't touched in years but is still responsible for handling the unsubscribe links that are included with every automatic Thank You letter.

It would be better to move it to the newer code so it works the same way as other email preference updates, and so we can ditch the overhead associated with maintaining a separate MediaWiki extension. That overhead includes a separate set of default settings and internationalization files, plus updating the basic boilerplate files that MediaWiki uses to load the extension so it works with current MW versions.

Thanks @Ejegg - have added to Sprint +2

Update from T317929 that they want to have auto-populated email address / click submit instead of making donors manually write their email address, and ask us to pause this work for now until Legal team sign off

Since we do not have epc on production, remove the unsubscribe extension will lead broken unsubscribe function for current donor, so it blocked until we have that epc works on production.

Ejegg added a subscriber: XenoRyet.

@AKanji-WMF @XenoRyet Since we're doing work on the unsubscribe code to handle one-click unsubscribes, it would be great to tackle this at the same time.

The one-click unsubscribe would not have any UI (it seems to be POSTed to from the Google servers), but this form would have a UI. We just need to know whether the email address should be pre-populated and get whatever legal sign-off was mentioned in https://phabricator.wikimedia.org/T223330#8951468 .

Since we do not have epc on production, remove the unsubscribe extension will lead broken unsubscribe function for current donor, so it blocked until we have that epc works on production.

https://donorpreferences.wikimedia.org/index.php?title=Special:EmailPreferences/emailPreferences&contact_id=54243389&checksum=863c3c3ec2370330049846d71d74ceb0_1705523717_168 we have it on prod now

Natalie Ngu from Email team updated the template, and Danny Bu is aware of it, move to done

Change 994366 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Set up unsubscribe for DonationInterface for remove FundraisingEmailUnsubscribe

https://gerrit.wikimedia.org/r/994366

Change 995269 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] remove contribution check from email unsubscribe

https://gerrit.wikimedia.org/r/995269

@AKanji-WMF, @XenoRyet , @DBu-WMF Can you help us determine the current requirements for an unsubscribe page? The patch in review uses a link with a contact ID and a checksum like those for the email prefs pages, then has the donor fill in their email and click to confirm the unsubscribe.

Since @DBu-WMF has confirmed we can take off the unsubscribe link in the footer of the transactional emails for the US, this will be used for whatever remaining markets we need to include it in the transactional emails.

  • What should we have on the link? The contact ID / checksum combo will prevent people from unsubscribing other contact's emails - but do we need to allow people to unsubscribe arbitrary email addresses even if they don't match the contact?
  • Should the email address be pre-populated? Someone from the email team a few years ago said we could leave it blank, but requirements may have changed.
  • Should we require the click to confirm?

@AnnWF once we have the replacement up, and maybe wait a year for ppl to stop clicking old links, we can delete the whole extension, deactivate the git repo, and mark that page as obsolete.

Screenshot 2024-02-12 at 12.22.54 PM.png (1×2 px, 209 KB)
Here is the updated email pref center unsubscribe ui if we want them to confirm email address and click for unsubscribe @AKanji-WMF, @XenoRyet , @DBu-WMF please advise if any change is needed. thanks

Got the response from @DBu-WMF that we would use the existing email preference center link instead of this unsubscribe page, so next step is:
1: replacing the old unsubscribe link from email template
2: wait until next year of our new template's effective date, then uninstall the extension.