Breadcrumb to self: I'm trying to find some precedents for how this is done in MediaWiki. Keeping the default solution of an URL parameter and hook in mind, but I'm hoping there's something we can do with leaving notice HTML in the session.

Change 518011 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] [WIP] Show success notice on target file page

https://gerrit.wikimedia.org/r/518011

@Lea_WMDE We're doing these tasks in a slightly different order than expected, so the success message has been embedded on the target file page but without including the changes from T225617 because that's not implemented yet. Shall we decouple these tasks or block this on editing the source wiki?

The way I've implemented this might end up being a little too sticky. The user is redirected to an URL like http://commons.wikimedia.org/w/index.php?title=File:%D4%B6%D5%A1%D5%A2%D5%A5%D5%AC.jpg&fileimporter_success=1 , and they will see the success message any time they have this fileimporter_success parameter during the next 24 hours. This includes browser navigation history, etc. After a day, that link will behave like the normal File link.

Change 518011 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Show success notice on target file page

https://gerrit.wikimedia.org/r/518011

Can be tested on beta e.g. with: https://en.wikipedia.beta.wmflabs.org/wiki/File:Green_Image_Test.png

Amazing testing prep, thanks! What is not working for me yet is:

• The messaging is not what is described in the acceptance criteria
• The font color is green, which is rather unexpected. or is this a mediawiki standard setting?

Once this works I'm ok with decoupling the two tasks.

In T226075#5281981, @Lea_WMDE wrote:

• The messaging is not what is described in the acceptance criteria

That's due to the reversed order I was mentioning in T226075#5271466, we cannot match the text in this acceptance criteria because the feature it depends on isn't implemented yet. Replacing the success text is defined in the other (source wiki edit) task.

The font color is green, which is rather unexpected. or is this a mediawiki standard setting?

+1 that's horrible and goes against accessibility guidelines, I'll fix it.

In T226075#5281988, @awight wrote:

In T226075#5281981, @Lea_WMDE wrote:

• The messaging is not what is described in the acceptance criteria

That's due to the reversed order I was mentioning in T226075#5271466, we cannot match the text in this acceptance criteria because the feature it depends on isn't implemented yet. Replacing the success text is defined in the other (source wiki edit) task.

I'm wrong about that—we can match the text just fine, will do.

I realized, there's a third case not documented in the acceptance criteria: we do not know which template to add. Interpolating from the acceptance criteria and the existing message, maybe something like:

The import was successful. To declare that the file is now on {{SITENAME}}, please return to [$1 the original file] and add a template.

sounds great! @JStrodt_WMDE any objections?

Change 519030 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] Remove colored text from legacy styles

https://gerrit.wikimedia.org/r/519030

Change 519032 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] Fix up success text

https://gerrit.wikimedia.org/r/519032

@awight Fine by me. Thanks!

The fix for black text is pending T225571, so we might go ahead and hack some inline CSS, or wait a couple of weeks.

Updated patch overrides whatever is happening in mediawiki-core, so we can continue without blocking.

Change 519032 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix up success text

https://gerrit.wikimedia.org/r/519032

The font looks good now, but the messaging is a bit confusing, since it is both the variants we described, and not just the one where we know how the template is called:

Change 519362 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] Removes an accidental, redundant message

https://gerrit.wikimedia.org/r/519362

In T226075#5288344, @Lea_WMDE wrote:

The font looks good now, but the messaging is a bit confusing, since it is both the variants we described, and not just the one where we know how the template is called:

Thanks! A new patch is pushed which should take care of this.

Change 519362 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Removes an accidental, redundant message

https://gerrit.wikimedia.org/r/519362

Change 519030 abandoned by Awight:
Remove colored text from legacy styles

Reason:
I'd prefer the changes in Ifd01161f718f35fb3cce94efdad43a069ae8ae13

https://gerrit.wikimedia.org/r/519030

This looks great now! I just could not test yet, what text appears if the source wiki was automatically informed. So I'm keeping the ticket open as a reminder to check once we have that functionality.

Change 604651 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Use MessageLocalizer in ImportSuccessSnippet

https://gerrit.wikimedia.org/r/604651

Change 604651 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Use MessageLocalizer in ImportSuccessSnippet

https://gerrit.wikimedia.org/r/604651