Page MenuHomePhabricator
Create Task
Maniphest T225571

Add MessageWidget for block user messages (error, warning, success or notice)
Closed, ResolvedPublic
Actions

Description

We need to consider adding a MessageWidget to OOUI, based on the user system block message designs in T127405.
Out of the box it should work with the current flags

  • error
  • warning
  • success
  • notice

similar to the inline messages.

Details

SubjectRepoBranchLines +/-
FieldLayout: Use the newly created MessageWidget in noticesoojs/uimaster+13 -42
Update OOUI to v0.33.0mediawiki/coremaster+515 -266
Add a MessageWidgetoojs/uimaster+1 K -408
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Jun 11 2019, 9:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2019, 9:08 PM
Mainframe98 subscribed.Jun 12 2019, 5:26 AM
gerritbot added a comment.Jun 14 2019, 7:05 PM

Change 517123 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[oojs/ui@master] [wip] Add a NoticeWidget

https://gerrit.wikimedia.org/r/517123

gerritbot added a project: Patch-For-Review.Jun 14 2019, 7:05 PM
Mainframe98 added a comment.Jun 15 2019, 10:22 AM

Will there also be a PHP variant of this widget?

Volker_E moved this task from Backlog to Doing on the OOUI board.Jun 15 2019, 10:06 PM
Mooeypoo added a comment.Jun 16 2019, 1:41 AM
In T225571#5260481, @Mainframe98 wrote:

Will there also be a PHP variant of this widget?

Yup, working on that, just forgot to put it in the commit message's TODO.

Volker_E triaged this task as Medium priority.Jun 19 2019, 4:44 AM
Volker_E moved this task from Doing to Reviewing on the OOUI board.
Volker_E renamed this task from Add NoticeWidget for block user notices to Add MessageWidget for block user messages (error, warning, success or notice).Jun 20 2019, 11:08 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
awight mentioned this in T226075: Improve showing of success message.Jun 25 2019, 5:13 PM
matmarex subscribed.Jun 26 2019, 8:48 PM

Currently proposed design:

image.png (680×938 px, 57 KB)

gerritbot added a comment.Jun 26 2019, 9:50 PM

Change 517123 merged by jenkins-bot:
[oojs/ui@master] Add a MessageWidget

https://gerrit.wikimedia.org/r/517123

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2019, 10:11 PM
gerritbot added a comment.Jun 26 2019, 11:06 PM

Change 519307 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[oojs/ui@master] FieldLayout: Use the newly created MessageWidget in notices

https://gerrit.wikimedia.org/r/519307

gerritbot added a project: Patch-For-Review.Jun 26 2019, 11:06 PM
Jdforrester-WMF moved this task from Reviewing to OOUI-0.33.0 on the OOUI board.Jun 26 2019, 11:37 PM
Jdforrester-WMF edited projects, added OOUI (OOUI-0.33.0); removed OOUI.
gerritbot added a comment.Jun 27 2019, 2:27 AM

Change 519307 merged by jenkins-bot:
[oojs/ui@master] FieldLayout: Use the newly created MessageWidget in notices

https://gerrit.wikimedia.org/r/519307

Volker_E added a comment.Jun 27 2019, 2:38 AM

@Mooeypoo The last patch was also fixing a wrong icon appliance in 'notice' messages. Following now the design template. :)

Volker_E closed this task as Resolved.Jun 27 2019, 2:56 AM
Volker_E removed a project: Patch-For-Review.
gerritbot added a comment.Jun 27 2019, 4:02 AM

Change 519341 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

gerritbot added a project: Patch-For-Review.Jun 27 2019, 4:02 AM
gerritbot added a comment.Jun 27 2019, 9:03 PM

Change 519341 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed Patch-For-Review.Jun 27 2019, 9:54 PM
• Petar.petkovic mentioned this in T225282: Use consistent icons for the issue summary bar.Jun 27 2019, 10:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL