Enable semantic relationship between code review changesets and maniphest tasks in phabricator (show "Related Gerrit Patches")
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mmodell
	Aug 6 2019, 2:57 PM

Description

It should be possible to define the type of relationship between a task and an associated review.
Additionally, that relationship, plus the status of the code review, should be displayed at the top of the Phabricator task (somewhere near the @mentions section)

Revisions and Commits

rPHEX phabricator-extensions
	rPHEX17f80e3fd07c Only cache gerrit api results for 15 minutes
	rPHEX7a526af8b46c Add GerritPatchesCustomField

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T232656 Determine options to improve work flow between Phabricator and Gerrit
Resolved	• mmodell	T229934 Enable semantic relationship between code review changesets and maniphest tasks in phabricator (show "Related Gerrit Patches")
Declined	None	T152729 Integrate Stashbot better visually with Phabricator

Event Timeline

• mmodell created this task.Aug 6 2019, 2:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2019, 2:57 PM

This would probably involve some changes in phabricator as well as the gerrit plugin: its-phabricator

• mmodell triaged this task as Medium priority.Aug 6 2019, 6:18 PM

Quiddity awarded a token.Aug 7 2019, 8:05 AM

Presumably this is about Gerrit changesets?

T95309: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned) (poor man's version for Gerrit)
T100200: Support for getting the patch-to-review status from differential (equivalent task for Differential - do we still have repos there?)
T158739: Create a Github notification bot for phabricator (similar task for Github)

• mmodell added a subtask: T152729: Integrate Stashbot better visually with Phabricator.Aug 15 2019, 5:08 PM

• mmodell added projects: Phabricator, GerritBot.

WDoranWMF mentioned this in T232656: Determine options to improve work flow between Phabricator and Gerrit.Sep 11 2019, 7:16 PM

• mmodell claimed this task.Nov 8 2019, 11:15 AM

I guess that would address a feature I have listed T209463 namely for each task add a link to a Gerrit search query for bug:Txxxx ( https://gerrit.wikimedia.org/r/#/q/bug:T12345 ) :] I have marked it as a duplicate of your task :]

• mmodell closed this task as Resolved.Nov 8 2019, 2:58 PM

10/10 totally aced.

Example https://gerrit.wikimedia.org/r/c/548964 which has Bug: T236746 and is thus attached to T236746. Under that task description:

somelevelofawesomeness.png (173×437 px, 10 KB)

As far as I concerned that fully address my idea from T209463 and even exceed it. Thank you Santa Mukunda!

I have no idea how you managed to implement and deploy that in less than four hours though.

zeljkofilipin awarded a token.Nov 8 2019, 3:20 PM

zeljkofilipin subscribed.

hashar added a commit: rPHEX7a526af8b46c: Add GerritPatchesCustomField.Nov 8 2019, 3:23 PM

Krinkle mentioned this in T88136: Indicate deployed status (wmf branch) for Gerrit patches in Phabricator.Nov 8 2019, 4:40 PM

Dzahn awarded a token.Nov 8 2019, 7:14 PM

This is the best usability improvement on Phabricator since the day the "Close As Duplicate" button was added.

Tgr awarded a token.Nov 8 2019, 9:46 PM

greg awarded a token.Nov 8 2019, 10:54 PM

antoine-approve

(comment best seen via the web interface)

Krenair awarded a token.Nov 10 2019, 4:20 PM

MarcoAurelio awarded a token.Nov 10 2019, 4:22 PM

fgiunchedi awarded a token.Nov 13 2019, 10:49 AM

fgiunchedi subscribed.

Ammarpad awarded a token.Nov 15 2019, 5:22 PM

Aklapper awarded a token.Nov 18 2019, 9:44 PM

• Lucas_Werkmeister_WMDE mentioned this in T238956: switch prod Phabricator from phab1003 to phab1001.Dec 4 2019, 1:56 PM

Aklapper renamed this task from Enable semantic relationship between code review changesets and maniphest tasks in phabricator to Enable semantic relationship between code review changesets and maniphest tasks in phabricator (show "Related Gerrit Patches").Dec 11 2019, 10:59 AM

• mmodell added a commit: rPHEX17f80e3fd07c: Only cache gerrit api results for 15 minutes.Dec 16 2019, 8:31 PM

• mmodell added a project: Developer Productivity.Jan 7 2020, 6:24 PM

• mmodell added a parent task: T232656: Determine options to improve work flow between Phabricator and Gerrit.Aug 31 2020, 7:09 PM

Aklapper mentioned this in T265617: Experiment with GitLab-Phabricator integration.Oct 19 2020, 3:39 PM

Krinkle mentioned this in T143162: Reduce task notification noise/frequency of changes to associated open patchsets.Oct 22 2020, 10:17 PM

Tgr mentioned this in T325239: Indicate WIP status of patches on Phabricator patch list.Dec 14 2022, 8:27 PM

Aklapper closed subtask T152729: Integrate Stashbot better visually with Phabricator as Declined.Oct 24 2023, 12:05 PM