Page MenuHomePhabricator
Create Task
Maniphest T270666

Convert exchange rates module to an extension
Open, Needs TriagePublic4 Estimated Story Points
Actions

Description

Probably pretty low hanging - we should do this in a way we can share with the community

Details

SubjectRepoBranchLines +/-
Fail exchange rates more gracefully on localswikimedia/fundraising/crmmaster+2 -2
Move Exchange Rates exceptionswikimedia/fundraising/crmmaster+23 -27
Delete old exchange_rates modulewikimedia/fundraising/crmmaster+0 -322
Add a page to show latest exchange rateswikimedia/fundraising/crmmaster+128 -1
Tiny cleanup for exchange rates stuffwikimedia/fundraising/crmmaster+0 -5
API action to render CurrencyRates.phpwikimedia/fundraising/crmmaster+83 -98
Try the upgrade without the checkwikimedia/fundraising/crmmaster+1 -7
Copy exchanges rates from old drupal tablewikimedia/fundraising/crmdeployment+25 -0
Add ExchangeRate::getLatest API4 actionwikimedia/fundraising/crmdeployment+43 -0
Switch exchange_rates_convert calls to new APIwikimedia/fundraising/crmmaster+31 -13
Copy exchanges rates from old drupal tablewikimedia/fundraising/crmmaster+25 -0
Add ExchangeRate::getLatest API4 actionwikimedia/fundraising/crmmaster+43 -0
Exchange Rate Convert API actionwikimedia/fundraising/crmmaster+122 -0
ExchangeRate::updateAll API4 actionwikimedia/fundraising/crmmaster+82 -0
Exchange Rates entity: support composite keywikimedia/fundraising/crmmaster+17 -1
Switch exchange rate retrievers to Guzzlewikimedia/fundraising/crmmaster+92 -58
Create ExchangeRate entity in CiviCRMwikimedia/fundraising/crmmaster+558 -0
Migrate exchange rates variables to Civi settingswikimedia/fundraising/crmmaster+136 -11
Fix default for OANDA key settingwikimedia/fundraising/crmmaster+1 -1
Small code reformat for exchange rateswikimedia/fundraising/crmmaster+65 -63
Move files from exchange_rates/retrieverswikimedia/fundraising/crmmaster+55 -52
Move exchange rates tests to the Civi extensionwikimedia/fundraising/crmmaster+178 -98
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT261779 Epic: drupal upgrade
 OpenCstoneT270666 Convert exchange rates module to an extension

Event Timeline

Eileenmcnaughton created this task.Dec 22 2020, 1:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2020, 1:43 AM
• DStrine added a project: Fr-drupal-upgrade-2021.Dec 22 2020, 7:31 PM
• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Jan 3 2021, 8:48 PM
• DStrine moved this task from Q3 2021-2022 to Next on the Fundraising-Backlog board.Apr 12 2021, 9:07 PM
• DStrine moved this task from Next to Sprint +1 on the Fundraising-Backlog board.Mar 4 2022, 6:36 PM
Dwisehaupt set the point value for this task to 4.Mar 28 2022, 8:44 PM
XenoRyet added a project: Fundraising Sprint Localhost Hospitality Studies.Jun 21 2022, 8:25 PM
XenoRyet removed a project: Fundraising Sprint Localhost Hospitality Studies.Jun 21 2022, 8:30 PM
XenoRyet moved this task from Sprint +1 to Later on the Fundraising-Backlog board.Aug 24 2022, 7:22 PM
Eileenmcnaughton moved this task from Backlog to Drupal-EOL on the Wikimedia-Fundraising-CiviCRM board.May 2 2023, 12:13 AM
AKanji-WMF subscribed.Jun 14 2023, 6:15 PM

Relates to moving Civi off Drupal - moving to "medium future"

AKanji-WMF moved this task from Later to Mid-Future on the Fundraising-Backlog board.Jun 14 2023, 6:15 PM
AKanji-WMF moved this task from Mid-Future to Current Sprint on the Fundraising-Backlog board.Mar 26 2024, 9:13 PM

Don't know if this could address any part of this too? T310402: Epic: Look at currency exchange rates, settlement amounts, and what more data could be saved

XenoRyet added a project: Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun).Apr 1 2024, 7:39 PM
AKanji-WMF edited projects, added Fundraising Sprint: gone(); removed Fundraising Sprint: fridayFridayGottaGetDownOnFriday($fun,$fun,$fun).Apr 9 2024, 8:10 PM
jgleeson moved this task from Backlog to Doing on the Fundraising Sprint: gone() board.Apr 12 2024, 4:13 PM
jgleeson moved this task from Doing to Backlog on the Fundraising Sprint: gone() board.Apr 15 2024, 7:42 PM
gerritbot added a comment.Apr 23 2024, 4:15 AM

Change #1023141 had a related patch set uploaded (by Cstone; author: Cstone):

[wikimedia/fundraising/crm@master] WIP: Attempt at moving exchange rates tests over

https://gerrit.wikimedia.org/r/1023141

gerritbot added a project: Patch-For-Review.Apr 23 2024, 4:15 AM
Cstone claimed this task.Apr 23 2024, 7:06 PM
Cstone moved this task from Backlog to Doing on the Fundraising Sprint: gone() board.
AKanji-WMF edited projects, added Fundraising Sprint: hammertime($touch_this=false); removed Fundraising Sprint: gone().Apr 23 2024, 9:00 PM
Cstone moved this task from Backlog to Doing on the Fundraising Sprint: hammertime($touch_this=false) board.Apr 24 2024, 4:12 PM
gerritbot added a comment.Thu, May 2, 2:03 PM

Change #1026570 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Move files from exchange_rates/retrievers

https://gerrit.wikimedia.org/r/1026570

gerritbot added a comment.Thu, May 2, 2:21 PM

Change #1026579 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Small code reformat for exchange rates

https://gerrit.wikimedia.org/r/1026579

gerritbot added a comment.Thu, May 2, 9:15 PM

Change #1026683 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Migrate exchange rates variables to Civi settings

https://gerrit.wikimedia.org/r/1026683

gerritbot added a comment.Fri, May 3, 1:46 AM

Change #1023141 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Move exchange rates tests to the Civi extension

https://gerrit.wikimedia.org/r/1023141

gerritbot added a comment.Fri, May 3, 1:51 AM

Change #1026570 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Move files from exchange_rates/retrievers

https://gerrit.wikimedia.org/r/1026570

gerritbot added a comment.Fri, May 3, 1:51 AM

Change #1026579 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Small code reformat for exchange rates

https://gerrit.wikimedia.org/r/1026579

gerritbot added a comment.Fri, May 3, 7:29 PM

Change #1027004 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Create ExchangeRate entity in CiviCRM

https://gerrit.wikimedia.org/r/1027004

gerritbot added a comment.Fri, May 3, 7:29 PM

Change #1027005 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Fix default for OANDA key setting

https://gerrit.wikimedia.org/r/1027005

gerritbot added a comment.Fri, May 3, 7:29 PM

Change #1027006 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] WIP copy exchanges rates from old drupal table

https://gerrit.wikimedia.org/r/1027006

gerritbot added a comment.Fri, May 3, 7:32 PM

Change #1027005 abandoned by Ejegg:

[wikimedia/fundraising/crm@master] Fix default for OANDA key setting

Reason:

squashed into earlier patch

https://gerrit.wikimedia.org/r/1027005

gerritbot added a comment.Fri, May 3, 8:18 PM

Change #1027016 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] WIP ExchangeRate::updateAll API4 action

https://gerrit.wikimedia.org/r/1027016

gerritbot added a comment.Fri, May 3, 11:09 PM

Change #1027054 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Switch exchange rate retrievers to Guzzle

https://gerrit.wikimedia.org/r/1027054

AKanji-WMF edited projects, added Fundraising Sprint: ick(); removed Fundraising Sprint: hammertime($touch_this=false).Tue, May 7, 8:02 PM
gerritbot added a comment.Tue, May 7, 9:20 PM

Change #1026683 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Migrate exchange rates variables to Civi settings

https://gerrit.wikimedia.org/r/1026683

gerritbot added a comment.Thu, May 9, 2:19 AM

Change #1027004 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Create ExchangeRate entity in CiviCRM

https://gerrit.wikimedia.org/r/1027004

gerritbot added a comment.Thu, May 9, 7:55 AM

Change #1027054 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Switch exchange rate retrievers to Guzzle

https://gerrit.wikimedia.org/r/1027054

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: ick() board.Fri, May 10, 6:06 PM
gerritbot added a comment.Thu, May 16, 1:51 AM

Change #1032102 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Exchange Rates entity: support composite key

https://gerrit.wikimedia.org/r/1032102

gerritbot added a comment.Thu, May 16, 2:55 AM

Change #1032109 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Exchange Rate Convert API action

https://gerrit.wikimedia.org/r/1032109

gerritbot added a comment.Thu, May 16, 3:21 PM

Change #1032511 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Switch exchange_rates_convert calls to new API

https://gerrit.wikimedia.org/r/1032511

gerritbot added a comment.Thu, May 16, 9:45 PM

Change #1032102 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Exchange Rates entity: support composite key

https://gerrit.wikimedia.org/r/1032102

gerritbot added a comment.Thu, May 16, 9:45 PM

Change #1027016 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] ExchangeRate::updateAll API4 action

https://gerrit.wikimedia.org/r/1027016

gerritbot added a comment.Fri, May 17, 9:51 PM

Change #1032109 merged by Eileen:

[wikimedia/fundraising/crm@master] Exchange Rate Convert API action

https://gerrit.wikimedia.org/r/1032109

Eileenmcnaughton moved this task from Doing to Ready for Review on the Fundraising Sprint: ick() board.Sat, May 18, 10:21 PM
gerritbot added a comment.Mon, May 20, 6:18 PM

Change #1034135 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Add ExchangeRate::getLatest API4 action

https://gerrit.wikimedia.org/r/1034135

gerritbot added a comment.Mon, May 20, 6:18 PM

Change #1034136 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] API action to render CurrencyRates.php

https://gerrit.wikimedia.org/r/1034136

gerritbot added a comment.Mon, May 20, 8:02 PM

Change #1034135 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add ExchangeRate::getLatest API4 action

https://gerrit.wikimedia.org/r/1034135

gerritbot added a comment.Mon, May 20, 8:22 PM

Change #1027006 merged by Eileen:

[wikimedia/fundraising/crm@master] Copy exchanges rates from old drupal table

https://gerrit.wikimedia.org/r/1027006

gerritbot added a comment.Mon, May 20, 8:35 PM

Change #1034151 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Try the upgrade without the check

https://gerrit.wikimedia.org/r/1034151

gerritbot added a comment.Mon, May 20, 9:13 PM

Change #1034154 had a related patch set uploaded (by Eileen; author: Ejegg):

[wikimedia/fundraising/crm@deployment] Add ExchangeRate::getLatest API4 action

https://gerrit.wikimedia.org/r/1034154

gerritbot added a comment.Mon, May 20, 9:13 PM

Change #1034155 had a related patch set uploaded (by Eileen; author: Ejegg):

[wikimedia/fundraising/crm@deployment] Copy exchanges rates from old drupal table

https://gerrit.wikimedia.org/r/1034155

gerritbot added a comment.Mon, May 20, 11:29 PM

Change #1032511 merged by Eileen:

[wikimedia/fundraising/crm@master] Switch exchange_rates_convert calls to new API

https://gerrit.wikimedia.org/r/1032511

gerritbot added a comment.Tue, May 21, 12:32 AM

Change #1034154 abandoned by Eileen:

[wikimedia/fundraising/crm@deployment] Add ExchangeRate::getLatest API4 action

Reason:

bad merge attempt

https://gerrit.wikimedia.org/r/1034154

gerritbot added a comment.Tue, May 21, 12:33 AM

Change #1034155 abandoned by Eileen:

[wikimedia/fundraising/crm@deployment] Copy exchanges rates from old drupal table

Reason:

bad merge attempt

https://gerrit.wikimedia.org/r/1034155

gerritbot added a comment.Tue, May 21, 12:37 AM

Change #1034151 abandoned by Eileen:

[wikimedia/fundraising/crm@master] Try the upgrade without the check

Reason:

https://gerrit.wikimedia.org/r/1034151

gerritbot added a comment.Tue, May 21, 1:12 AM

Change #1034136 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] API action to render CurrencyRates.php

https://gerrit.wikimedia.org/r/1034136

Maintenance_bot removed a project: Patch-For-Review.Tue, May 21, 1:31 AM
Eileenmcnaughton moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: ick() board.Tue, May 21, 2:10 AM

I put this in pending deployment since the next step is probably to disable on live & push out the process control update (currently on frpm) - then I guess the module just needs to be removed

gerritbot added a comment.Tue, May 21, 3:36 PM

Change #1034511 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Tiny cleanup for exchange rates stuff

https://gerrit.wikimedia.org/r/1034511

gerritbot added a project: Patch-For-Review.Tue, May 21, 3:36 PM

Change #1034519 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Add a page to show latest exchange rates

https://gerrit.wikimedia.org/r/1034519

gerritbot added a comment.Tue, May 21, 3:51 PM

Change #1034523 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Delete old exchange_rates module

https://gerrit.wikimedia.org/r/1034523

gerritbot added a comment.Tue, May 21, 3:51 PM

Change #1034525 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Move Exchange Rates exceptions

https://gerrit.wikimedia.org/r/1034525

gerritbot added a comment.Tue, May 21, 7:10 PM

Change #1034559 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fail exchange rates more gracefully on locals

https://gerrit.wikimedia.org/r/1034559

gerritbot added a comment.Tue, May 21, 7:22 PM

Change #1034511 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Tiny cleanup for exchange rates stuff

https://gerrit.wikimedia.org/r/1034511

AKanji-WMF edited projects, added Fundraising Sprint: justWork(); removed Fundraising Sprint: ick().Tue, May 21, 8:11 PM
gerritbot added a comment.Tue, May 21, 8:20 PM

Change #1034519 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add a page to show latest exchange rates

https://gerrit.wikimedia.org/r/1034519

Eileenmcnaughton moved this task from Backlog to Ready for Review on the Fundraising Sprint: justWork() board.Wed, May 22, 12:38 AM

This is almost done - just a couple of tidy ups including https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1034559 & https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1034525

gerritbot added a comment.Wed, May 22, 1:10 AM

Change #1034523 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Delete old exchange_rates module

https://gerrit.wikimedia.org/r/1034523

Eileenmcnaughton moved this task from Ready for Review to Done on the Fundraising Sprint: justWork() board.Thu, May 23, 4:23 AM
gerritbot added a comment.Fri, May 24, 3:10 AM

Change #1034525 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Move Exchange Rates exceptions

https://gerrit.wikimedia.org/r/1034525

gerritbot added a comment.Fri, May 24, 7:48 PM

Change #1034559 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fail exchange rates more gracefully on locals

https://gerrit.wikimedia.org/r/1034559

Maintenance_bot removed a project: Patch-For-Review.Fri, May 24, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL