Page MenuHomePhabricator
Create Task
Maniphest T277464

[EPIC] Multiple Wikibase service wiring tests fail when run as unit tests
Open, Stalled, LowPublic
Actions

Description

The service wiring tests we’re adding are supposed to be unit tests that can run without MediaWiki being installed, but some of them fail when run directly via vendor/bin/phpunit (rather than tests/phpunit/phpunit.php).

AC: The following commands, run in the MediaWiki directory, should succeed:

vendor/bin/phpunit extensions/Wikibase/repo/tests/phpunit/unit/ServiceWiring/
vendor/bin/phpunit extensions/Wikibase/client/tests/phpunit/unit/includes/ServiceWiring/

Checklist as of 2021-05-04:

Details

SubjectRepoBranchLines +/-
repo: inject LanguageNameUtils into MediaWikiContentLanguagesmediawiki/extensions/Wikibasemaster+34 -10
Inject LanguageNameUtils into MediaWikiContentLanguagesmediawiki/extensions/WikibaseLexememaster+9 -3
repo: inject TitleFactory into EntitySourceDocumentUrlProvidermediawiki/extensions/Wikibasemaster+24 -8
repo: mock LanguageFallbackChainFactory in ValueFormatterFactoryTestmediawiki/extensions/Wikibasemaster+1 -1
Fix LanguageFallbackChainFactory constructormediawiki/extensions/Wikibasemaster+9 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 15 2021, 1:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2021, 1:13 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Mar 15 2021, 1:14 PM
WMDE-leszek subscribed.Mar 15 2021, 1:15 PM
Lucas_Werkmeister_WMDE mentioned this in T96458: Separate Wikibase unit tests from integration tests.Mar 15 2021, 1:18 PM
Lucas_Werkmeister_WMDE claimed this task.Mar 16 2021, 2:15 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE added a comment.Mar 16 2021, 3:41 PM
This comment was removed by Lucas_Werkmeister_WMDE.
gerritbot added a comment.Mar 16 2021, 4:08 PM

Change 672744 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: mock LanguageFallbackChainFactory in ValueFormatterFactoryTest

https://gerrit.wikimedia.org/r/672744

gerritbot added a project: Patch-For-Review.Mar 16 2021, 4:08 PM

Change 672745 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix LanguageFallbackChainFactory constructor

https://gerrit.wikimedia.org/r/672745

gerritbot added a comment.Mar 16 2021, 4:09 PM

Change 672746 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: inject TitleFactory into EntitySourceDocumentUrlProvider

https://gerrit.wikimedia.org/r/672746

gerritbot added a comment.Mar 16 2021, 4:10 PM

Change 672747 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: inject LanguageNameUtils into MediaWikiContentLanguages

https://gerrit.wikimedia.org/r/672747

gerritbot added a comment.Mar 16 2021, 4:10 PM

Change 672748 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Inject LanguageNameUtils into MediaWikiContentLanguages

https://gerrit.wikimedia.org/r/672748

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 16 2021, 4:12 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T277567: Move WikibaseClient WikibaseContentLanguages to service container.Mar 16 2021, 4:50 PM
gerritbot added a comment.Mar 16 2021, 5:43 PM

Change 672745 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix LanguageFallbackChainFactory constructor

https://gerrit.wikimedia.org/r/672745

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 16 2021, 6:00 PM
gerritbot added a comment.Mar 17 2021, 10:23 AM

Change 672746 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: inject TitleFactory into EntitySourceDocumentUrlProvider

https://gerrit.wikimedia.org/r/672746

gerritbot added a comment.Mar 17 2021, 10:23 AM

Change 672744 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: mock LanguageFallbackChainFactory in ValueFormatterFactoryTest

https://gerrit.wikimedia.org/r/672744

gerritbot added a comment.Mar 17 2021, 10:25 AM

Change 672747 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: inject LanguageNameUtils into MediaWikiContentLanguages

https://gerrit.wikimedia.org/r/672747

gerritbot added a comment.Mar 17 2021, 10:25 AM

Change 672748 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Inject LanguageNameUtils into MediaWikiContentLanguages

https://gerrit.wikimedia.org/r/672748

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 17 2021, 10:52 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 17 2021, 11:05 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Incoming on the Wikibase Service Migration board.

All the tests that are fixable for now have been fixed; I’ve created Phabricator tasks for the MediaWiki services we need in order to fix the rest, and suggest we move this back to our backlog for the time being. If we have some time at the end of our project, we might be able to fix the remaining tests (the MediaWiki core changes should hopefully not be too difficult).

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2021, 11:10 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 17 2021, 1:05 PM
gerritbot added a comment.Mar 30 2021, 4:51 PM

Change 675840 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Make WikiPageEntityMetaDataLookup default to NullLogger

https://gerrit.wikimedia.org/r/675840

gerritbot added a project: Patch-For-Review.Mar 30 2021, 4:51 PM
Lucas_Werkmeister_WMDE added a comment.Apr 1 2021, 2:27 PM

Several tests now require DBAccessBase improvements, see T279063: Deprecate and remove DBAccessBase class.

darthmon_wmde moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 22 2021, 10:18 AM
Lucas_Werkmeister_WMDE removed a project: Patch-For-Review.Apr 30 2021, 9:16 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 30 2021, 9:24 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 3 2021, 9:19 AM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.May 3 2021, 9:35 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 3 2021, 9:55 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 3 2021, 1:18 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 3 2021, 3:30 PM
Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech.May 3 2021, 4:25 PM
Addshore moved this task from Inbox to Hike Leftovers on the [DEPRECATED] wdwb-tech board.May 3 2021, 4:33 PM
Lucas_Werkmeister_WMDE closed subtask T281677: Make SummaryFormatterTest a proper unit test as Resolved.May 3 2021, 7:26 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)May 4 2021, 9:47 AM
Addshore moved this task from Hike Leftovers to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.May 4 2021, 10:52 AM
Addshore added a project: Wikidata-Campsite.May 4 2021, 10:54 AM
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore triaged this task as Low priority.Jul 14 2021, 9:36 AM
Addshore removed a project: Wikidata-Campsite.
Addshore subscribed.

Prioritized very low, so removing from Wikidata-Campsite

Lucas_Werkmeister_WMDE closed subtask T281707: Make ChangeHandlerTest a proper unit test as Resolved.Jan 28 2022, 10:57 AM
Lucas_Werkmeister_WMDE closed subtask T281693: Make TermStoreWriterFactoryTest a proper unit test as Resolved.
kostajh subscribed.Jul 14 2022, 11:41 AM
Lucas_Werkmeister_WMDE added a parent task: T266441: MediaWikiUnitTestCase should prevent access to MediaWikiServices.Jul 14 2022, 12:38 PM
Lucas_Werkmeister_WMDE added a comment.Jul 14 2022, 12:41 PM

I think we should reprioritize this, as it blocks T266441: @kostajh wants to enforce the “unit test-ness” of unit tests, whereas some service wiring tests currently rely on the fact that they can run like integration tests. I really don’t want to turn them into actual integration tests, so we should pursue whatever other changes are necessary so that all of them can actually run as pure unit tests.

Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team.Jul 14 2022, 12:41 PM
kostajh awarded a token.Jul 14 2022, 1:04 PM
kostajh added a parent task: T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php.
Lucas_Werkmeister_WMDE added a project: wmde-wikidata-tech.Jul 14 2022, 1:22 PM
Maintenance_bot moved this task from Triaged Low (0-50) to Sorted Team A on the [DEPRECATED] wdwb-tech board.Jul 14 2022, 1:29 PM
Michael subscribed.Jul 18 2022, 9:41 AM
ItamarWMDE renamed this task from Multiple Wikibase service wiring tests fail when run as unit tests to [EPIC] Multiple Wikibase service wiring tests fail when run as unit tests.Jan 31 2023, 2:47 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 31 2023, 2:51 PM
ItamarWMDE moved this task from Incoming to Epics on the wmde-wikidata-tech board.Jan 31 2023, 2:51 PM
ItamarWMDE subscribed.Jan 31 2023, 3:26 PM

Task Triage Notes:

After discussion with PMs and EMs on this topic, we will file this as tech debt to be resolved in a more structured way at a later date.

ItamarWMDE changed the task status from Open to Stalled.Jan 31 2023, 3:27 PM
ItamarWMDE moved this task from Incoming to Epics+STALLED on the Wikidata Dev Team board.
Addshore unsubscribed.Jun 27 2023, 12:43 PM
Daimona removed a parent task: T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php.Sep 2 2023, 2:42 PM
ItamarWMDE moved this task from Epics to Radar on the wmde-wikidata-tech board.Sep 20 2023, 2:47 PM
Lucas_Werkmeister_WMDE added a comment.Jan 17 2024, 5:03 PM

Note that our PHPUnit bootstrap file now assumes unit tests can run without MediaWiki setup, so you’ll get an error if you try to run these tests individually:

$ composer phpunit:entrypoint extensions/Wikibase/repo/tests/phpunit/unit/ServiceWiring/EntityDataUriManagerTest.php
> phpunit 'extensions/Wikibase/repo/tests/phpunit/unit/ServiceWiring/EntityDataUriManagerTest.php'
Using PHP 8.3.1
Running without MediaWiki settings because there are no integration tests
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 00:00.029, Memory: 26.00 MB

There was 1 error:

1) Wikibase\Repo\Tests\Unit\ServiceWiring\EntityDataUriManagerTest::testConstruction
LogicException: Premature access to service container

/srv/http/wiki1/includes/MediaWikiServices.php:325
/srv/http/wiki1/includes/specialpage/SpecialPage.php:169
/srv/http/wiki1/includes/specialpage/SpecialPage.php:155
/srv/http/wiki1/extensions/Wikibase/repo/WikibaseRepo.ServiceWiring.php:760
/srv/http/wiki1/extensions/Wikibase/repo/tests/phpunit/unit/ServiceWiringTestCase.php:90
/srv/http/wiki1/extensions/Wikibase/repo/tests/phpunit/unit/ServiceWiring/EntityDataUriManagerTest.php:41

ERRORS!
Tests: 1, Assertions: 6, Errors: 1.
Script phpunit handling the phpunit event returned with error code 2
Script @phpunit was called via phpunit:entrypoint

I assume they only continue to work in CI because they’re run as part of a bigger test group that still includes integration tests.

Lucas_Werkmeister_WMDE mentioned this in T361949: [SW] [REPO][CLIENT] Use ObjectCacheFactory in Wikibase.Apr 5 2024, 2:38 PM
Lucas_Werkmeister_WMDE added a parent task: T96458: Separate Wikibase unit tests from integration tests.Mon, Apr 15, 10:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL