Page MenuHomePhabricator

Make WikibaseRepo.BagOStuffSiteLinkConflictLookup a proper unit test
Open, Needs TriagePublic

Description

The WikibaseRepo.WikibaseRepo.BagOStuffSiteLinkConflictLookup service wiring (introduced in T291377) uses the ObjectCache::getLocalClusterInstance() function, which means that the unit test for that service wiring actually can’t run without MediaWiki being set up, because ObjectCache::getLocalClusterInstance() uses MediaWiki globals and the default service container.

A solution for this almost certainly requires T243233: MediaWiki should provide a LocalClusterObjectCache service.

See also: T281706, T281708, T281710.

Event Timeline

(I’m creating this task before the change introducing the service has been merged, to make sure we don’t forget about it. If the task turns out to become invalid with other developments on that change, we can always close it.)