Normalize link tables: Create linktarget table
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Jan 18 2022, 3:56 PM

Description

The parent ticket has more information. This table must have immutable rows. The design would be:

CREATE TABLE /*_*/linktarget (
  lt_id BIGINT UNSIGNED AUTO_INCREMENT NOT NULL,
  lt_namespace INT NOT NULL,
  lt_title VARBINARY(255) NOT NULL,

  UNIQUE INDEX lt_namespace_title (lt_namespace, lt_title),

  PRIMARY KEY(lt_id)
) /*$wgDBTableOptions*/;

Details

	Subject	Repo	Branch	Lines +/-
	maintain-views: Add linktarget	operations/puppet	production	+1 -0
	Add linktarget table	mediawiki/core	master	+79 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T300222 Implement normalizing MediaWiki link tables
		Resolved		Ladsgroup	T299416 Normalize link tables: Create linktarget table

Event Timeline

Ladsgroup created this task.Jan 18 2022, 3:56 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 18 2022, 3:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ladsgroup mentioned this in T299417: Normalize templatelinks table.Jan 18 2022, 3:58 PM

Ladsgroup triaged this task as Medium priority.Jan 18 2022, 4:08 PM

Ladsgroup moved this task from Triage to In progress on the DBA board.Jan 18 2022, 4:10 PM

Change 754989 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Add title table

https://gerrit.wikimedia.org/r/754989

gerritbot added a project: Patch-For-Review.Jan 18 2022, 4:47 PM

Public table or does it need filtering?

public table as links tables are public as well.

jcrespo awarded a token.Jan 18 2022, 6:28 PM

Krinkle renamed this task from New table: title table to Normalize link tables: Create linktarget table.Jan 26 2022, 10:54 PM

Krinkle updated the task description. (Show Details)Jan 26 2022, 11:04 PM

now it needs deployment and cloud changes.

Ladsgroup edited parent tasks, added: T300222: Implement normalizing MediaWiki link tables; removed: T222224: RFC: Normalize MediaWiki link tables.Jan 27 2022, 12:13 AM

Change 754989 merged by jenkins-bot:

[mediawiki/core@master] Add linktarget table

https://gerrit.wikimedia.org/r/754989

Izno subscribed.Jan 27 2022, 12:37 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 27 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2022, 1:11 AM

In T299416#7629544, @Ladsgroup wrote:

public table as links tables are public as well.

I wonder if we should do something similar to what we do for actor (replicating to cloud replicas but using views to only show rows that are referenced in publicly available rows)

That sounds good to me but let's deploy it publicly first and after the first use, let's change it (I think it would be possible to do so, correct?)

Yeah, we can re-create the views on all wikis (which is currently really tedious but we would need to do that either way when adding new tables to filter on).