Page MenuHomePhabricator

Vector-2022.js should no longer load legacy Vector site and user scripts/styles
Closed, ResolvedPublicBUG REPORT

Description

NOTE: Please see T357580 and https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Loading_Vector_2010_scripts for any actions your community may need to take as part of this change

As part of the splitting of the Vector skins (T291098), here was a product requirement to minimize impact on communities.

To fulfil this the new modern Vector skin:

  • loads both MediaWiki:Vector.(css,js) and MediaWiki:Vector-2022.(css,js)
  • loads both User:<username>/vector.(css,js) and User:<username>/vector-2022.(css,js)

Over time this has become problematic rather than helpful leading to bugs like T357473.

Plan

  • A configuration flag will be added to Vector to disable the site styles/scripts behaviour. Communities can request to disable it, when they are ready. When enabled Vector 2022 will not load either JS or CSS. This is a good opportunity for communities to do some housekeeping, e.g. moving styles to TemplateStyles and scripts to gadgets.
  • A User-notice will be sent out to communities. Users using modern Vector will be instructed to delete/blank their user vector.(js|css) in preparation for the change.
  • We will drop support for new wikis going forward. When wikis switch skins from legacy Vector to Vector 2022 users will need to copy any relevant code from vector.js and vector.css to vector-2022.js and vector-2022.css. Site admins will need to copy important code from MedaWiki:Vector.css/js to MediaWiki:Vector-2022.css/js (February 14th 2024)
  • We will drop support for Wikibooks and Wikivoyage (February 14th 2024)

The remaining projects is based on how many vector.js and vector.css user scripts are active on the projects. Note, the existence of this page doesn't mean it is active or that the user is using Vector 2022 skin, but is the best proxy we have for limiting impact.

https://docs.google.com/spreadsheets/d/14o1gfbLJQZmIfdo4JLUg9dMtXlrG8SciPLsHly3cSe8/edit#gid=56891684

PhaseWeekWho impactedUser noticeDone
09th March 2023Nobody (intention set)T331679
114th February 2024All projects where Vector legacy is the default skin, Wikivoyage, Wikibooks, Japanese WikipediaT357580
24th MarchSee spreadsheetProjects with 0 user scripts and testwiki
318th MarchSee spreadsheet: Projects with <= 50 user scriptsT360384
416th Aprilbgwiki, bmwiki, dawiki, dewiktionary, elwiki, eowiki, eswiktionary, frwikiversity, hiwiki, hrwiki, mlwiki, mswiki, rowiki, skwiki, srwiki, tawikiT362701
514th Maynlwiki,simplewiki,ptwiki,svwiki,kowiki,cswiki,hewiki,cawiki,huwiki,urwiki,idwiki,nowiki,trwiki,viwiki,dawiki: Projects with > 100 user scripts < 500T362701
620th Mayenwiki,zhwiki,metawiki: Projects with > 500 user scriptsT362701

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Common.js should apply to all skins.

Just to clarify this is how it currently behaves and this configuration change doesn't change that.

Just make the change now, before the situation becomes more entrenched.

I'm happy to deploy any configuration changes here provided it has gone through the https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests process :-)

The last 2 linked searches above are mistaken: user pages shouldn't be named Vector.js/css, but vector.js/css (contrarily to the site scripts, which are Titlecased). Just change "Vector" to "vector" in the last 2 links.

And of course, there is a handful of wrongly named user pages, using the erroneous "Vector" case…

Sorry typo. The numbers are correct.

Change 1005569 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Remove Japanese Wikipedia from projects sharing user scripts

https://gerrit.wikimedia.org/r/1005569

Change 1005569 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove Japanese Wikipedia from projects sharing user scripts

https://gerrit.wikimedia.org/r/1005569

Mentioned in SAL (#wikimedia-operations) [2024-02-21T21:27:38Z] <jhuneidi@deploy2002> Started scap: Backport for [[gerrit:1005569|Remove Japanese Wikipedia from projects sharing user scripts (T301212)]], [[gerrit:rMW10055702ccaa|Enable night mode on beta cluster (T357759)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-21T21:29:00Z] <jhuneidi@deploy2002> jdlrobson and jhuneidi: Backport for [[gerrit:1005569|Remove Japanese Wikipedia from projects sharing user scripts (T301212)]], [[gerrit:rMW10055702ccaa|Enable night mode on beta cluster (T357759)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-02-21T21:42:56Z] <jhuneidi@deploy2002> Finished scap: Backport for [[gerrit:1005569|Remove Japanese Wikipedia from projects sharing user scripts (T301212)]], [[gerrit:rMW10055702ccaa|Enable night mode on beta cluster (T357759)]] (duration: 15m 25s)

Jdlrobson updated the task description. (Show Details)

Change 1012425 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] [phase 4] Projects with < 50 user scripts no longer share skin scripts

https://gerrit.wikimedia.org/r/1012425

Change 1012425 merged by jenkins-bot:

[operations/mediawiki-config@master] [phase 4] Projects with < 50 user scripts no longer share skin scripts

https://gerrit.wikimedia.org/r/1012425

Mentioned in SAL (#wikimedia-operations) [2024-03-18T20:05:39Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:1011454|Throttle: add event (T360357)]], [[gerrit:1012425|[phase 4] Projects with < 50 user scripts no longer share skin scripts (T301212)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-18T20:08:00Z] <urbanecm@deploy2002> rhinosf1 and urbanecm and jdlrobson: Backport for [[gerrit:1011454|Throttle: add event (T360357)]], [[gerrit:1012425|[phase 4] Projects with < 50 user scripts no longer share skin scripts (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-18T20:22:05Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:1011454|Throttle: add event (T360357)]], [[gerrit:1012425|[phase 4] Projects with < 50 user scripts no longer share skin scripts (T301212)]] (duration: 16m 26s)

PhaseWeekWho impactedUser noticeDone
318th MarchSee spreadsheet: Projects with <= 50 user scriptsT360384
42nd AprilSee spreadsheet: Projects with 50-100 user scripts....

T360384 could have been sent out a week earlier… Could you please organize so that the User-notice goes out on the Monday of the week the change is made (e.g. for phase 4, it goes out on April 1, assuming there’s Tech News on Easter Monday)? This would ensure that admins have been informed by the time the change actually happens.

PhaseWeekWho impactedUser noticeDone
514th Aprilnlwiki,simplewiki,ptwiki,svwiki,kowiki,cswiki,hewiki,cawiki,huwiki,urwiki,idwiki,nowiki,trwiki,viwiki,dawiki: Projects with > 100 user scripts < 500....
621st Aprilenwiki,zhwiki,metawiki: Projects with > 500 user scripts....

Are you sure about the dates? These two are Sundays.

The user notice messages now are to allow projects to be reactive. There have already been two messages explaining how communities can be proactive the most recent being T357580.

I will look into the dates.

Yes, it allows them to be reactive – but there is still an important difference between “pardon, we’ll break your wiki in a day because you haven’t been proactive” and “sorry, we’ve broken your wiki six days ago because you haven’t been proactive”: namely whether interface admins can react as soon as you break it, or they have no idea what’s going on for a week. (As far as I remember, the last reminder about this was quite a while ago, so interface admins may have well forgot about it.)

Change #1020292 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] [phase 4] Vector-2022.js should no longer load legacy Vector site and user scripts/styles

https://gerrit.wikimedia.org/r/1020292

Change #1020292 merged by jenkins-bot:

[operations/mediawiki-config@master] [phase 4] Vector-2022.js should no longer load legacy Vector site and user scripts/styles

https://gerrit.wikimedia.org/r/1020292

Mentioned in SAL (#wikimedia-operations) [2024-04-16T20:57:52Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1020292|[phase 4] Vector-2022.js should no longer load legacy Vector site and user scripts/styles (T301212)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-16T21:01:06Z] <cjming@deploy1002> cjming and jdlrobson: Backport for [[gerrit:1020292|[phase 4] Vector-2022.js should no longer load legacy Vector site and user scripts/styles (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-16T21:16:19Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1020292|[phase 4] Vector-2022.js should no longer load legacy Vector site and user scripts/styles (T301212)]] (duration: 18m 26s)

Change #1031047 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Phase 5: Vector-2022.js should no longer load legacy Vector code

https://gerrit.wikimedia.org/r/1031047

Change #1031047 merged by jenkins-bot:

[operations/mediawiki-config@master] Phase 5: Vector-2022.js should no longer load legacy Vector code

https://gerrit.wikimedia.org/r/1031047

Mentioned in SAL (#wikimedia-operations) [2024-05-14T13:40:38Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap: Backport for [[gerrit:1030200|Deploy disabled limited width on main page (T357706)]], [[gerrit:1031047|Phase 5: Vector-2022.js should no longer load legacy Vector code (T301212)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-14T13:43:17Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 jdlrobson and ksarabia and lucaswerkmeister-wmde: Backport for [[gerrit:1030200|Deploy disabled limited width on main page (T357706)]], [[gerrit:1031047|Phase 5: Vector-2022.js should no longer load legacy Vector code (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-14T13:57:10Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1030200|Deploy disabled limited width on main page (T357706)]], [[gerrit:1031047|Phase 5: Vector-2022.js should no longer load legacy Vector code (T301212)]] (duration: 16m 32s)

Change #1031456 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Vector and Vector 2022 no longer share site styles or scripts

https://gerrit.wikimedia.org/r/1031456

Change #1031458 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Disable last remaining projects using share user scripts

https://gerrit.wikimedia.org/r/1031458

Change #1031459 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Drop unused config

https://gerrit.wikimedia.org/r/1031459

Change #1031458 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable last remaining projects using share user scripts

https://gerrit.wikimedia.org/r/1031458

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:06:48Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1024813|Introduce sample overrides to web_ui_actions (T361962)]], [[gerrit:1031610|Disable wgParserEnableLegacyMediaDOM (T363597)]], [[gerrit:1031458|Disable last remaining projects using share user scripts (T301212)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:09:25Z] <urbanecm@deploy1002> urbanecm and jdlrobson and ksarabia: Backport for [[gerrit:1024813|Introduce sample overrides to web_ui_actions (T361962)]], [[gerrit:1031610|Disable wgParserEnableLegacyMediaDOM (T363597)]], [[gerrit:1031458|Disable last remaining projects using share user scripts (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Change #1034149 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] wgVectorShareUserScripts should be false now

https://gerrit.wikimedia.org/r/1034149

Change #1034149 merged by jenkins-bot:

[operations/mediawiki-config@master] wgVectorShareUserScripts should be false now

https://gerrit.wikimedia.org/r/1034149

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:25:06Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1024813|Introduce sample overrides to web_ui_actions (T361962)]], [[gerrit:1031610|Disable wgParserEnableLegacyMediaDOM (T363597)]], [[gerrit:1031458|Disable last remaining projects using share user scripts (T301212)]] (duration: 18m 18s)

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:25:27Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:980063|Remove readability survey tool (T349337)]], [[gerrit:1034149|wgVectorShareUserScripts should be false now (T301212)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:28:03Z] <urbanecm@deploy1002> ksarabia and jdlrobson and urbanecm: Backport for [[gerrit:980063|Remove readability survey tool (T349337)]], [[gerrit:1034149|wgVectorShareUserScripts should be false now (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:44:01Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:980063|Remove readability survey tool (T349337)]], [[gerrit:1034149|wgVectorShareUserScripts should be false now (T301212)]] (duration: 18m 34s)

Jdlrobson updated the task description. (Show Details)