| Stang | |
| Mar 13 2022, 4:26 AM |
| F35039914: Screenshot 2022-04-05 at 17.39.00.png | |
| Apr 5 2022, 4:49 PM |
| F35039929: Screenshot 2022-04-05 at 17.45.04.png | |
| Apr 5 2022, 4:49 PM |
| F35039925: Screenshot 2022-04-05 at 17.44.22.png | |
| Apr 5 2022, 4:49 PM |
| F35039906: Screenshot 2022-04-05 at 17.37.29.png | |
| Apr 5 2022, 4:49 PM |
| F35039909: Screenshot 2022-04-05 at 17.38.25.png | |
| Apr 5 2022, 4:49 PM |
| F35003752: image.png | |
| Mar 13 2022, 4:26 AM |
List of steps to reproduce (step by step, including full links if applicable):
What happens?:
"otherlanguages" menu on the left looks pretty strange.
What should have happened instead?:
It should looks similar to other labels.
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
1.38.0-wmf.25 (2b818a6)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add "vector-menu-heading" class to otherlanguages | mediawiki/core | master | +25 -10 |
Change 770123 had a related patch set uploaded (by Stang; author: Stang):
[mediawiki/core@master] Add "vector-menu-heading" class to otherlanguages
The editing team maintains this code. I've flagged in the past in T300814 that the current approach is not sustainable. @ovasileva we will need to work with the editing team if we want to support this better.
cc @MusikAnimal this is a very similar problem to the one we've been talking about in https://github.com/wikimedia-gadgets/MoreMenu/issues/25#issuecomment-1064558959
@Jdlrobson @ovasileva I think your team is capable of preventing further regressions of the same kind by yourselves. Can you amend your processes to ensure this doesn't occur again?
In fact an identical regression occured 1.5 years ago: T262374: The "In other languages" portal appears unstyled when editing a page.
Change 770123 merged by jenkins-bot:
[mediawiki/core@master] Add "vector-menu-heading" class to otherlanguages
@Jdlrobson, @matmarex - is this a wikiversity-only issue/restricted to that beta cluster?
No, it's also reproducible on e.g. https://www.mediawiki.org/. I haven't checked which wikis exactly are affected (it depends on the configuration for the language links menu somehow).
Yes, I had the same problem with w:User:MusikAnimal/scriptManager as well, which I've since fixed.
I think if the Readers Web team is planning more changes to menus and portals (as I understand you are, T302073), it would be ideal to provide a JS entrypoint for scripts and gadgets to create their own portlets. The need for this clearly established, even in MediaWiki Core. I have created a proposal at T303859: Provide a JS entrypoint to create custom portlets.
