Page MenuHomePhabricator
Create Task
Maniphest T312241

Deploy the new grid layout
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

In T311793 we completed the new grid layout.
Following QA and design review we should deploy it via the following process

TODO

  • Make sure T287609 is done at the same time.
  • Deploy to group 0 wikis on Tuesday 18th.
  • Optional: group 1 wikis on Wed 19th
  • Deploy to all wikis on Thursday 20th. On this day it's also safe to remove VectorTitleAboveTabs.
  • Remove grid code from Vector

sign off steps

  • Check if T295433 is resolved.
  • Resolve T309711
  • Make a task to remove the wgVectorGrid flag from mediawiki configuration based on when it's safe to do so. (Done in T313559)

Details

SubjectRepoBranchLines +/-
Layout: Release CSS gridmediawiki/skins/Vectormaster+1 -1
Deploy grid to all wikisoperations/mediawiki-configmaster+1 -14
Deploy the new grid layout to group 1operations/mediawiki-configmaster+1 -1
Deploy the new grid layout to group 0 wikisoperations/mediawiki-configmaster+8 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 6 2022, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2022, 4:28 PM
Jdlrobson triaged this task as High priority.Jul 6 2022, 4:28 PM
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptJul 6 2022, 4:28 PM
Jdlrobson mentioned this in T311793: [Layout] Ready Vector's new CSS grid layout for wider deployment.Jul 6 2022, 4:36 PM
Pcoombe subscribed.Jul 6 2022, 9:34 PM
Jdlrobson updated the task description. (Show Details)Jul 8 2022, 6:28 PM
Jdlrobson updated the task description. (Show Details)Jul 8 2022, 7:04 PM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2022-23-Q1).Jul 14 2022, 4:30 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 14 2022, 5:04 PM
LGoto set the point value for this task to 3.Jul 18 2022, 5:43 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 18 2022, 5:58 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 18 2022, 6:01 PM
gerritbot added a comment.Jul 18 2022, 6:02 PM

Change 814869 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Deploy the new grid layout

https://gerrit.wikimedia.org/r/814869

gerritbot added a project: Patch-For-Review.Jul 18 2022, 6:02 PM
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 18 2022, 9:12 PM
gerritbot added a comment.Jul 18 2022, 10:01 PM

Change 814906 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Deploy the new grid layout to group 1

https://gerrit.wikimedia.org/r/814906

gerritbot added a comment.Jul 18 2022, 10:01 PM

Change 814907 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Deploy grid to all wikis

https://gerrit.wikimedia.org/r/814907

Jdlrobson updated the task description. (Show Details)Jul 18 2022, 10:08 PM
Jdlrobson claimed this task.Jul 19 2022, 5:03 PM
Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson mentioned this in T308074: 1.39.0-wmf.21 deployment blockers.Jul 19 2022, 5:49 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 19 2022, 6:15 PM
gerritbot added a comment.Jul 19 2022, 8:17 PM

Change 814869 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy the new grid layout to group 0 wikis

https://gerrit.wikimedia.org/r/814869

Stashbot added a comment.Jul 19 2022, 8:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T20:23:29Z] <cjming@deploy1002> Synchronized wmf-config: Config: [[gerrit:814869|Deploy the new grid layout to group 0 wikis (T312241)]] (duration: 03m 05s)

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 19 2022, 8:53 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 20 2022, 4:42 PM
gerritbot added a comment.Jul 20 2022, 8:33 PM

Change 814906 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy the new grid layout to group 1

https://gerrit.wikimedia.org/r/814906

Stashbot added a comment.Jul 20 2022, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-20T20:38:35Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:814906|Deploy the new grid layout to group 1 (T312241)]] (duration: 03m 14s)

Stashbot added a comment.Jul 20 2022, 8:43 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-20T20:43:00Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:814906|Deploy the new grid layout to group 1 (T312241)]] (duration: 03m 16s)

gerritbot added a comment.Jul 20 2022, 8:59 PM

Change 808258 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Layout: Release CSS grid

https://gerrit.wikimedia.org/r/808258

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 20 2022, 8:59 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson removed Jdlrobson as the assignee of this task.Jul 21 2022, 5:03 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
LGoto assigned this task to cjming.Jul 21 2022, 5:08 PM
gerritbot added a comment.Jul 21 2022, 8:27 PM

Change 814907 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy grid to all wikis

https://gerrit.wikimedia.org/r/814907

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 21 2022, 8:29 PM
Jdlrobson moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Stashbot added a comment.Jul 21 2022, 8:32 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-21T20:32:02Z] <cjming@deploy1002> Synchronized wmf-config: Config: [[gerrit:814907|Deploy grid to all wikis (T312241)]] (duration: 03m 13s)

gerritbot added a comment.Jul 21 2022, 9:47 PM

Change 808258 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Layout: Release CSS grid

https://gerrit.wikimedia.org/r/808258

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 21 2022, 10:00 PM
Jdlrobson mentioned this in T295433: Long username/language labels leads to horizontal scroll bar on meta on 1000-1200px threshold.Jul 21 2022, 10:20 PM
Jdlrobson mentioned this in T313559: Remove Vector grid feature flagging code.Jul 21 2022, 10:24 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

For design review I'll be creating a separate task since there is lots going out in this train. Will sign off when that's done.

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2022, 10:30 PM
Jdlrobson mentioned this in T313562: Design review the visual enhancement and layout changes.Jul 21 2022, 10:54 PM
MusikAnimal mentioned this in T313376: Preview pane overlaps outside its pane.Jul 22 2022, 7:59 PM
Tgr mentioned this in T313666: addPortletLink ignores "insert before" parameter on Vector.Jul 23 2022, 8:06 PM
cjming removed cjming as the assignee of this task.Jul 25 2022, 3:59 PM
cjming subscribed.
LGoto assigned this task to ovasileva.Jul 25 2022, 5:21 PM
ovasileva closed this task as Resolved.Aug 1 2022, 12:48 PM

All done, resolving

dom_walden mentioned this in T314467: Infinite horizontal scroll when using horizontal resizer.Aug 3 2022, 10:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL