Page MenuHomePhabricator
Create Task
Maniphest T312450

Migrate usage of Database::select to SelectQueryBuilder in MobileFrontend
Closed, DuplicatePublic
Actions

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

SubjectRepoBranchLines +/-
Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/MobileFrontendmaster+22 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:28 AM
Ladsgroup added a project: MobileFrontend.Jul 7 2022, 6:47 AM
Jdlrobson edited projects, added MobileFrontend (MobileFrontend Special Pages), Web-Team-Backlog (Needs Prioritization (Tech)); removed MobileFrontend.Jul 8 2022, 3:45 PM
Jdlrobson subscribed.

I believe we use this in certain special pages e.g. https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/07e08e248b34354ccb4b7839874a8725ad7d1dbb/includes/specials/SpecialMobileHistory.php#L192

Jdlrobson moved this task from Backlog to Remove mobile Watchlist special page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jul 8 2022, 6:43 PM
Jdlrobson triaged this task as Low priority.Mar 15 2023, 10:36 PM
Jdlrobson edited projects, added patch-welcome, good first task, Web-Team-Backlog (FY2023-24 Q3 Sprint 2); removed Web-Team-Backlog (Needs Prioritization (Tech)).Dec 13 2023, 10:03 PM
Jdlrobson moved this task from Backlog to History on the MobileFrontend (MobileFrontend Special Pages) board.
Jdlrobson changed the task status from Open to Stalled.Dec 13 2023, 10:24 PM

Will become unnecessary after T353388

Jdlrobson moved this task from FY2023-24 Q3 Sprint 2 to FY2023-24 Q3 Sprint 3 on the Web-Team-Backlog board.Jan 4 2024, 11:15 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 2).
Jdlrobson mentioned this in T356120: Decommision the Special:History page.Jan 30 2024, 9:28 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 3).
Jdlrobson closed this task as a duplicate of T356120: Decommision the Special:History page.Feb 21 2024, 2:55 AM
gerritbot added a comment.Wed, Apr 24, 7:38 PM

Change #1023940 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MobileFrontend@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1023940

gerritbot added a project: Patch-For-Review.Wed, Apr 24, 7:38 PM
gerritbot added a comment.Fri, Apr 26, 9:28 PM

Change #1023940 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1023940

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL