Page MenuHomePhabricator

Enable desktop history HTML on mobile
Closed, ResolvedPublic

Description

The desktop history page and mobile history page look very similar (in fact the desktop version looks better)
Compare

Screenshot 2023-12-13 at 12.10.27 PM.png (1×1 px, 140 KB)
Screenshot 2023-12-13 at 12.13.26 PM.png (1×1 px, 178 KB)

#TODO:

  • Enable on beta cluster and provide two URLs.
  • Fix blockers (see subtasks)
  • Enable on production pilot wikis
  • Enable on all production wikis

Sign off steps

  • Prioritize decommissioning the unused MobileFrontend SpecialHistory page (leaving a redirect)

Event Timeline

Change 982925 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] [BC] Enable desktop diff and history pages on mobile

https://gerrit.wikimedia.org/r/982925

Change 982925 merged by jenkins-bot:

[operations/mediawiki-config@master] [BC] Enable desktop diff and history pages on mobile

https://gerrit.wikimedia.org/r/982925

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:48:01Z] <jhuneidi@deploy2002> Started scap: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]]

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:49:33Z] <jhuneidi@deploy2002> jhuneidi and jdlrobson and cwhite: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-12-13T22:57:43Z] <jhuneidi@deploy2002> Finished scap: Backport for [[gerrit:982867|Update wgStatsTarget to port 9125 (T240685)]], [[gerrit:982925|[BC] Enable desktop diff and history pages on mobile (T350181 T353388)]] (duration: 09m 42s)

The only issue I could find is that there's no click dead-zone around the date headers. In the old page if you tap the dates nothing happens. In the new one it always selects the diff above or below. Not the end of the world but might cause some unintended clicks.

Otherwise this is looking good to me!

The only issue I could find is that there's no click dead-zone around the date headers.

Opened T353485. Do you consider this a blocker?

The only issue I could find is that there's no click dead-zone around the date headers.

Opened T353485. Do you consider this a blocker?

Not a blocker :)

Jdlrobson added a subscriber: jsn.sherman.

This page looks ready to ship. I plan to deploy this early next year to some pilot wikis with @jsn.sherman 's help. See you all in 2024! Thanks for your help with this initiative!

Change 990152 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable desktop history page for all mobile logged in users

https://gerrit.wikimedia.org/r/990152

@Samwalton9-WMF @jsn.sherman we'll get the most feedback from logged in users on English Wikipedia, so I suggest deploying the desktop history page on mobile there on Tuesday. We can aim to expand this to everyone by the end of next week. Let me know if you have any concerns with that plan!

Change 990152 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable desktop history page for all mobile logged in users

https://gerrit.wikimedia.org/r/990152

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:28:25Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:990152|Enable desktop history page for all mobile logged in users (T353388)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:30:04Z] <catrope@deploy2002> jdlrobson and catrope: Backport for [[gerrit:990152|Enable desktop history page for all mobile logged in users (T353388)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-17T21:43:41Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:990152|Enable desktop history page for all mobile logged in users (T353388)]] (duration: 15m 15s)

Jdlrobson updated the task description. (Show Details)

Change 991424 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Use desktop history page HTML everywhere

https://gerrit.wikimedia.org/r/991424

Tentative deployment date for everywhere is 29th January. I will circle back then!

Change 991424 merged by jenkins-bot:

[operations/mediawiki-config@master] Use desktop history page HTML everywhere

https://gerrit.wikimedia.org/r/991424

Mentioned in SAL (#wikimedia-operations) [2024-01-29T21:42:14Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:991424|Use desktop history page HTML everywhere (T353388)]], [[gerrit:992931|Begin capturing errors for Wikivoyage]]

Mentioned in SAL (#wikimedia-operations) [2024-01-29T21:43:34Z] <catrope@deploy2002> catrope and jdlrobson: Backport for [[gerrit:991424|Use desktop history page HTML everywhere (T353388)]], [[gerrit:992931|Begin capturing errors for Wikivoyage]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-29T21:54:20Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:991424|Use desktop history page HTML everywhere (T353388)]], [[gerrit:992931|Begin capturing errors for Wikivoyage]] (duration: 12m 05s)

Change 993805 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Drop English Wikipedia configuration

https://gerrit.wikimedia.org/r/993805

Change 993805 merged by jenkins-bot:

[operations/mediawiki-config@master] Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage

https://gerrit.wikimedia.org/r/993805

Mentioned in SAL (#wikimedia-operations) [2024-01-29T22:02:29Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:993805|Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage (T353388)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-29T22:03:48Z] <catrope@deploy2002> catrope and jdlrobson: Backport for [[gerrit:993805|Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage (T353388)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-29T22:31:02Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:993805|Drop English Wikipedia configuration for wgMFUseDesktopSpecialHistoryPage (T353388)]] (duration: 28m 33s)

Jdlrobson claimed this task.

Suggested User-notice text:
"The mobile site now uses the same HTML as the desktop site for history pages. If you hear of any problems relating to mobile history usage please point them to T353388."