Page MenuHomePhabricator
Create Task
Maniphest T316060

[anon prefs] TOC pinned / unpinned status should persist across page views for anonymous users
Closed, ResolvedPublic3 Estimated Story PointsFeature
Actions

Assigned To
None
Authored By
IKhitron
Aug 23 2022, 11:43 PM
Tags
Referenced Files
F37748551: screenshot 32.mov.gif
Sep 22 2023, 2:23 AM
F37730099: screenshot 14.mov.gif
Sep 18 2023, 2:36 AM
Subscribers
Aklapper
• alexhollender_WMF
Edtadros
Hobart
IKhitron
Izno
Jdlrobson
View All 16 Subscribers
Tokens
"Pterodactyl" token, awarded by Stepro."Like" token, awarded by TerraCodes.

Description

NOTE: Blocked on T339268

Description

If someone collapses/hides the table of contents, it should remain hidden as they navigate to other pages. Note: this task should be blocked on T311160.

Original feature request

Hi. Please change the behaviour of the TOC hiding. When clicking on "hide" in the sidebar TOC, it disappears, and wide screen TOP opening button uppears instead. But when opening another article or refreshing this one, the TOC returns. It is not convenient to click the hiding button all the time, if you prefer it always hidden. Thank you.

QA Results - Beta

ACStatusDetails
1✅T316060#9173301

QA Results - Prod

ACStatusDetails
1✅T316060#9189625

Details

SubjectRepoBranchLines +/-
[anon prefs] TOC pinned / unpinnedmediawiki/skins/Vectormaster+27 -1
POC: TOC pinnedmediawiki/skins/Vectormaster+26 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a project: Patch-For-Review.Mar 15 2023, 5:02 PM
Sj subscribed.Mar 15 2023, 7:00 PM

Thanks @Jdlrobson is this planned to be available to logged-out users? What made you list it as stalled?

Jdlrobson added a comment.Mar 15 2023, 7:04 PM

This is blocked on generalizing the code for allowing storage of basic preferences for anonymous users that we use for fixed width toggle. When we rolled that out there were some concerns from the performance team about the viability of that solution as a long term solution. The details are in T331681.

Once T331681 is resolved, fixing this becomes trivial and this would unblock various things including this, dark mode, and user font size.

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 2 2023, 1:22 AM
NBaca-WMF added a parent task: T333867: TDMP Proposal: Preference Persistence For Anonymous Users.Apr 3 2023, 6:36 PM
NBaca-WMF removed a subtask: T331681: Measure performance of cookie-based anonymous client preferences.Apr 3 2023, 8:30 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3); removed Web-Team-Backlog.Apr 5 2023, 5:42 PM
Stepro unsubscribed.Apr 5 2023, 5:55 PM
PatchDemoBot added a comment.Apr 13 2023, 6:45 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/1165364832/w

Jdlrobson moved this task from Web Team FY2022-23 Q4 Sprint 3 to Web Team FY2022-23 Q4 Sprint 4 on the Web-Team-Backlog board.Apr 27 2023, 5:52 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3).
Jdlrobson edited projects, added Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4).May 16 2023, 12:39 AM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6); removed Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 5).May 25 2023, 8:01 PM
Jdlrobson changed the task status from Stalled to Open.Jun 15 2023, 5:25 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 3.Jun 15 2023, 5:30 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 6).Jun 20 2023, 4:38 PM

We bumped T339268 given we're expecting some discussion on the decision record.

Jdlrobson renamed this task from [Feature request] TOC pinned / unpinned status should persist across page views for anonymous users to Client preferences: TOC pinned / unpinned status should persist across page views for anonymous users.Jun 20 2023, 4:38 PM
Jdlrobson renamed this task from Client preferences: TOC pinned / unpinned status should persist across page views for anonymous users to [anon prefs] TOC pinned / unpinned status should persist across page views for anonymous users.Jun 20 2023, 5:09 PM
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1).Jun 29 2023, 5:47 PM

Since this is blocked on T339268.

gerritbot added a comment.Jul 11 2023, 11:36 PM

Change 937196 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] POC: TOC pinned

https://gerrit.wikimedia.org/r/937196

gerritbot added a project: Patch-For-Review.Jul 11 2023, 11:36 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJul 11 2023, 11:36 PM
gerritbot added a comment.Jul 13 2023, 8:07 PM

Change 937196 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: TOC pinned

Reason:

Unlicking for now.

https://gerrit.wikimedia.org/r/937196

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 17 2023, 5:30 PM
ovasileva lowered the priority of this task from High to Medium.Jul 17 2023, 5:43 PM
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 18 2023, 12:17 AM
Mabualruz moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 20 2023, 11:48 AM
Mabualruz moved this task from Code Review to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 20 2023, 12:22 PM
Mabualruz moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.
Mabualruz moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 25 2023, 6:22 AM
Edtadros assigned this task to Mabualruz.Jul 25 2023, 4:47 PM
Mabualruz moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2) board.Jul 26 2023, 12:22 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 2).Jul 31 2023, 5:24 PM
Jdlrobson raised the priority of this task from Medium to High.Aug 7 2023, 5:39 PM

High because we want to validate the new system is working as expected.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4) board.Aug 10 2023, 5:06 PM
gerritbot added a comment.Aug 10 2023, 10:44 PM

Change 937196 restored by Jdlrobson:

[mediawiki/skins/Vector@master] POC: TOC pinned

https://gerrit.wikimedia.org/r/937196

gerritbot added a comment.Aug 10 2023, 10:45 PM

Change 937196 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: TOC pinned

Reason:

https://gerrit.wikimedia.org/r/937196

Jdlrobson lowered the priority of this task from High to Medium.Aug 11 2023, 4:30 PM

@ovasileva i've marked this one as medium as it's a lower relative priority than https://phabricator.wikimedia.org/T343928 and https://phabricator.wikimedia.org/T342277. The two higher priorities are important as they test capabilities as well as fixing bugs.

Jdlrobson removed Mabualruz as the assignee of this task.Aug 11 2023, 11:43 PM
Jdlrobson added a subscriber: Mabualruz.
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 4).Aug 21 2023, 5:17 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 5).Aug 31 2023, 4:42 PM
ovasileva raised the priority of this task from Medium to High.Sep 11 2023, 2:11 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Jdlrobson claimed this task.Sep 11 2023, 9:49 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Jdlrobson removed Jdlrobson as the assignee of this task.Sep 11 2023, 9:58 PM
Jdlrobson moved this task from Doing to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Mabualruz claimed this task.Sep 13 2023, 12:35 PM
Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
gerritbot added a comment.Sep 14 2023, 2:55 PM

Change 956864 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [anon prefs] TOC pinned / unpinned

https://gerrit.wikimedia.org/r/956864

Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 14 2023, 2:56 PM

Seems this one was 99% done already, previous POC patch done by @Jdlrobson was 100% on the mark only needed to remove Zebra support

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 14 2023, 3:14 PM
Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 14 2023, 5:00 PM
gerritbot added a comment.Sep 14 2023, 9:53 PM

Change 956864 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [anon prefs] TOC pinned / unpinned

https://gerrit.wikimedia.org/r/956864

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 14 2023, 10:00 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 14 2023, 10:17 PM
Jdlrobson reassigned this task from Mabualruz to Edtadros.Sep 14 2023, 10:18 PM
Edtadros removed Edtadros as the assignee of this task.Sep 18 2023, 2:36 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: If someone collapses/hides the table of contents, it should remain hidden as they navigate to other pages

screenshot 14.mov.gif (854×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Sep 18 2023, 3:43 AM
Jdlrobson assigned this task to ovasileva.Sep 18 2023, 5:53 PM
Jdlrobson added a project: User-notice.
ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 19 2023, 2:34 PM

Looks good, moving to QA in prod

ovasileva reassigned this task from ovasileva to Edtadros.Sep 19 2023, 2:36 PM
Jdlrobson mentioned this in T346851: Verify 1.41.0-wmf.30 deployment.Sep 19 2023, 11:25 PM
IKhitron subscribed.Sep 21 2023, 12:20 PM
Quiddity subscribed.Sep 21 2023, 10:32 PM

@ovasileva or @Jdlrobson Hi, please could you suggest what wording the Tech News entry should use? IIUC, it's something like this:

Recent changes

  • The Vector 2022 skin will now remember the pinned/unpinned status for the Table of Contents for all logged-out users.

Thanks! (P.s. Drafts always help, otherwise I have to read and understand entire task-threads!)

Jdlrobson added a comment.Sep 21 2023, 10:34 PM

LGTM @Quiddity .

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Sep 21 2023, 10:46 PM
Edtadros closed this task as Resolved.Sep 22 2023, 2:23 AM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: If someone collapses/hides the table of contents, it should remain hidden as they navigate to other pages

screenshot 32.mov.gif (850×1 px, 2 MB)

Edtadros updated the task description. (Show Details)Sep 22 2023, 2:24 AM
Sj unsubscribed.Sep 26 2023, 7:19 PM
Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Sep 28 2023, 6:06 PM
Edtadros closed subtask T346401: Clean Cache HTML support classes for TOC pinned/ unpinned as Resolved.Oct 5 2023, 3:51 PM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Oct 15 2023, 4:31 PM
PatchDemoBot added a comment.Tue, Apr 23, 1:20 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1165364832/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL