Quoting T281772#8260465:
- MetricsClient has the responsibility of maintaining and periodically updating the stream config collection. This should be a separate class/collection of classes that MetricsClient collaborates with
- StreamConfigs are fetched every 30 seconds. What about radio/data consumption?
TODO
- …
Notes
- As part of this task we can and should fix the race condition in the MetricsClientTest.testShouldProcessEventsForStream test case:
[ERROR] org.wikimedia.metrics_platform.MetricsClientTest.testShouldProcessEventsForStream Time elapsed: 0.004 s <<< FAILURE! java.lang.AssertionError: Expected: is <true> but: was <false> at org.wikimedia.metrics_platform.MetricsClientTest.testShouldProcessEventsForStream(MetricsClientTest.java:79)
- Per https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/838230/comment/deb61f9d_a5d75202/, the Java MPC doesn't actually refresh the stream configs every 30 seconds but instead stops fetching them after the first successful fetch.